Commit Graph

5187 Commits

Author SHA1 Message Date
Sirz Benjie
ec4ddab8be
[Bug] [Refactor] [Move] Add selection prevention and move failures (#6276)
* Add failure conditions and move failures part 1

* Add second and third failure sequences

* Refactor mostly complete, need to recheck tests

* Adjust status checks to respect ignoreStatus useModes

* Adjust restriction for stuff cheeks

* Address bertie's review comments

* Add counterRedirectAttr to other counter-like moves

* Adjust some documentation for new methods

* Make substitute use the move tag

* Adjust counter attr to use array.find

* Adjust move condition check that occurs in the third failure check sequence

* Insert move failure check sequence part 4 into move phase

* Revert type adjustment to getBattlerIndex

* Make charging moves deduct pp on use instead of on release

* Fix first move condition not using 1 based starting wave

* Tweak charge move handling and protean timing

* Adjust fly tests to expect pp reduction properly

* Add missing attribute to counter

* Adjust revival blessing hardcore test to respect new return value of isUsable

* Adjust copycat test to account for how it actually works

* Play sleep animation and message

* Remove BYPASS_SLEEP battler tag in favor of boolean holder

* Finish unfinished docs

* Ensure move restrictions are only checked for players

* Adjust pollen puff condition, fix docs on `isOpponent`

* Fix failAgainstFinalBossCondition

* Fix dig test

* Adjust dive's test

* Fix missing break in applyConditions

* Fix getBattlerIndex for enemyPokemon

* Adjust type hint test to not rely on teleport

* Minor adjustments from code review

Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>

* Add tests for teleport

* Minor adjustments from code review

Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>

* PR review changes

Fix type hints test name

Update Dig/Dive test name

Separate TSDoc imports in `pokemon-utils.ts`

Add missing `@returns` in `move-phase.ts`

Fix comment typos

Separate TSDoc imports in `move-phase.ts`

Add return hints to `trySelectMove`

Minor formatting

Remove duplicate `.affectedByGravity()` on Telekinesis

Fix docs for `checkRestrictions`

Manually format method definition

Fix comment spacing

Fix variable naming

* Address kev's review comments

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* Minor adjustments from code review

Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>

* Remove optional chaining

* fix: type for InferKeys

* chore: apply biome

* chore: fix merge conflicts from Biome update

* Remove latent isNullOrUndefined

* Drop readonly on timingModifier

* docs: Add class comment

* Address comments from code review

* Drop readonly from timingModifier

* Cleanup proc chance computation

* Move `cureStatus` into the Pokemon class

* Final touchups

---------

Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-09-29 12:08:42 -05:00
NightKev
6c8130db54 [Misc] Update comment in src/utils/pokemon-utils.ts 2025-09-28 22:06:58 -07:00
Sirz Benjie
3d69fc3b30
[AI][Beta][Bug] Ensure AI always spawns with 4 moves if it can (#6563)
* Fix minimum move count threshold and utilize baseWeights

* Mark a flaky test as TODO

* Add regression test to ensure pokemon generates with sufficient move counts
2025-09-28 22:57:01 -05:00
Dean
abf2df5147
[Bug] Fix CheckSwitchPhase on single -> double and reload (#6594) 2025-09-28 20:34:11 -05:00
NightKev
49e9976328
Revert "[Refactor] Add TIME_OF_DAY_OVERRIDE & refactor arena tint code"
https://github.com/pagefaultgames/pokerogue/pull/6597

Revert "[Refactor] Add `TIME_OF_DAY_OVERRIDE` & refactor arena tint code"

This reverts commit 4349ee82b9.
2025-09-27 14:55:59 -07:00
Wlowscha
f8edaeb1ae
[Misc][UI/UX] See stats of other users in admin panel (#6579)
* Game stats ui handler takes save data as input

* Make admin panel functional for local testing

* Added button to show stats; mocking for local testing with current save data

* Adding pokédex to admin panel

* Many nice things

* Fixed typo

* Add backend support

* Fixed button width in admin panel

* Apply suggestions from code review

---------

Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
2025-09-27 14:44:29 -07:00
Bertie690
4349ee82b9
[Refactor] Add TIME_OF_DAY_OVERRIDE & refactor arena tint code
https://github.com/pagefaultgames/pokerogue/pull/6554

* Removed `ARENA_TINT_OVERRIDE` + minor cleanup of arena tint code

* Added `TIME_OF_DAY_OVERRIDE` to replace tint override

* Fixed visual bug with time of day override

* Fixed the frag stuff and blah blah blah

* Update sprite-types.ts
2025-09-27 14:41:56 -07:00
Sirz Benjie
c695df777c
[Refactor][Dev] Move public to its own submodule (#6590)
* Remove public folder to prepare for submodule

* Add submodule and update licensing

* Stop serving non-asset files during build

* Update pull request template

* Update CODEOWNERS

* Add locales submodule

* Update pull request template regarding locales

* remove post-checkout lefthook in favor of git config

* chore: add license info to new script

* Update gh pages workflow

* Apply kev's suggestions from code review

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* update assets
2025-09-27 11:01:12 -05:00
Wlowscha
62109bdaf9
[Challenge][Bug] Restrict starters with gender-based evolutions in challenges (#6564)
* Added gender restrictions

* No male Ralts in mono fairy challenge
2025-09-25 08:48:47 -05:00
Sirz Benjie
0578729799
[UI/UX] Show username now works with up to 7 local user accounts instead of 2 (#6571)
allow up to 7 usernames in panel before P02
2025-09-25 08:41:44 -05:00
Dean
e5cc11dee7
[Bug] Fix CheckSwitchPhase not appearing on new wave (#6591) 2025-09-25 08:18:23 -05:00
Sirz Benjie
6766940fa1
[Misc] Make the repo REUSE compliant (#6474)
* Add license information

* Add reuse lint workflow

* Add snippets for spdx

* fix: minor wording adjustments and typo fixes

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* chore: add FileContributor attributions for Bertie

Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>

* begin licensing some audio assets

* Add pokemon reborn sound affect attribution

* Annotate Leavannite's section

* Add more licensing info

* Add license info to license files ._.

* Move ps1 files out of public

* Add license for animation jsons

* Add license for bat scripts in public

* Update licensing in scripts

* Fix typo in license ref

* Fix AGPL-3.0-or-later

* Add license info to typedoc.config.js

* Add MIT license for snippets

* chore: update license info for files in scripts

* chore: update license info

* chore: update license info

* chore: update license info

* Remove licenses used only by public before linting with reuse

* Add license info to new files added by docker PR

* chore: apply biome

* fix: add back linting workflow lost during merge

* Add attribution based on Hanniel's information

* Add attribution based on Officer Porkchop and Green Ninja's information

* add attribution to unicorn_power for reshiram/zekrom/kyurem epic variant

* Fixup minor typo

* Adjust sprite test to not think REUSE.toml is a sprite json

* Add missing continue-on-error to workflow

* fix: address kev's comments from code review

* docs: minor touchups

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>
2025-09-23 08:49:03 -05:00
Fabi
84aa8601fb
[Bug] Fix capped rare candy friendship gain (#6565)
* correctly cap rare candy friendship gain

* use correct var for achv
2025-09-23 08:14:22 -05:00
Sirz Benjie
8d5ba221d8
[Refactor] Refactor boss health segment calculation to improve clarity (#6574)
* Refactor boss health bar

* Apply Kev's suggestions from code review

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-09-22 20:08:39 -05:00
Lugiad
cffbafe4bd
[i18n] Language codes adjustments (#6587) 2025-09-22 05:45:28 -07:00
Dean
1c9843618c
[Misc] Blacklist more dynamic phases (#6585) 2025-09-21 12:05:13 -07:00
Sirz Benjie
d3edfb25a1
[Bug][Ability] Queenly Majesty flyout during move select (#6569) 2025-09-21 19:04:57 +00:00
Wlowscha
2fe99cc3bf
[Refactor] Refactor Starter and its handling (#6477)
* Reworked `Starter` interface with more explicit information

* Use Starter in ssui

* Fixed some bugs

* Passing starter.ivs to playerPokemon

* Using speciesIds

* Fixed getTestRunStarters

* Reverted some parameter changes

* Initialize starters in ssui

* Don't clear starters before starting run

* Fix to game manager

* Apply suggestions from code review

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* Set ivs to 0 in part timer test

* Setting the right ivs

* Moved ssui to handlers folder

* Ran biome all

* Fixed broken imports

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-09-21 11:07:08 -07:00
NightKev
be61996044 [Docs] Fix/update some comments and spacing 2025-09-21 00:22:53 -07:00
Dean
25416ebf47
[UI] Avoid prematurely updating HP bar when applying damage (#6582)
Avoid prematurely updating HP bar when applying damage
2025-09-20 22:24:50 -05:00
Dean
87e6095a00
[Misc/Feature] Add dynamic turn order (#6036)
* Add new priority queues

* Add dynamic queue manager

* Add timing modifier and fix post speed ordering

* Make `phaseQueue` private

* Fix `gameManager.setTurnOrder`

* Update `findPhase` to also check dynamic queues

* Modify existing phase manager methods to check dynamic queues

* Fix move order persisting through tests

* Fix magic coat/bounce

* Use append for magic coat/bounce

* Remove `getSpeedOrder` from `TurnStartPhase`, fix references to `getCommandOrder` in tests

* Fix round queuing last instead of next

* Add quick draw application

* Add quick claw activation

* Fix turn order tracking

* Add move header queue to fix ordering

* Fix abilities activating immediately on summon

* Fix `postsummonphases` being shuffled (need to handle speed ties differently here)

* Update speed order function

* Add `StaticSwitchSummonPhase`

* Fix magic coat/bounce error from conflict resolution

* Remove conditional queue

* Fix dancer and baton pass tests

* Automatically queue consecutive Pokémon phases as dynamic

* Move turn end phases queuing back to `TurnStartPhase`

* Fix `LearnMovePhase`

* Remove `PrependSplice`

* Move DQM to phase manager

* Fix various phases being pushed instead of unshifted

* Remove `StaticSwitchSummonPhase`

* Ensure the top queue is always at length - 1

* Fix encounter `PostSummonPhase`s and Revival Blessing

* Fix move headers

* Remove implicit ordering from DQM

* Fix `PostSummonPhase`s in encounters running too early

* Fix `tryRemovePhase` usages

* Add `MovePhase` after `MoveEndPhase` automatically

* Implement an `inSpeedOrder` function

* Merge fixes

* Fix encounter rewards

* Defer `FaintPhase`s where splice was used previously

* Separate speed order utils to avoid circular imports

* Temporarily disable lunar dance test

* Simplify deferral

* Remove move priority modifier

* Fix TS errors in code files

* Fix ts errors in tests

* Fix more test files

* Fix postsummon + checkswitch ability activations

* Fix `removeAll`

* Reposition `positionalTagPhase`

* Re-add `startCurrentPhase`

* Avoid overwriting `currentPhase` after `turnStart`

* Delete `switchSummonPhasePriorityQueue`

* Update `phase-manager.ts`

* Remove uses of `isNullOrUndefined`

* Rename deferral methods

* Update docs and use `getPlayerField(true)` in turn start phase

* Use `.getEnemyField(true)`

* Update docs for post summon phase priority queue (psppq)

* Update speed order utils

* Remove null from `nextPhase`

* Update move phase timing modifier docs

* Remove mention of phases from base priority queue class

* Remove and replace `applyInSpeedOrder`

* Don't sort weather effect phases

* Order priority queues before removing

- Add some `readonly` and `public` modifiers

- Remove unused `queuedPhases` field from `MoveEffectPhase`

* Fix linting in `phase-manager.ts`

* Remove unnecessary turn order modification in Rage Fist test

---------

Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-09-20 17:49:40 -05:00
Dean
d02980dd4e
[Move] Fully implement Healing wish (/Lunar Dance) and remove nextCommandPhaseQueue (#6027)
* Remove NCPQ

* Implement PendingHealTag

* Fix test

* Code review

* Use message directly instead of as key in tag

* Update tag for serialization

* Update test import

* Update src/data/arena-tag.ts

Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>

* Remove isNullOrUndefined uses

* Fix arena tag type(o)

* Fix pendinghealtag

* Fix hwish tests

* Arena tag denesting

---------

Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
2025-09-20 17:32:31 -05:00
Sirz Benjie
207808f37d
[Docs] Cleanup docs in pokemon.ts (#6543)
* [Docs] Cleanup docs in pokemon.ts

* Apply suggestions from code review

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>
Co-authored-by: Fabi <192151969+fabske0@users.noreply.github.com>

* chore: apply biome

* revert changes to docstrings that will conflict
2025-09-20 17:15:57 -05:00
Dean
405b1d389d
[Bug] Apply Supreme Overlord only once on summon (#6575)
* Implement supreme overlord as a battler tag

* Make ability a conditionalattr

* Add tag to map

* Update test

Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>

* Add edgeCase marker

* Extend from AbilityBattlerTag

* Run biome

---------

Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>
2025-09-19 23:08:02 -05:00
Sirz Benjie
16a903b975
[Bug][Ability] Remove flyout for rivalry (#6577)
Remove flyout for rivalry
2025-09-19 20:47:35 -07:00
Fabi
7d83a3a24a
[UI/UX] Show correct max duration in flyout (#6566)
* Fix terrain & weather max duration flyout

* show correct max duration for tags

* maka maxDuration optional in arenaEvent constructor

* Apply suggestions from code review

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-09-18 13:35:22 -07:00
Madmadness65
0e87391b20
[Misc] Update biome pools in init functions (#6572)
Added new biome entries for Type: Null, Silvally, Poipole, Naganadel, Kubfu, Urshifu, Scientist, and Swimmer to their respective init functions, and reran `outputPools`.
2025-09-18 14:13:52 -05:00
Sirz Benjie
da766f364c
[Tests] Cleanup getCookie and add many unit tests (#6562)
Cleanup `getCookie` and add many unit tests
2025-09-18 12:52:15 +00:00
Fabi
37e6371eef
[Dev] Allow forcing all trainer variants in trainer override (#6391) 2025-09-16 10:48:19 -05:00
Madmadness65
e25db16326 [P3 Bug] Fix login screen not playing menu_open SFX properly
It did not properly specify that the SFX file was in the ui folder.
2025-09-16 02:45:30 -05:00
Sirz Benjie
0c921cdb4a
[Tests][Bug][Beta] Fix ditto bug and add unit tests (#6559)
* Fix ditto bug and add unit tests

Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>
2025-09-15 23:26:57 -05:00
Sirz Benjie
85c38dfdbe
[Bug] Cookies being fetched improperly v2 2025-09-15 19:55:45 -05:00
Sirz Benjie
6ce59ecbd9
[Bug] Cookies being fetched improperly 2025-09-15 19:49:18 -05:00
Sirz Benjie
8013093513
[Bug] Secondary fusions with gender evo condition can now evolve (#6510) 2025-09-15 14:04:13 -05:00
NightKev
b7cee4b313 [Misc] Remove leftover temporary comments in pokemon.ts 2025-09-15 00:25:25 -07:00
NightKev
de94e738fb [Docs] Add blank space to prevent incorrect comment attachment
Biome will "attach" comments to imports if there is no space between
them when it sorts imports (this allows suppression comments to work)
2025-09-14 20:45:01 -07:00
Sirz Benjie
793dea0024
[Bug] [Docs] Fix @module tags (#6557)
Fix `@module` tags
2025-09-14 22:35:12 -05:00
Xavion3
25a2fb4266
[Balance] Tweak trainer moveset TM generation. (#6533)
* Lower TM weight in moveset generation.

* Implement a cap on amount of TMs based on wave.

* Extract ai moveset generation to its own file

* Minor doc cleanup

* Move magic numbers to balance file and export them

* Tweak stab move weight generation

---------

Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
2025-09-14 21:44:58 -05:00
Madmadness65
24a0ca95f4
[Balance] Change Happiny evolution method, update Chansey happiness req
https://github.com/pagefaultgames/pokerogue/pull/6551

* [Balance] Change Happiny evolution method

Happiny now evolves into Chansey by using an Oval Stone during the Dawn or Day, instead of 160 friendship (Blissey's friendship requirement of 200 remains unchanged).
Also removed unnecessary comments from Gligar's and Sneasel's evolutions.

* Update Chansey -> Blissey 200 -> 180 Friendship Required (Base 140)

---------

Co-authored-by: damocleas <damocleas25@gmail.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-09-14 14:58:56 +00:00
Sirz Benjie
521b88eabe
[Bug] [Beta] Fix bug where boss segments are not actually broken (#6553)
Fix bug where boss segments are not actually broken
2025-09-13 18:36:21 -05:00
Sirz Benjie
3ed6a9a960
[Balance] Trainer boss Pokémon no longer gain a stat boost when a boss segment is broken #6552
Trainer boss Pokémon no longer gain a stat boost when a boss segment is broken
2025-09-13 16:21:24 -04:00
Sirz Benjie
e233f24526
[Deps] Update biome to 2.2.4 (#6550)
* Update biome and adjust rules

* Add noMisusedPromises

* Downgrade `noMisusedPromises` to info, enable noImportCycles
2025-09-13 20:13:21 +00:00
Bertie690
c217f47942
[Refactor] Added playTween utility function (#6545)
* Added `playTween` utility function

Co-authored-by: innerthunder <168692175+innerthunder@users.noreply.github.com>

* Update comment wording for benjie

---------

Co-authored-by: innerthunder <168692175+innerthunder@users.noreply.github.com>
2025-09-13 18:36:38 +00:00
Bertie690
465f0c2ced
[Refactor] getPokemonById returns undefined instead of null
https://github.com/pagefaultgames/pokerogue/pull/6544

* [Refactor] Make `BattleScene.getPokemonById` return `undefined` instead of `null`

* fixed substitute unit test :(

* Update src/phases/obtain-status-effect-phase.ts

Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>

* Update src/phases/pokemon-phase.ts

Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>

* Update battle-scene.ts comment for dean

* Add todo comment

---------

Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-09-12 22:19:48 -07:00
Sirz Benjie
c7a2c666af
[Refactor] Remove isNullOrUndefined in favor of loose check against null (#6549)
* Remove `isNullOrUndefined` in favor of loose check against null

* Fix missing method call

* Remove isNullOrUndefined import
2025-09-12 14:53:27 -05:00
Wlowscha
559ca8610a
[Misc] Simplifying imports of UI files (#6542) 2025-09-11 00:30:17 -07:00
Fabi
e4a6a3de82
[Bug] Allow catch in limted catch during teleporter ME (#6531)
Allow catch in teleporter ME
2025-09-11 06:07:49 +00:00
Fabi
328cc0221e
[i18n] Camel case remaining keys (#6508)
* fix egg gacha keys

* fix battle keys

* fix game stats

* fix splash texts
2025-09-10 18:45:01 -05:00
Wlowscha
9a92f98f63
[Refactor] Move type definitions away from game-data.ts (#6487)
* Move type definitions away from game-data.ts

* Update src/@types/data-types.ts

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* Renamed file to save-data.ts

* Fixed broken import

* Moved some ui files

* Run biome, fix broken import

* Fixed one more broken input
2025-09-10 14:09:33 -05:00
Sirz Benjie
d9d6163b07
[Bug] Make touch events prevent pointer events (#6528) 2025-09-10 13:59:21 -05:00
Fabi
ff6de568af
[UI/UX] Add language selection to login screen (#6302)
* add language selection

* Move language option up

* Move language list to seperate file

* fix circular dependency

* Move language selection to own icon

* run biome

* add icon

* add icon to legacy ui
2025-09-10 13:53:57 -05:00
Sirz Benjie
c09d43273a
[Docs] Remove stray import 2025-09-10 13:47:53 -05:00
Bertie690
496d9a10d7
[Test] Added matcher to check message contents; added tests for Splash, Celebrate, Laser Focus (#6299)
* Fixed laser focus test to not whiff instruct

* fix test checking last hit twice in row lul
2025-09-10 13:40:21 -05:00
Sirz Benjie
e75c8e5691
[Bug] [Ability] Fix stat boost message timing for quark drive / protosynthesis (#6529)
Make proto and quark drive stat boost happen after proc instead of at end
2025-09-10 13:37:00 -05:00
Sirz Benjie
c0b3b0c55e
[Docs] Fixup typedoc warnings (#6540)
* Replace `@return` with `@returns`

* Remove extends tags

* Remove `@overrides` tag

* Remove `@abstract` tags

* Remove `@overload` tags

* Remove `@description` tags

* Remove `@static` tags

* Remove `@private` tags

* Remove `@warning`

* Remove `@PokemonSpecies`

* Remove {} appearing after `@returns`

* Remove {} appearing after `@param`

* Bump typedoc version

* Remove ...args in `@param` and replace with args

* Cleanup docs in challenge.ts

* Adjust hyphens

* Remove parenthesis in `@see` tags

* Remove old `@see` references
2025-09-10 13:35:55 -05:00
Wlowscha
6f3f6026a8
[UI/UX][Refactor] Moved and renamed some ui files (#6538)
* Moved and renamed some ui files

* Renamed two handlers to helpers
2025-09-10 10:42:38 -05:00
Sirz Benjie
42a87cf228
[UI/UX] In settings, clamp volume cursor at boundary (#6504)
* feat(settings): clamp volume cursor at boundary

* Extract left/right logic to own method

Co-authored-by: Wlowscha <54003515+Wlowscha@users.noreply.github.com>

---------

Co-authored-by: Wlowscha <54003515+Wlowscha@users.noreply.github.com>
2025-09-10 17:37:23 +02:00
Xavion3
5dcbedf364
Add blacklist of moves that can't be forced STAB. (#6491)
* Add blacklist of moves that can't be forced STAB.

* Add exploding moves to blacklist.

* Change blacklist from array to list.

* Sort blacklist and add steel beam

---------

Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
2025-09-10 10:11:57 -05:00
Madmadness65
df223bfbc8
[Misc] [Bug] Remove summary_overlay_shiny from loading scene (#6532)
Remove `summary_overlay_shiny` from loading scene

This file was renamed and moved in PR #6433 so this loadImage is no longer needed here.
2025-09-09 18:26:23 -05:00
Fabi
b4cbbf1b8f
[Bug] remove node:console import (#6530) 2025-09-09 15:35:09 -07:00
Xavion3
acb1522138
[Balance] Allow enemy trainer pokemon to use relearn moves (#6515) 2025-09-08 20:06:12 +00:00
Bertie690
c0da686ba0
[Dev] Migrated to Biome 2.2.3, added more rules (#6259)
* Added more biome rules

* Fixes

* Added a few more rules

* Added global phaser to biome

* Fix tpyo

* Updated biome to 2.1.4; improved docs on linting/localization; added vcs support

Also added `.build` to gitignore cuz reasons

* Fixed tpyo

* dd

* Applied linter fixes

* Partially fixed some private property issues

* Upgraded to Biome 2.2.0; added `operatorLinebreak` and a few new rules

* Moved operator linebreaks before lines

* Applied kev's suggestions

* Update biome.jsonc

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* added like all the rules and then some

* modify biome.jsonc

* apply biome formatting

* Reverted changes to balance folder

* fixed stuff

* Fixed biome stripping trailing globstars from everything

* made `noInvertedElse` an error rule

* Add & apply fixes for `useExplicitLengthCheck`, `useAtIndex` and `noNonNullAssertedOptionalChain`

* Bumped biome to 2.2.3

* Fixed a few syntax errors

* Removed trailing globstars since biome actually fixed their shit

* Final clean up

* foobarbaz

* Fixed remaining issues

* Fixed a few errors in SSUI

* fixed rounding issue

* Fixed test to not round funky

* Fixed biome false positive for vitest hooks

* Apply biome:all

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
2025-09-08 10:35:18 -05:00
NightKev
d8fa0ff083 Merge branch 'beta' into hotfix-1.10.7 2025-09-07 18:21:37 -07:00
Sirz Benjie
43f8b78c35
[Bug] Fix sessions clearing the wrong slot on save (#6509)
* Store session id in session data to prevent somehow deleting wrong slot

* Only log session / system if beta or local; fix promise

* Fix serialization/deserialization when logging session/system data

* Force loadSaveSlot to set the logged in user's last session

* No longer add slotId to session data
2025-09-07 18:17:12 -07:00
Sirz Benjie
8fdd5043c3
[Bug] [Ability] Prevent message flyout spam for sturdy, damp, and a few other abilities (#6507)
* fix: prevent message spam for many abilities

* Update src/data/abilities/ability.ts
---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-09-07 18:39:52 -05:00
Wlowscha
e175bbfb28
[UI/UX] Use pointer events instead of touch events in TouchControl (#6506)
* Use pointer events instead of touch events in `TouchControl`

* Marked some touch-related tests as todo

* Changing test mocker to send pointer events

* Also updated the ui to change the position of touch controls

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-09-07 17:35:49 -05:00
Sirz Benjie
344e9463cc
[Bug] Fix memory leak in egg hatch (#6511)
Co-authored-by: MokaStitcher <54149968+MokaStitcher@users.noreply.github.com>
2025-09-07 17:05:25 -05:00
Wlowscha
d0f5b3f613
[Refactor][UI/UX] Reorganize UI files (#6503) 2025-09-07 13:05:40 -07:00
Bertie690
8b95361d61
[Dev] Added egg move parse script & script type checking (#6116)
* Added egg move parse utility script

* Update interactive.js

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* Update interactive.js

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* Update interactive.js

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* Applied kev's reviews

* Removed `basePath` from tsconfig

the docs literally recommend against using it so yeah

* Fixed up configs so that script folder has its own file

* Reverted changes to egg move contents

* renamed boilerplate so biome doesn't lint it

* Fix `jsconfig.json` so that it doesn't typecheck all of `node_modules`

See https://github.com/microsoft/TypeScript/issues/50862#issuecomment-1565175938 for more info

* Update tsconfig.json

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* Updated workflows and fixed issues

* Removed eslint from linting workflow

* Fixed type error in d.ts file to shut up linters

* Reverted test-filters.yml

* Update biome.jsonc

* Update decrypt-save.js comment

* Update interactive.js

* Apply Biome

* Fixed type errors for scripts

* Fixed biome from removing tsdoc linkcodes

* Update test/@types/vitest.d.ts

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-09-07 11:35:52 -07:00
NightKev
2cf23b7ea7 [Misc] Fix console log colors 2025-09-07 10:58:40 -07:00
Bertie690
9815c5eebf
[Test] Revamped MockConsoleLog with color support (#6218)
* Added mock console and fixed up many many things

* Cleaned up handling of colors and such

* Added minor comment

* Fix Focus Punch test

* Fix typo

* Remove redundant comment

* Update vitest.setup.ts

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* Added color map inside new folder

* Made constants not object bc i was told to

* Update src/constants/colors.ts

* Removed all moves init check

* Removed import

* Fixed up some stuff + added aquamarine color to settings helper

* Added logging for test end

* Removed intentionally failing test

* Fixed console log to use inheritance to not override vitest's wrapping

* Added a custom Vitest reporter to not log the test name every 2 lines

* Moved coloration to a hook to prevent misplacing things

* Fixed import issue by copypasting vitest soure

* Removed intentionally failing test

look i need to check that `test:silent` works on github ok

* Added REUSE annotations to copied parts of source

* Fixed import issue

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-09-07 09:18:47 -05:00
HeeMyung Kim
444080bb78
[UI] Add cyclic navigation in settings menu for LEFT/RIGHT buttons (#6404)
* feat: add cyclic navigation to settings menu

* review > refactor: use Phaser.Math.Wrap instead the ternary operator
2025-09-06 18:16:43 -05:00
Lugiad
39760a8514
[UI/UX] [Localization] Battle & Party UI translation (#6482) 2025-09-06 02:08:33 -07:00
Anthony
ad61a28e88
[Bug] Moody Can't Lower Stats at +6 (#6481) 2025-09-06 06:46:13 +00:00
HeeMyung Kim
ddc04a7a87
[Bug] [UI/UX] Fix random button activation bug (#6464) 2025-09-06 06:40:38 +00:00
Xavion3
3765f843db
[Refactor] Remove randSeedWeightedItem utils function. (#6492)
Remove randSeedWeightedItem utils function.
2025-09-06 06:12:32 +00:00
Bertie690
d630c106e0
[Test] Improved typing on BattlerTagData and ArenaTagData; improved test matchers (#6338)
* Improved typing on `BattlerTagData` and `ArenaTagData`
* Added dragon cheer/focus energy tests
* Cleaned up descs
2025-09-05 21:50:37 -05:00
Bertie690
309e31e196
[Bug] Future Sight no longer crashes after catching the user (#6479) 2025-09-05 14:38:01 -04:00
Bertie690
d5e6670456
[Refactor] Remove null from PhaseManager.currentPhase signature
https://github.com/pagefaultgames/pokerogue/pull/6243

* Added `toBeAtPhase` + removed `null` from phase manager current phase signature

* Removed bangs from various calls to phase manager

* Update phase-manager.ts

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* ran biome

* Fix missing bang

* Simplify TSDoc

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-09-05 09:28:35 -07:00
Wlowscha
fce317a87a
[Documentation][Move] Add edge case to helping hand (#6340) 2025-09-05 09:21:28 -07:00
Fabi
ddde977a0a
[UI/UX] Auto focus first input field (#6413) 2025-09-04 02:31:52 -07:00
Fabi
e477c505bc
[UI/UX] Show correct able text when transferring all items (#6444)
* Check if items are able to transfer for `ALL` option

* show amount of transferable items in `ALL` option

* Show number of transferable items in the 'ALL' option

* Apply suggestions
2025-09-04 09:03:55 +00:00
Bertie690
669ed76daf
[Misc] Cleaned up implementation of ChargeMove mixin (#6466)
Co-authored-by: Wlowscha <54003515+Wlowscha@users.noreply.github.com>
2025-09-04 11:01:24 +02:00
Wlowscha
1a06010820
[UI/UX][Refactor] Remove redundant references to globalScene.uiTheme (#6472)
Removed most references to globalScene.uiTheme
2025-09-03 19:17:19 +02:00
NightKev
317e45ec75
[Dev] Simplify isLocal and add start:prod/start:beta (#6470)
- The constant `isLocal` now checks to see if `import.meta.env.MODE`
is `"development"` (which it is when running via `pnpm start:dev`)
instead of checking what URL is being used to access the client
(e.g. `"localhost"` or an IP address)

- Remove `start` from `package.json` and replace it with
`start:prod` (which runs `vite --mode production`) and
`start:beta` (which runs `vite --mode beta`)

`start:prod` -> `isBeta` and `isLocal` are both `false`
`start:beta` -> `isBeta` is `true` and `isLocal` is `false`
`start:dev` -> `isBeta` is `false` and `isLocal` is `true`

- Remove obsolete/unused `localServerUrl` and `apiUrl` constants
2025-09-02 19:49:45 -07:00
Sirz Benjie
4a28773929
[Bug] [Move] Fix poltergeist crash when no remaining enemies (#6473)
* fix: poltergeist crash with no target

* fix: adjust move phase history
2025-09-03 02:44:43 +00:00
Fabi
9fc31350f8
[Bug] Fix monotype selector image (#6471) 2025-09-03 02:07:40 +00:00
Lugiad
34430b4057
[UI/UX] [Localization] Summary UI translation (#6433)
* Summary UI Transaltion

* Summary UI Translation

* Summary UI Translation

* Summary UI Translation

* Summary UI Translation

* Summary UI Translation

* Summary UI Translation

* Summary UI Translation

* Summary UI Translation

* Summary UI Translation

* Summary UI Translation

* Remove unnecessary loading of en images when lang is not en

Consolidate duplicate code

---------

Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: Wlowscha <54003515+Wlowscha@users.noreply.github.com>
Co-authored-by: damocleas <damocleas25@gmail.com>
2025-09-02 03:25:41 +00:00
Sirz Benjie
fc85a168f5
Merge pull request #6469 from pagefaultgames/hotfix-1.10.6
Hotfix 1.10.6 to beta
2025-09-01 19:08:09 -05:00
Xavion3
bc0e2662fa Clean up bangs 2025-09-02 06:53:57 +10:00
Xavion3
eb8c0c0243 Add comment explaining bang 2025-09-02 06:53:55 +10:00
Xavion3
bd7de61a56 Improve error handling when playing unloaded sounds 2025-09-02 06:53:55 +10:00
NightKev
446908ae13
[Misc] Add " (Beta)" to site title and version display on beta (#6418) 2025-09-01 07:02:40 -07:00
Bertie690
17c28c4024
[Bug] Fix monotype challenge using unlocalized type names (#6438) 2025-09-01 05:57:46 -07:00
Xavion3
64ad2ee9c2 Make e4 not automatically recharge tera 2025-09-01 08:12:04 +10:00
AJ Fontaine
231cfd040c
[Balance] TM tier changes 1.10.6 (#6461)
* TM tier changes 1.10.6
2025-08-31 13:47:53 -04:00
damocleas
9a00bc2f10
Merge branch 'hotfix-1.10.6' into fix-enemy-level-position 2025-08-31 11:23:38 -04:00
fabske0
2a5e66d85f update pos 2025-08-31 17:17:25 +02:00
Lugiad
e0a752aa70
[UI/UX] [Localization] Korean and Chinese Visual Fixes (#6452) 2025-08-31 13:55:50 +00:00
fabske0
320641eaa2 fix position 2025-08-31 15:25:27 +02:00
Fabi
929f721ee0
[Bug][UI] Fix ribbon and status effect overlap (#6453) 2025-08-31 01:07:50 +00:00
Wlowscha
5c22d9ccac
[Bug] Pokemon not on the field can't be caught (#6454) 2025-08-31 00:54:35 +00:00
Sirz Benjie
264dd6b2d0
[Bug][Sprite] Ensure evo silhouette disappears in evo phase (#6450)
Ensure evo silhouette disappears in evo phase
2025-08-30 20:41:58 -04:00
Fabi
4dc067daa2
[Bug] [UI/UX] Fix options during item transfer (#6425) 2025-08-29 23:52:39 +00:00
NightKev
dadc7b9598
[Bug] Breaking a boss bar will no longer crash at max stat stages (#6440)
Co-authored-by: Wlowscha <54003515+Wlowscha@users.noreply.github.com>
2025-08-29 07:36:43 +02:00
Fabi
58ba29a1be
[Bug] Fix soak message i18n key (#6443) 2025-08-27 01:23:37 -07:00
Bertie690
1f2788a438
[Bug] Fix Soak message key not being in camel (#6439) 2025-08-26 20:47:12 -07:00
Xavion3
4b18ad74b3
[Balance] Adjust moveset generation weighting (#6387) 2025-08-26 16:47:51 -07:00
Sirz Benjie
443d747ad1
Merge branch 'main' into beta 2025-08-26 12:34:28 -05:00
Sirz Benjie
6745ce7839
Fix starterpref reset (#6430)
* Prevent an empty starterpreferences object from being saved

* Fix ssui nullish coalescing

* Update src/utils/data.ts

Co-authored-by: Dean <69436131+emdeann@users.noreply.github.com>

* Fix starter preferences clearing, add tests

---------

Co-authored-by: Wlowscha <54003515+Wlowscha@users.noreply.github.com>
Co-authored-by: Dean <69436131+emdeann@users.noreply.github.com>
2025-08-26 12:11:16 -05:00
NightKev
12142c0af7
Merge pull request #6424 from pagefaultgames/main
Merge main to beta
2025-08-26 01:23:58 -07:00
NightKev
701eecf947
Revert #6410 starter preferences hotfix (#6422)
Revert "[Bug] Prevent an empty starterpreferences object from being saved (#6410)"

This reverts commit c8a66b2e59.
2025-08-26 03:15:00 -05:00
NightKev
f2d46b666d
Merge branch 'beta' into hotfix-1.10.4 2025-08-25 23:59:42 -07:00
Wlowscha
63c1c34746
[Hotfix] Fix tyrogue evo (#6414)
* Fixed tyrogue evo condition

* Added test for tyrogue evolution

* Update src/data/balance/pokemon-evolutions.ts

Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>

* Update src/data/balance/pokemon-evolutions.ts

Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>

* Update src/data/balance/pokemon-evolutions.ts

Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>

* Added missing typeof in suggestion

---------

Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>
2025-08-26 06:57:11 +00:00
Sirz Benjie
88e42ba4c4
[Balance][ME]Tweak weird dream do a party heal in option 1, random tera, and no longer revive pokemon in hardcore (#6409)
* Tweak weird dream option 1

Transfer HP ratio and status onto transformed pokemon

* Make weird dream randomize tera type
2025-08-26 06:54:26 +00:00
AJ Fontaine
4aac5472a9
[Bug] Fix oversight where mons aren't guaranteed damaging moves if none are STAB (#6406) 2025-08-26 06:51:35 +00:00
Sirz Benjie
c8a66b2e59
[Bug] Prevent an empty starterpreferences object from being saved (#6410)
* Prevent an empty starterpreferences object from being saved

* Fix ssui nullish coalescing

* Update src/utils/data.ts

Co-authored-by: Dean <69436131+emdeann@users.noreply.github.com>

---------

Co-authored-by: Dean <69436131+emdeann@users.noreply.github.com>
2025-08-25 23:48:55 -07:00
Bertie690
1b6a52e520
[Balance] Moved Future Sight after Weather, before berries (#6412) 2025-08-25 14:55:31 -07:00
Xavion3
e95450aa49
Imported systemdata always increments playtime (#6394)
Co-authored-by: Wlowscha <54003515+Wlowscha@users.noreply.github.com>
2025-08-25 23:17:16 +02:00
NightKev
dc31ae257a
Merge branch 'beta' into hotfix-1.10.3 2025-08-24 18:29:37 -07:00
Sirz Benjie
4b8c064335
[Bug] [Ability] Fix berserk multi proc (#6402)
* Fix berserk activating multiple times with multi strike

* Apply kev's suggestions from code review

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* Update doc comments

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-08-24 19:47:52 -05:00
Sirz Benjie
6fac1a5052
[Bug] [Ability] Fix cute charm (#6399)
Fix cute charm not working
2025-08-24 17:49:28 -05:00
Sirz Benjie
a85d8cd5de
[Bug] [Sprite] Fix fusion shiny party icon (#6397)
* Fix shiny icon with fusion shiny in party

* Fix hover tooltip not working when first splicing a mon

* Fix fusion shiny icon on summary screen
2025-08-24 16:32:12 -05:00
Sirz Benjie
cd610ff2c5
[Bug] [Ability] Fix trace's RNG (#6398)
* Fix rng in trace

* Fix undefined var
2025-08-24 16:24:12 -05:00
Sirz Benjie
30b7a62988
[Bug] [Sprite] Fix third type icon missing texture (#6395)
Fix third type icon
2025-08-24 15:03:28 -05:00
Sirz Benjie
efaf7760e4
[Bug] Fix speedup/slowdown buttons not working properly (#6393)
Fix speedup button resetting to minimum speed
2025-08-24 14:34:21 -05:00
Bertie690
0f8b1f63b5
[Bug/Ability] Fixed bugs with Intimidate triggers after reload/initial switch (#6212)
* Added TODO test case + documentation for failing intim test

* Fixed comment

* Fixed intimidate bugs fr fr

* Update src/data/phase-priority-queue.ts

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* Update src/data/phase-priority-queue.ts

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* Cleanup remove phase logic

* Do not add unnecessary activateAbilityPhases for pokemon that do not have their passive enabled

* Remove leftover log messages

* Add TODO comment

Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
2025-08-24 14:09:16 -05:00
Sirz Benjie
049932c001
[Bug] Fix status effects overwriting each other (#6392)
* Ensure status effects from same source interaction cannot override each other

* Update test/status-effects/general-status-effect.test.ts

Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>
2025-08-24 12:51:16 -05:00
Wlowscha
ae58f9de4f
[Hotfix] Leech Seed does not get cleared when user faints (#6388)
Lapsing leech seed tag even when source has left field
2025-08-24 08:58:27 -05:00
Sirz Benjie
cc066fc7d1
Merge branch 'beta' into hotfix-1.10.2 2025-08-23 19:13:49 -05:00
Sirz Benjie
746ea69475
[Bug] Fix missing fusion icon (#6381)
Fix nullish coalescing in `pokemon#isFusion`
2025-08-23 18:58:29 -05:00
Wlowscha
c44e589303
[UI/UX][Bug] Saving preferences when leaving ssui (#6376)
Save starter preferences when leaving ssui
2025-08-23 18:50:44 -05:00
Sirz Benjie
70b47945e8
[Bug] Fix nicknames not showing up in battle (#6378) 2025-08-23 23:47:39 +00:00
Sirz Benjie
842f0e88b0
[Bug] Fix saveslot deletion (#6380)
Fix saveslot deletion
2025-08-23 18:45:15 -05:00
Fabi
1192825d51
[Bug/i18n] Fix unpause evolution option in party ui (#6379) 2025-08-23 15:59:01 -07:00
Fabi
1b2c694084
[bug/i18n] Fix stealth rock message (#6377)
replace pokemonName with pokemonNameWithAffix
2025-08-23 17:26:12 -05:00
Bertie690
af963c7902
[Bug] Fixed delayed attacks pushing to move history twice on charging turn (#6371) 2025-08-23 16:00:00 -05:00
damocleas
cd137062ea
Fix Option 1 Leftovers text in Trash to Treasure encounter 2025-08-23 13:28:09 -04:00
Sirz Benjie
99bf639ea7
[Bug] [Move] Fix pollen puff (#6363)
* Ensure pollen puff does not heal enemy after damage

* Add test to ensure pollen puff does not heal enemy
2025-08-23 11:42:10 -05:00
Blitzy
873e12f9ad
[Balance] Clamperl Egg Moves / Passive Tweaks (#6365)
Clamperl changes
2025-08-23 11:42:02 -05:00
Sirz Benjie
053976daec
[Bug] Fix ssui passives (#6362)
Fix passives not being persisted in starter select
2025-08-23 11:41:30 -05:00
Sirz Benjie
908886d78b
Fix unpauseEvolutions key in party select 2025-08-23 11:23:15 -05:00
Fabi
3b290ee9a2
[UI/UX][Bug] Prevent switch to discard mode while transferring item (#6358) 2025-08-23 10:05:48 -05:00
Wlowscha
16adb02ad2
[Item][Bug] No more free sacred ash (#6356) 2025-08-23 10:00:27 -05:00
Sirz Benjie
3dd1948634
[Misc] Fix circular dep (#6361) 2025-08-23 10:00:00 -05:00
Wlowscha
e63effa311
[Challenge][Bug] Fix fresh starters for real (#6355)
* Including side evolutions of starters
2025-08-23 09:45:11 -05:00
NightKev
8b371395bc
[Bug] Fix typo in i18n key for second Berries Abound ME option (#6354) 2025-08-23 09:43:56 -05:00
Wlowscha
e752e7a93d
[Bug][Item] Items can be transfered from 6th item slot again. (#6357)
* Added check for transferMode
2025-08-23 09:43:33 -05:00
NightKev
961d30f75e
[Bug] Wild Pokemon can now generate as female again (#6352) 2025-08-23 09:42:41 -05:00
NightKev
4ac1a5739c
[Misc] Remove unused generateGender method from Pokemon (#6353) 2025-08-23 09:59:59 -04:00
Wlowscha
7050e15267
[Challenge][Bug] Partial Fix Available starters in fresh start monotype (#6344)
Full fresh start filter also accepts evolutions

Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-08-22 22:09:30 -04:00
Madmadness65
cdf470c06c [Item] Minor item weight change for Deep Sea items
Halved the weight of the items in the Great tier.
2025-08-22 20:59:01 -05:00
Sirz Benjie
abd9ebbdef
[Bug] Fix egg gacha 10x pull option working with just one voucher (#6349)
Fix 10x egg gacha being usable with only 1 voucher
2025-08-22 20:52:50 -05:00
Wlowscha
7af128f68a
[UI/UX][Bug] Setting shiny preferences before saving (#6348)
Setting shiny preferences before saving
2025-08-22 20:50:38 -05:00
Wlowscha
342eb33138
[UI/UX][Bug] Fix typos in trainer class keys (#6347)
* Fixing "fenale" typo

* Changing "key" to key
2025-08-22 18:12:38 -07:00
Sirz Benjie
6361762fc9
[Bug] [UI/UX] [Beta] Fix visibility of egg moves in ssui (#6343)
Fix visibility of egg moves when backing out of fresh start and back into ssui
2025-08-23 01:25:27 +02:00
damocleas
254d34fd08
[Misc] [UX] Add Daily Run Achievement, Re-Arrange Achievements, Replace some Icon Sprites (#6292)
* wip achievement changes

* Adjust egg image sizes, re-export item atlas

* painful eggs

* Add egg to legacy UI, re-export item atlas

* run biome

* Update achievement.test.ts

* Fix achievement test file

* Fix tera stellar missing icon path

* Fix achievement test file

* egg s

* Optimize new images, re-export item atlas

* update pngs and locale

* add daily achv and other sorting

* Optimize ribbons, re-export item atlas

* Bump to version 1.11.0

* more changes, waiting on pngs

* Update package.json

* ribbon fixes

* images!

* Optimize images, re-export item atlas

* final fix

---------

Co-authored-by: Madmadness65 <blaze.the.fireman@gmail.com>
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
2025-08-22 19:21:17 -04:00
damocleas
5ee547a39a
[Balance] [ME] Trash to Treasure Option 1 Adjustment (#6341)
* Update trash-to-treasure-encounter.ts

* Update trash-to-treasure-encounter.test.ts tests
2025-08-22 17:37:16 -04:00
Bertie690
c3cce668fc
[Misc] Moved scrapeTrainerNames to a script; removed selfStatLowerMoves (#6258)
* Removed scrape trainer names

* Removed `selfStatLowerMoves`

* Update move.ts

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* Started work on the script again

* Made script actually work

* Made finishing touches on script

* Fixed main repo code to not expect snake cased locale strings

* Update trainer.ts

Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>

* Remove biome ignore range

* Fix typedoc.json

* rename `getRandomLocaleKey` to `getRandomLocaleEntry`

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
2025-08-22 16:09:33 -05:00
Sirz Benjie
edeb116ead
[Bug] Ensure MEs disabled in a challenge mode only do so while challenge is active (#6337)
* Ensure MEs disabled in a challenge mode only do so while challenge is active

* Optimize checking disallowed challenges
2025-08-22 15:27:55 -05:00
Blitzy
fae6620bae
[Beta] [Balance] Even More 1.10 Balance Changes (Egg Moves + Passive Changes) (#6339)
1.10 Egg Moves and Passives pt 3
2025-08-22 16:05:37 -04:00
Wlowscha
39b2d9865a
[Beta][Bug][UI/UX] Fix broken candy upgrades (#6322)
* Candy upgrades change permanent starter data again

* Updating cost icon and passive bg in starter select after buying pokédex upgrades
2025-08-22 09:52:44 -05:00
Sirz Benjie
01cd11e731
[Bug] [Beta] Fix trick room message (#6327)
Fix trick room's arena tag message
2025-08-22 09:46:50 -05:00
Wlowscha
6992a91819
[Challenge] No hardcore breeder (#6334)
Disallow expert breeder encounter in space

Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
2025-08-22 10:07:59 -04:00
Wlowscha
b9a46a6a26
Restricted party options for fainted mons in hardcore (#6336) 2025-08-22 09:00:13 -05:00
Bertie690
978f06427c
[Bug] Sheer Force no longer boosts Fickle Beam; Focus Energy gives +2 crit instead of +1 (#6331)
[Bug] Sheer Force no longer boosts Fickle Beam; Focus Energy correctly gives +2 crit stages instead of +1
2025-08-22 08:59:06 -05:00
Wlowscha
9c498003aa
[UI/UX] Always show starter's natures and ivs in evolution's dex entry (#6335)
Natures and ivs use starter's dexEntry
2025-08-22 08:57:45 -05:00
Wlowscha
187cd9e356
[Beta] Fresh Start no longer overrides IV unlocks (#6333)
Unpack ivs when copying dexData
2025-08-22 00:23:45 -07:00
NightKev
8904cfc37b
Revert #6307 "Remove duplicate animation json for ... variants" (#6332)
Revert "[Refactor][Sprite] Remove duplicate animation json for shinies, sprite-based variants (#6307)"

This reverts commit 7bdb62ed1d.
2025-08-21 22:38:38 -07:00
Blitzy
d8769d8051
[Beta] [Balance] Fix Wrong Teras in Trainer Config (#6326)
* Update trainer-config.ts
---------
Co-authored-by: damocleas <damocleas25@gmail.com>
2025-08-21 19:24:20 -04:00
Blitzy
0702e66cd9
[Beta] [Balance] Add Wild Evo Delay to Gallade / Froslass (#6324)
* Update pokemon-evolutions.ts
---------
Co-authored-by: damocleas <damocleas25@gmail.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-08-21 19:22:07 -04:00
Bertie690
0f94e97a2a
[Misc] Removed last vestiges of / 4096 from codebase (#6316) 2025-08-20 21:51:33 -04:00
Wlowscha
14bd80f639
[Enhancement] Separate encountered stat from seen stat (#6315)
* Using seenCount in pokedex and game stats

* Species seen now also include caught data

---------

Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
2025-08-20 21:47:22 -04:00
Bertie690
c59a2013b9
[Move] Trick Room now reverses itself when added twice in a row (#6314) 2025-08-20 20:22:52 -05:00
Sirz Benjie
65799ef80c
[Bug] [Beta] Prevent crash when attempting to select a move not in the user's moveset (#6313)
* Prevent crash when attempting to select a move not in the user's moveset

* Fix typo in tsdoc

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-08-20 20:18:35 -05:00
Acelynn Zhang
f34be91891
[Ability] Embody Aspect now triggers on switch-in while Terastallized (#6294)
* Fix Embody Aspect triggers

* Use selectWithTera

* apply suggestions

---------

Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
2025-08-20 20:10:54 -05:00
AJ Fontaine
030b701910
[Refactor] Change rare egg rate consts to array, rare egg move common egg boosted chance boosted (#6305)
* Change rare egg rate consts to array

* Update rates.ts

1/24 -> 1/16

* Make new arrays use readonly type hint

---------

Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
Co-authored-by: damocleas <damocleas25@gmail.com>
2025-08-21 01:55:16 +02:00
AJ Fontaine
4eee569046
[Dev] Fix missing import in challenge.ts (#6312)
Fix missing import in challenge.ts
2025-08-20 18:47:10 -05:00
AJ Fontaine
7bdb62ed1d
[Refactor][Sprite] Remove duplicate animation json for shinies, sprite-based variants (#6307)
* Remove duplicate animation json

* Remove duplicate json for sprite-based variants

* Fix sprite test

* Fix name of variable

---------

Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
2025-08-20 18:27:08 -05:00
Wlowscha
e85b479032
[UI/UX][Challenge] Starter select screen shows reduced information in fresh start (#6277)
* Introduced `getSpeciesData` function

* Saving and loading starter preferences as intended without conflicts

* Hiding shiny star and hidden ability icon, showing correct nature

* Forcing first tera type always

* Fixed bug which prevented tera from displaying the saved preference; tera resets in fresh start

* Ensuring that label text updates correctly

* Removed large commented code, plus lock on hardy nature.

* Excluded specific forms from fresh start, fixed bug with default nature

* Removed Rockruff from restricted forms

* Moves update correctly when switched around

* Making tera type persist in preferences

* Saving starter preferences after every change

* Tera type not resetting randomly

* Removed some log messages

* Incorporated suggestions from review

* Only allowing unlocked neutral natures, or default to hardy if no natures are unlocked

* Capping ivs at 15 instead of setting them at 15

* Apply suggestions from code review

Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>

* Hiding various things

* Ran biome

---------

Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
2025-08-20 19:26:17 -04:00
Wlowscha
14a0a23abc
[Balance][Challenge] Block master ball catching final boss in challenges (#6273)
* Block catching bosses in nuzlockes

* Changes to conditions to restrict master ball use

* Implemented new can't catch messages

* Fixed some bugs which prevented correct usage of balls

* Special casing full fresh start

* fix text Update command-phase.ts

* Added tests for failing catches

* Using `mockI18next`

* Shorten a couple of variable declarations

* Fixed bug that allowed catching trainer pokemon in end; showing double battle failure only if other failure messages do not apply

* Fixed order of error messages

* Changed description of tests with "in end biome" instead of "paradox mon(s)"

* Not override nature after selection

* Update test/field/catching.test.ts

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

---------

Co-authored-by: damocleas <damocleas25@gmail.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
2025-08-20 19:24:55 -04:00
Mourouh
7f49a35d6b
[Balance] Minor Trainer adjustments (#6308)
Remove WEAKER templates, adjust Twins, add rare seen encounters to trainers (Slakoth, Bounsweet) (not Beldum)

Co-authored-by: damocleas <damocleas25@gmail.com>
2025-08-20 19:19:49 -04:00
Blitzy
07bf7bb5ca
[Balance] Hisui Lilligant Evo Method Change (#6309)
Update pokemon-evolutions.ts
2025-08-20 19:14:00 -04:00
NightKev
ee297a58bb
[Misc] Change framerate of Pokemon based on its status effect (#6284) 2025-08-21 00:11:16 +02:00
Wlowscha
d2e9615457
[UI/UX] Save in starter select screen after moveset changes (#6287)
* Save after moveset changes

* Saving only when the moveset is actually changed

* Removed logs, added docs

* Update src/ui/starter-select-ui-handler.ts

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
2025-08-20 15:57:13 -05:00
Bertie690
c94a570aca
[Refactor] Minor cleanup of Turn Start Phase (#5984)
* Reworked Turn Start Phase to be less jank

* Fixed sutff

* Update turn-start-phase.ts

* Update turn-start-phase.ts

* Ran biome

* Fixed up documentation for speed order functions

* Fix locales submodule

* Update src/phases/turn-start-phase.ts

Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>

* Update turn-start-phase.ts

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: Wlowscha <54003515+Wlowscha@users.noreply.github.com>
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
2025-08-20 13:53:11 +00:00
Bertie690
6c03181621
[Bug] Refactored status code, fixed Rest/Sleep Talk status checks (#5872)
* Reworked status code, fixed bugs and added Rest tests

* Fixed rest bug

* Fixed bugs, split up status code, re-added required Rest parameter

* Cleaned up comments and such

* Added edge case to rest about locales

* Maybe did stuff

* Split up `trySetStatus` fully; fixed rest turn order display to match mainline

* Reverted healing changes to move to other PR

* Fixed message code a bit

* Condensed all status immunity tests under 1 roof

* Fixed the tests

* Added pollen puff tests back again

* Fixed swallow test

* Reverted swallow test

fixing in other prs

* Fixed pollen puff

* Fixed cirrc dep isuse

* fixed stockpile to no longer fail on stack full

* Fixed rest thing...?

* readded swallow conds

* Fixed tests

* wip

* Fixed tests

* Added pokemon heal phase to the turn queue

* ddddd

* Fixed the tests

* Fixed corrosion test

* Ran linting

* Fixed infiltrator bug

* Fix pokemon.ts

* Update move.ts

* Update corrosion.test.ts

* Update pokemon.ts documentation

* Remove missed line in TSDocs

* Update pokemon.ts

Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>

* Update modifier.ts

Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>

* Update modifier.ts

Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>

* Update obtain-status-effect-phase.ts

* Fix merge issues and apply Biome

* Revert pokemon-heal-phase.ts

* ddddd

* Fixed test file syntax err

* Update toxic spikes status set text to be quiet

* ran biome

* ran boime

* Prevent rest failure message from displaying outside of move phase

---------

Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-08-20 08:45:09 -05:00
Bertie690
2821728743
[Refactor] Cleaned up arena trap moves; prevented serialization of max layers (#6210)
* Grabbed matchers from other branch

* Cleaned up entry hazard arena tags; merged tests into 1 file

* Marked test as TODO because IDK how to make it pass

* Re-added test file + ran biome

* Sort imports in `vitest.d.ts`

* Fix Stealth Rocks test

* Renamed arena traps to entry hazards fr fr

* fixed matcher to have default value

* Fixed errors

* Update arena-tag.ts

Co-authored-by: Wlowscha <54003515+Wlowscha@users.noreply.github.com>

---------

Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: Wlowscha <54003515+Wlowscha@users.noreply.github.com>
2025-08-20 08:32:27 -05:00
Bertie690
cf5378905e
[Test] Removed deprecated functions from phase interceptor (#6195)
* Removed deprecated functions from phase interceptor

* Added minor docs to the phase manager + renamed `shift` to `shiftPhase`

* Added `selectStarterPhase` to the end by set mode collection

* Fixed issues and syntax errors

* somehow fixed reload bug by making things actively worse

* Perhaps fixed things?

* maybe fixed?

* Fixed tests

* fixed another dumb error bc me big dumb bozo

* dddddd

* Update phase-interceptor.ts

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* Re-add `!` and add `TODO` comment instead

---------

Co-authored-by: Wlowscha <54003515+Wlowscha@users.noreply.github.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
2025-08-19 19:54:40 -05:00
fabske0
effa45228e
[i18n] Change i18n keys to be camel case Part 4 (#6290)
* change run-history

* change menu

* change settings

* change splash texts

* Change trainer classes

* change trainer names

* Change trainer titles

* fix trainer config comments and `setTitle()`

* change challenges

* update challenge 2

* change pokedex ui handler

* Update locales submodule
2025-08-19 13:17:23 -07:00
Sirz Benjie
dd03887d05
[Challenge] [Beta] Block other ribbons when flip stats or inverse battle is active (#6289) 2025-08-19 01:37:43 +00:00
Wlowscha
3d9cb539c7
[Bug][P1] Fix trapping abilities crashing game on switch out (#6293)
Move trapped messages into a .then() statement
2025-08-19 00:30:12 +00:00
NightKev
5500f2ff8d
[Dev] Generate moveset when using player Species override (#6039) 2025-08-19 00:01:18 +00:00
Madmadness65
9662b7c8c9
[Audio] Add new Wasteland BGM track (#6285) 2025-08-18 09:27:37 -04:00
Jimmybald1
74136a9c2b
[Beta][Bug] Fixing Ribbons that do not work because of integer overflow (#6288)
Change ribbondata number to bigint

Co-authored-by: Jimmybald1 <147992650+IBBCalc@users.noreply.github.com>
2025-08-18 08:04:23 -05:00
Jimmybald1
02de259554
[Beta][Bug] Fix ribbon pre-evolution award not using prevoid (#6283)
Fix ribbon pre-evolution award not using prevoid

Co-authored-by: Jimmybald1 <147992650+IBBCalc@users.noreply.github.com>
2025-08-17 21:22:04 +00:00
G Sai Nikhilesh
bf9f0880b6
[UI/UX] Add Username to Stats Screen (#6270)
* [Feature] Add Username to Stats Screen

* [Feature] username fallback to "Guest"

* [UI/UX] Update display name fallback to use translation for guest user

* Update locales submodule

* [Fix] Username updates without refresh

* Update locales submodule

---------

Co-authored-by: Wlowscha <54003515+Wlowscha@users.noreply.github.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-08-17 14:02:29 -07:00
fabske0
06496f9135
[i18n] Change i18n keys to be camel case Part 3 (#6266)
* chnage nature locales use

* chnage party ui locales use

* change pokemon category locales use

* chnage pokemon evos locales uses

* change pokemon form battle use

* change pokemon form uses

* Change pokemon info uses

* fix `stat.ts` workflow fail

* Change pokemon summary

* Change pokemon localize

* Temporarily revert changes to `achv.ts`

* Re-add changes to `achv.ts`

* Update locales submodule
2025-08-17 13:13:09 -07:00
fabske0
03f54c1d8a
[i18n] Change i18n keys to be camel case Part 2 (#6250)
* Change Achv locales

* Change berry locales use

* change bgm name locales use

* change biome locales uses

* change double battle dialogue use

* change misc dialogue locales use

* change dialogue locales use

* change growth locales use

* update menu-ui-handler locales use

* change ME texts locales uses

* fix biome drop down

* fix a few missed keys

* Update locales submodule
2025-08-17 12:59:09 -07:00
fabske0
5d13714ea6
[i18n] Change i18n keys to be camel case MEs (#6237)
* changed ME `intro_dialogue` to camel case

* changed MEs part 1

* changed MEs part 2

* changed MEs part 3

* chnaged MEs part 4

* Update locales submodule
2025-08-17 12:46:12 -07:00