pokerogue/test
Tiago Rodrigues 75ececd942
[UI/UX] Implement Discard Button (#5985)
* [feature]Implemented needed parts for discard function from issue #4780:
-TryDiscardFunction in battlescene;
-Created a party discard mode button;
-Updated Transfer button in modifier-select-ui-handler to Manage items;
-Created tests for the discard function in test/ui;
-Added images for the new discard and transfer buttons to loading-scene;
-Created placeholder messages for discard feature in party-ui-handler;

Co-authored-by: Tiago Rodrigues <tiago.n.rodrigues@tecnico.ulisboa.pt>

* [Fix] Updated icon for dynamic messaging

* [Fix] Corrected legacy mode icons and adjusted double-battle button location

* [Fix]Adjusted button positioning and mapping after review. Mapping requires debugging.

* [Fix] Fixed visible pokeball in legacy mode and key mapping

* [Fix] Background fixes,manage menu is the only one affected by changes now

* Implement i18n keys

* [Fix] implemented most code optimizations and callbacks to the modified locales folder

* [Fix] Implemented 3 suggestions

* [Fix]improved/corrected test structure

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* [Fix] added functionality test for the discard button

* [Fix] added necessary comment

Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>

* [Fix] Implemented suggested changes in test/discard text prompt

* [Fix] Implemented UI suggestions and removed discard text confirmation

* [Fix] added missing imports

* Fix imports in test file

* [Fix] Implemented suggested cursor behavior and reworked test code

* [Fix] Corrected failed test

* [Fix] atempting to fix the test timeout issue

* [Fix] Undoing latest attempt

* [Fix] Implemented suggestions to fix broken tests

* Reviews

* [Fix] replaced icon images

* [Fix] Updated jsons to match new icons and removed pokeball icon from legacy mode

* Optimized new images

* [Fix] Fixed referenced bug and added similar confirmation box to release

* [Fix] Updated tests to handle the corfirmation box

* [Fix] Added back the accidentally removed changes

* [Fix]updated incorrect import path

* [fix] add description for the manageItemMode function

Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>

* Update src/ui/party-ui-handler.ts

Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>

* [Fix] corrected formating issue

---------

Co-authored-by: Mikhail Shueb <mikhail.shueb@tecnico.ulisboa.pt>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>
Co-authored-by: damocleas <damocleas25@gmail.com>
Co-authored-by: Bertie690 <taylormw163@gmail.com>
Co-authored-by: Adri1 <adrien.grivel@hotmail.fr>
2025-07-31 16:14:51 -04:00
..
@types [Misc] Fix import in vitest.d.ts 2025-07-27 13:32:47 -07:00
abilities [Refactor][Bug] Illusion no longer overwrites data of original Pokemon 2025-07-26 16:07:16 -06:00
achievements [Misc] Standardize-file-names (#6137) 2025-07-24 16:38:31 -04:00
arena [Bug] Unblock priority spread under Psychic Terrain (#6136) 2025-07-25 01:05:14 +00:00
battle [Misc] Standardize-file-names (#6137) 2025-07-24 16:38:31 -04:00
battler-tags [Misc] Standardize-file-names (#6137) 2025-07-24 16:38:31 -04:00
data [Misc] Standardize-file-names (#6137) 2025-07-24 16:38:31 -04:00
eggs [Misc] Standardize-file-names (#6137) 2025-07-24 16:38:31 -04:00
field [Misc] Standardize-file-names (#6137) 2025-07-24 16:38:31 -04:00
inputs [Misc] Standardize-file-names (#6137) 2025-07-24 16:38:31 -04:00
items [Misc] Standardize-file-names (#6137) 2025-07-24 16:38:31 -04:00
moves [Move Bug] Fully implemented Future Sight, Doom Desire; fixed Wish Double battle oversight (#5862) 2025-07-30 22:43:06 -06:00
mystery-encounter [ME] [Bug] Disable trades in GTS ME with only 1 valid party member 2025-07-29 20:15:17 +00:00
phases [Test] Add missing single battle override to CheckInterludePhase test 2025-07-29 20:02:30 -07:00
plugins/api [Misc] Standardize-file-names (#6137) 2025-07-24 16:38:31 -04:00
setting-menu [Misc] Moved + cleaned up string manipulation functions (#6112) 2025-07-27 13:59:03 -07:00
sprites [Misc] Standardize-file-names (#6137) 2025-07-24 16:38:31 -04:00
system [Misc] Standardize-file-names (#6137) 2025-07-24 16:38:31 -04:00
test-utils [Refactor] Added PhaseManager.toTitleScreen (#6114) 2025-07-31 06:27:54 +00:00
types [Move Bug] Fully implemented Future Sight, Doom Desire; fixed Wish Double battle oversight (#5862) 2025-07-30 22:43:06 -06:00
ui [UI/UX] Implement Discard Button (#5985) 2025-07-31 16:14:51 -04:00
utils [Misc] Moved + cleaned up string manipulation functions (#6112) 2025-07-27 13:59:03 -07:00
account.test.ts [Dev] Enable Biome import sorting (#6052) 2025-07-13 00:21:25 -07:00
battle-scene.test.ts [Misc] Standardize-file-names (#6137) 2025-07-24 16:38:31 -04:00
boss-pokemon.test.ts [Misc] Standardize-file-names (#6137) 2025-07-24 16:38:31 -04:00
daily-mode.test.ts [Misc] Standardize-file-names (#6137) 2025-07-24 16:38:31 -04:00
endless-boss.test.ts [Misc] Standardize-file-names (#6137) 2025-07-24 16:38:31 -04:00
enemy-command.test.ts [Misc] Standardize-file-names (#6137) 2025-07-24 16:38:31 -04:00
escape-calculations.test.ts [Misc] Standardize-file-names (#6137) 2025-07-24 16:38:31 -04:00
evolution.test.ts [Misc] Standardize-file-names (#6137) 2025-07-24 16:38:31 -04:00
final-boss.test.ts [Misc] Standardize-file-names (#6137) 2025-07-24 16:38:31 -04:00
font-face.setup.ts [Misc] Standardize-file-names (#6137) 2025-07-24 16:38:31 -04:00
game-mode.test.ts [Misc] Standardize-file-names (#6137) 2025-07-24 16:38:31 -04:00
imports.test.ts [Dev] Enable Biome import sorting (#6052) 2025-07-13 00:21:25 -07:00
internals.test.ts [Misc] Standardize-file-names (#6137) 2025-07-24 16:38:31 -04:00
matchers.setup.ts [Misc] Fix import in vitest.d.ts 2025-07-27 13:32:47 -07:00
misc.test.ts [Misc] Standardize-file-names (#6137) 2025-07-24 16:38:31 -04:00
reload.test.ts [Misc] Standardize-file-names (#6137) 2025-07-24 16:38:31 -04:00
utils.test.ts [Dev] Enable Biome import sorting (#6052) 2025-07-13 00:21:25 -07:00
vitest.setup.ts [Dev] Remove sanitizeOverrides, consolidate initialization code into 1 file 2025-07-25 01:23:13 +00:00