Commit Graph

298 Commits

Author SHA1 Message Date
NightKev
7456c11be1
[Refactor] Consolidate typings/ into @types/, and API types (#6823) 2025-12-10 00:31:41 -08:00
NightKev
3f5c37c881
[Balance] The cost of buying same-species eggs can be reduced (#6837)
* [Balance] The cost of buying same-species eggs can be reduced

After hatching a certain number of eggs for a starter,
the cost of buying same-species eggs
for that starter will be reduced (up to 50%)

* Add test to validate array lengths for egg costs
2025-12-09 20:00:20 -08:00
NightKev
46df6adab3
[Ability] Poison Puppeteer now applies for abilities (#6836)
* [Ability] Poison Puppeteer now applies for abilities

When a target is poisoned due to an ability of a Pokemon that also
has Poison Puppeteer, Poison Puppeteer will now apply its effect

* Add tests for Poison Puppeteer

* Remove parameter properties from `ObtainStatusEffectPhase`
2025-12-09 19:48:28 -08:00
Bertie690
6af869cff1
Merge pull request #6819 from Bertie690/set-position-relative
[Misc] Dedupe + move phaser method stubs into separate file
2025-12-04 09:20:21 +00:00
Bertie690
8ae79450d4
[Test] Fix even more game.scene.getXXX issues (#6811)
* [Test] Fixed even more `game.scene.getXXX` issues

* Update fell-stinger.test.ts

Co-authored-by: Fabi <192151969+fabske0@users.noreply.github.com>

* Applied review comments

* fixed doodle test inconsistencies

* fix

* applied reviews

not going too ham will make another PR later

---------

Co-authored-by: Fabi <192151969+fabske0@users.noreply.github.com>
2025-12-04 01:49:47 +00:00
Fabi
e1b0e0f0ae
[Balance] Allow candy gain for uncaught pokemon (#6791)
* allow candy gain for uncaught mons

* carry over friendship

* apply suggestions

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* Add friendship/candy related tests

* Refactor friendship cap tests

* Fix typo

* Apply suggestions from code review

Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>

* Fix test

* Update test/field/pokemon.test.ts

Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>

* Replace `.startBattle` with `.runToSummon`

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>
2025-12-02 12:54:12 +00:00
NightKev
03cc0b1af2 [Misc] Remove now-obsolete noUselessStringConcat suppression comments 2025-11-29 21:01:26 -08:00
NightKev
c12d9140fc [Misc] Remove now-obsolete noUnusedImports suppression comments 2025-11-29 20:52:45 -08:00
NightKev
b6bd9566e2
[Dev] Update Biome from 2.3.2 to 2.3.8 (#6799)
* Update Biome to `2.3.8` and run Biome over the repo

* Update comment in `biome.jsonc`
2025-11-29 14:39:58 -08:00
NightKev
9bfe5f02d8
[Deps] Update packages and add 1d min age for package updates (#6804)
* [Deps] Update packages and add 1d min age for package updates

* Fix tests
2025-11-29 18:49:20 +01:00
NightKev
4f52627146 [Misc] Fix param typing for OverridesHelper#startingLevel 2025-11-27 20:58:36 -08:00
Bertie690
0a1cad4814
[Test] Fix incorrect path join logic in test-end-log.ts (#6756)
* [Test] Fix incorrect path join logic in `test-end-log`.ts

* Update test-end-log.ts

* remove unused import

* Apply Biome

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-11-15 08:20:50 +00:00
Bertie690
4e080465b9
[Bug] Fix Ball Fetch activating on enemy Pokemon (#6777) 2025-11-14 08:27:53 +00:00
damocleas
e438536dc3
Hotfix 1.11.3 to Beta
Hotfix 1.11.3 to beta
2025-11-08 10:31:28 -05:00
Bertie690
d8d5c12bbc
[Bug] Fix 2-turn/charging moves breaking on lack of targets (#6759) 2025-11-07 04:27:07 +00:00
Bertie690
e1aded9504
[Bug] Fix Parental Bond reducing damage of spread moves on 2nd pokemon
https://github.com/pagefaultgames/pokerogue/pull/6743

* Fix Pollen Puff interaction with Parental Bond

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-11-06 18:03:32 -08:00
Bertie690
84dc143f74
[Misc] Improve type inference on PositionalTagManager#addTag (#6676)
* Improve type inference on `PositionalTagManager#addTag`

- Remove unused `AddPositionalTagAttr`

* Improved tests

* fixed type errors

* Update move.ts

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-11-02 04:51:35 +00:00
Bertie690
d3088c1729
[Dev] Add more Biome rules (#6604)
* Added `noBannedTypes` as a biome rule

* Added `useShorthandAssign` rule

* Added `useConsistentArrayType`

* Update src/field/pokemon.ts

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* Update src/data/pokeball.ts

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* Apply Biome after merge

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-11-01 20:38:04 -07:00
Bertie690
4b9ccf5408
[Bug] Fix NoTransformAbilityAttr not doing anything (#6693)
[Bug] Fix `NoTransformAbilityAttr` not doing anythin
2025-11-01 23:18:04 +00:00
Wlowscha
f2f8cc67ba
Merge branch 'beta' into cached-fetch 2025-11-02 00:13:59 +01:00
Bertie690
f41752c3f9
[Test] Fix test end log check mark (#6726)
* [Test] Fix test end log check mark

heavy check mark looks weird on more fonts than the normal one

* Added variant selector codepoint to force rendering as thin version

* Update test/test-utils/setup/test-end-log.ts

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* Changed checkmark back to normal one

idfk how this works maaaan

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-11-01 23:09:36 +00:00
Wlowscha
e92ae80b7d
Merge branch 'hotfix-1.11.2' into disable-illusion 2025-11-01 00:56:18 +01:00
Wlowscha
a4b11d901e
Merge branch 'hotfix-1.11.2' into shiny-daily-starters 2025-11-01 00:37:57 +01:00
Bertie690
fb274077c2 Reworked regex to use matchAll, added error handling + tests 2025-10-31 19:01:51 -04:00
Dean
525ba57461 Review changes 2025-10-31 15:46:43 -07:00
Dean
a0d3e42f3b
Merge branch 'hotfix-1.11.2' into quick-claw 2025-10-31 15:34:04 -07:00
Dean
e78796077b Disable Illusion 2025-10-31 13:22:40 -07:00
Dean
df98e506ad
[Bug] Prevent self speed ties (#6719)
* Prevent self speed ties

* Remove outdated parameter doc

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-10-31 00:38:49 -04:00
Dean
9a4381c776 Re-Add MovePriorityModifier 2025-10-30 18:58:06 -07:00
NightKev
3159846c50 [Test] Update some sprite tests to give useful errors on fail 2025-10-30 16:00:28 -07:00
Bertie690
24e9dcdadc
[Feature] Allow setting movesets via custom daily seed (#6712)
* Clean up Daily Run custom seed gen; add moveset post-processing

* Remove redundant `fetchDailyRunSeed` function

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-10-30 16:15:20 +00:00
damocleas
075679eba1
[Balance] More 1.11 stuff (#6680)
* Update trash-to-treasure-encounter.test.ts
* Update trash-to-treasure-encounter.ts
* pain and suffering is lessened
* rotom is just gonna be random now (arena.ts)
* looked at biomes.ts a lot today, not a fan (of rotom, fan)
* stares at weather.ts intensely (lots of small changes)
* Update init-biomes, slight tweaks to encounters
* yay so many more biome.ts please be the last until biome rework
* oh I also changed dudunsparce and maushold to 1/16 to match the others
* ok, biomes.ts one final I think
* minor fixes for biomes.ts
* Update init-biomes.ts
* Adjust Minimum Party Size and Max Allowed Encounters for some ME's
2025-10-29 12:51:00 -04:00
Bertie690
ab2d5bcfb5 [Tests] Cleaned up cachedFetch test stub 2025-10-27 21:12:14 -04:00
Fabi
3d5a46b1ec
[BUG] Fix quick claw being blocked by Psychic terrain (#6684)
* Fix quick claw being blocked

* Add tests

* Apply suggestions from code review

Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>

* fix test + run biome

* Update comments in `terrain.ts`

* Apply test suggestions

* added newlines

---------

Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-10-27 18:37:33 +00:00
Bertie690
64176a0920
[Test] Cleaned up enum test utils (#6653)
* added type tests
* Update test/test-utils/string-utils.ts
* Update docs

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-10-26 13:03:46 -05:00
Bertie690
82181c5264
[Test] Remove duplicate fake out test (#6691) 2025-10-25 17:55:36 -07:00
Fabi
08e6bba2db
[Refactor] Only use first active timedEvent (#6679)
* rename `getShinyMultiplier`

* simplify methods to use first active event instead of sometimes using all active events

* change remaining methods to use first event

* use `ModifierTypeKeys` instead of `string` for wave rewards

* rename `shinyMultiplier` to `shinyEncounterMultiplier` and add `shinyCatchMultiplier`

* update comments

* add comment

* Fix capitalization of variable, remove comment

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-10-23 01:27:38 -07:00
Anthony
7d8ccfb745
[Bug] Stats that were reset from moves display properly as being reset
https://github.com/pagefaultgames/pokerogue/pull/6650

* Stats display properly after moves reset stats

* Update test/moves/clear-smog.test.ts

Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>

* Removed unnecessary test for Clear Smog

---------

Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>
2025-10-22 23:25:14 +00:00
NightKev
71c1f44f91 [Test] Fix typo in Mat Block test 2025-10-22 16:22:59 -07:00
damocleas
2109aace1d
[Balance] 1.11 Extra Changes (#6651)
* Add extra EXP Charm to Classic, Add 1 Ability 1 Shiny Charm to Daily

* Update Delibird moveset in pokemon-level-moves.ts based off of PLA

* Dragon Claw TM Ultra -> Great

* some gmax changes Update pokemon-species.ts

* X items - Update modifier.ts

* (Beta) Milotic and Golisopod slot 3 -> 4 Update rival-party-config.ts

* test fix for x items Update temp-stat-stage-booster.test.ts

* Update tms.ts air cutter and sky drop

* Update tms.ts water pulse and brutal swing

* (beta) fix for admins Update fixed-battle-configs.ts

* (beta) fix Update challenge.ts too
2025-10-21 20:45:02 -04:00
Fabi
bcc79a6118
[UI/UX] Add option to release Pokemon in shop phase (#6665)
* add `release` option to shop phase

* Fix test

* Don't show `release` option during switch
2025-10-17 22:52:25 -04:00
NightKev
ffbaf311c6
[Beta] Pixilate/etc no longer affect non-Normal type moves (#6661) 2025-10-16 14:27:13 -07:00
Bertie690
112963637a
[Test] Improved liquid ooze test file to use updated test utils (#6633) 2025-10-07 23:42:27 -05:00
Bertie690
15b6877a86
[Bug/i18n] Added type safety to Arena.applyTags; fixed arena tag addition/removal messages (#6304)
* Fixed up arena tags `apply` with type safety; removed unused parameters from tags

* Enforced member visibility on a few methods

* Made arena tag layers readonly; cleaned up callsites

* Added tests for stone axe

* Fixed mat block + removed unused file

* Fixed up the tests for locale messages + fixed lucky chant

* Reverted change to light screen DR%

* Fixed tests to not check neutralizing gas msgs

* Fixed inverted conditional in test file

* Update doc comments for type-helpers.ts

* Added util to make `it.each` test cases from a bunch of enums

* Fixed up tsdocs

* Fixed type error + removed broken util

* Fixed TR signature

* FIxed type errors caused by pending heal tags

* Remove `undefined` from `onOverlap`'s signature

* allow sourceless arena tags once again

---------

Co-authored-by: Lugiad <adrien.grivel@hotmail.fr>
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-10-07 23:38:51 -05:00
Wlowscha
06fe3c7b76
[UI/UX] Add option to see ribbons in Pokédex (#6596)
* Added various ribbon utils

* Added ribbon tray to pokédex page

* V button in Pokédex toggles IVs

* Introduced visibility toggle

* Added ribbons (and full ivs) to unlocks file

* For real this time

* Added descriptions to the ribbons

* Fixed bug of tray not opening with visibility option on

* Minor cleanup of ribbon tray

* Use unique ribbon icons

* Make achv use image instead of sprite

* Tweak size of ribbons

* Improve clarity on comment

---------

Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
2025-10-07 23:29:19 -05:00
NightKev
b76ecf55fd
[Dev] Add isApp & build:app for AdmiralBilly's offline app (#6632)
- Consolidate `isBeta`/etc into `src/constants/app-constants.ts`

- Rename `isLocal` to `isDev`

- Replace `import.meta.env.DEV` with `isBeta || isDev`
2025-10-06 18:51:33 -07:00
Sirz Benjie
e5e0835a96
[Misc][Refactor] Add scaffolding for TypedArrays and improve typing on methods related to arrays (#6547)
* make IVs use Uint8Array

* Add many typed array helpers

* Move array utils to its own file

* Add suppression comment

* Adjust type of `getStats`

* Adjust test mocks to use typed arrays

* Adjust signatures of some phases to use ArrayLike<T>

* Adjust signature of src/ui/containers/stats-container#updateIvs

* Remove comment gap to try to satisfy typedoc

* Ensure ivs are always set

* fix: fun-and-games me to use typed array

* Add new tests for array utilities

* Update type of ivs in save-data.ts

* Update part-timer-encounter.test.ts

* Convert uses of StatusEffect[] to Uint8Array

* Update ssui to use uint8array for ivs

* Revert use of typed arrays

* Move `nil` to @types/common

* Make more arrays readonly

* fix: remnant change to immune effects

* Even more array improvements

* Apply kev's suggestions from code review

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* address Bertie's comments from code review

* tests: remove undefined check for bigint array types

* fixup abilities.ts

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-10-06 12:21:58 -05:00
Sirz Benjie
bbd5aefc81
fix: camel case liquid ooze 2025-10-06 11:36:46 -05:00
Dean
7ce2aa3ed9
[Bug] Liquid Ooze can now properly be suppressed (#5535)
* Fix applying even when suppressed

* Rewrite move/ability effects

* Fix using defender instead of attacker when applying magic guard

* Add test

* Unchange move effect phase

* Kev fixes

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* Fix liquid ooze test

* Fix hithealattr apply method

* Fix test

* Move checks to canApply

---------

Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-10-06 11:00:08 -05:00
Sirz Benjie
f4456f6c7c
[Dev] Improve typescript performance and version bump node and dependencies (#6627)
* Add caching for test matchers types to improve ts performance

* add skipLibCheck to tsconfig.json

* Bump package versions

* Move tm species map to its own file

* Turn on ts-nocheck in pokemon-level-moves

* Move initBiomes to own file

* Add types to methods in ME encounter phase utils

* Fix spacing

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-10-04 19:29:23 -05:00