[Misc] Remove now-obsolete noUselessStringConcat suppression comments

This commit is contained in:
NightKev 2025-11-29 21:01:26 -08:00
parent c12d9140fc
commit 03cc0b1af2
2 changed files with 40 additions and 14 deletions

View File

@ -5,7 +5,9 @@ module.exports = {
name: "no-non-type-@type-exports",
severity: "error",
comment:
"Files in @types should not export anything but types and interfaces. The folder is intended to house imports that are removed at runtime, and thus should not contain anything with a bearing on runtime code.",
"Files in `@types/` should not export anything but types and interfaces. "
+ "The folder is intended to house imports that are removed at runtime, "
+ "and thus should not contain anything with a bearing on runtime code.",
from: {},
to: {
path: "(^|/)src/@types",
@ -27,7 +29,8 @@ module.exports = {
name: "no-circular-at-runtime",
severity: "error",
comment:
"This dependency is part of a circular relationship. You might want to revise your solution (i.e. use dependency inversion, make sure the modules have a single responsibility) ",
"This dependency is part of a circular relationship. You might want to revise "
+ "your solution (i.e. use dependency inversion, make sure the modules have a single responsibility).",
from: {},
to: {
circular: true,
@ -39,7 +42,11 @@ module.exports = {
{
name: "no-orphans",
comment:
"This is an orphan module - it's likely not used (anymore?). Either use it or remove it. If it's logical this module is an orphan (i.e. it's a config file), add an exception for it in your dependency-cruiser configuration. By default this rule does not scrutinize dot-files (e.g. .eslintrc.js), TypeScript declaration files (.d.ts), tsconfig.json and some of the babel and webpack configs.",
"This is an orphan module - it's likely not used [anymore]. Either use it or "
+ "remove it. If it's logical this module is an orphan (i.e. it's a config file), "
+ "add an exception for it in your dependency-cruiser configuration. By default "
+ "this rule does not scrutinize dot-files (e.g. .eslintrc.js), TypeScript declaration "
+ "files (.d.ts), tsconfig.json and some of the babel and webpack configs.",
severity: "error",
from: {
orphan: true,
@ -56,7 +63,8 @@ module.exports = {
{
name: "no-deprecated-core",
comment:
"A module depends on a node core module that has been deprecated. Find an alternative - these are bound to exist - node doesn't deprecate lightly.",
"A module depends on a node core module that has been deprecated. "
+ "Find an alternative - these are bound to exist - node doesn't deprecate lightly.",
severity: "error",
from: {},
to: {
@ -88,7 +96,9 @@ module.exports = {
{
name: "not-to-deprecated",
comment:
"This module uses a (version of an) npm module that has been deprecated. Either upgrade to a later version of that module, or find an alternative. Deprecated modules are a security risk.",
"This module uses a (version of an) npm module that has been deprecated. "
+ "Either upgrade to a later version of that module, or find an alternative. "
+ "Deprecated modules are a security risk.",
severity: "error",
from: {},
to: {
@ -99,7 +109,10 @@ module.exports = {
name: "no-non-package-json",
severity: "error",
comment:
"This module depends on an npm package that isn't in the 'dependencies' section of your package.json. That's problematic as the package either (1) won't be available on live (2 - worse) will be available on live with an non-guaranteed version. Fix it by adding the package to the dependencies in your package.json.",
"This module depends on an npm package that isn't in the 'dependencies' section of your package.json. "
+ "That's problematic as the package either (1) won't be available on live (2 - worse) will be "
+ "available on live with an non-guaranteed version. Fix it by adding the package to the dependencies "
+ "in your package.json.",
from: {},
to: {
dependencyTypes: ["npm-no-pkg", "npm-unknown"],
@ -108,7 +121,8 @@ module.exports = {
{
name: "not-to-unresolvable",
comment:
"This module depends on a module that cannot be found ('resolved to disk'). If it's an npm module: add it to your package.json. In all other cases you likely already know what to do.",
"This module depends on a module that cannot be found ('resolved to disk'). "
+ "If it's an npm module: add it to your package.json. In all other cases you likely already know what to do.",
severity: "error",
from: {},
to: {
@ -118,7 +132,9 @@ module.exports = {
{
name: "no-duplicate-dep-types",
comment:
"Likely this module depends on an external ('npm') package that occurs more than once in your package.json i.e. bot as a devDependencies and in dependencies. This will cause maintenance problems later on.",
"Likely this module depends on an external ('npm') package that occurs more than once "
+ "in your package.json (i.e. both in `devDependencies` and in `dependencies`). "
+ "This will cause maintenance problems later on.",
severity: "error",
from: {},
to: {
@ -135,7 +151,9 @@ module.exports = {
{
name: "not-to-spec",
comment:
"This module depends on a spec (test) file. The sole responsibility of a spec file is to test code. If there's something in a spec that's of use to other modules, it doesn't have that single responsibility anymore. Factor it out into (e.g.) a separate utility/ helper or a mock.",
"This module depends on a spec (test) file. The sole responsibility of a spec file is to test code. "
+ "If there's something in a spec that's of use to other modules, it doesn't have that single "
+ "responsibility anymore. Factor it out into (e.g.) a separate utility/helper or a mock.",
severity: "error",
from: {},
to: {
@ -146,7 +164,11 @@ module.exports = {
name: "not-to-dev-dep",
severity: "error",
comment:
"This module depends on an npm package from the 'devDependencies' section of your package.json. It looks like something that ships to production, though. To prevent problems with npm packages that aren't there on production declare it (only!) in the 'dependencies'section of your package.json. If this module is development only - add it to the from.pathNot re of the not-to-dev-dep rule in the dependency-cruiser configuration",
"This module depends on an npm package from the 'devDependencies' section of your "
+ "package.json. It looks like something that ships to production, though. To prevent problems "
+ "with npm packages that aren't there on production declare it (only!) in the 'dependencies'"
+ "section of your package.json. If this module is development only - add it to the "
+ "from.pathNot re of the not-to-dev-dep rule in the dependency-cruiser configuration",
from: {
path: "^(src)",
pathNot: ["[.](?:spec|test|setup|script)[.](?:js|mjs|cjs|jsx|ts|mts|cts|tsx)$", "./test"],
@ -163,7 +185,10 @@ module.exports = {
name: "optional-deps-used",
severity: "info",
comment:
"This module depends on an npm package that is declared as an optional dependency in your package.json. As this makes sense in limited situations only, it's flagged here. If you're using an optional dependency here by design - add an exception to yourdependency-cruiser configuration.",
"This module depends on an npm package that is declared as an optional dependency "
+ "in your package.json. As this makes sense in limited situations only, it's flagged here. "
+ "If you're using an optional dependency here by design - add an exception to your"
+ "dependency-cruiser configuration.",
from: {},
to: {
dependencyTypes: ["npm-optional"],
@ -172,7 +197,10 @@ module.exports = {
{
name: "peer-deps-used",
comment:
"This module depends on an npm package that is declared as a peer dependency in your package.json. This makes sense if your package is e.g. a plugin, but in other cases - maybe not so much. If the use of a peer dependency is intentional add an exception to your dependency-cruiser configuration.",
"This module depends on an npm package that is declared as a peer dependency "
+ "in your package.json. This makes sense if your package is e.g. a plugin, but in "
+ "other cases - maybe not so much. If the use of a peer dependency is intentional "
+ "add an exception to your dependency-cruiser configuration.",
severity: "error",
from: {},
to: {

View File

@ -67,7 +67,6 @@ export class MoveHelper extends GameManagerHelper {
const movePosition = this.getMovePosition(pkmIndex, move);
if (movePosition === -1) {
expect.fail(
// biome-ignore lint/complexity/noUselessStringConcat: Biome does not currently detect this as multiline (BUG)
`MoveHelper.select called with move '${toTitleCase(MoveId[move])}' not in moveset!`
+ `\nBattler Index: ${toTitleCase(BattlerIndex[pkmIndex])}`
+ `\nMoveset: [${this.game.scene
@ -112,7 +111,6 @@ export class MoveHelper extends GameManagerHelper {
const movePosition = this.getMovePosition(pkmIndex, move);
if (movePosition === -1) {
expect.fail(
// biome-ignore lint/complexity/noUselessStringConcat: Biome does not currently detect this as multiline (BUG)
`MoveHelper.selectWithTera called with move '${toTitleCase(MoveId[move])}' not in moveset!`
+ `\nBattler Index: ${toTitleCase(BattlerIndex[pkmIndex])}`
+ `\nMoveset: [${this.game.scene