Sirz Benjie
f6185daaae
Apply kev's suggestions from code review
...
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-07-30 12:48:45 -04:00
NightKev
2b09ca9159
Fix imports
2025-07-30 12:48:44 -04:00
Sirz Benjie
c9e7fd04c0
Update with Bertie's comments
...
Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>
2025-07-30 12:48:43 -04:00
Sirz Benjie
cd2e73cb28
Explicitly check against Moves.NONE
...
Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>
2025-07-30 12:48:42 -04:00
Sirz Benjie
4a87e06090
Improve canUse
computation
2025-07-30 12:48:41 -04:00
Sirz Benjie
c4a697d8ce
Fix improperly named computeMoveId method
2025-07-30 12:48:40 -04:00
Sirz Benjie
5616e3d4f3
Add overload for handle command
2025-07-30 12:48:38 -04:00
Sirz Benjie
ea803195ed
Minor touchups
2025-07-30 12:48:37 -04:00
Sirz Benjie
1fcaf55047
Breakup commandPhase#start
...
Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>
2025-07-30 12:48:35 -04:00
Sirz Benjie
29232074c7
Breakup run and pokemon commands
2025-07-30 12:48:34 -04:00
Sirz Benjie
aab9a698fc
breakup fight and ball commands into their own methods
2025-07-30 12:48:33 -04:00
NightKev
0ceafe9cfe
[Dev] Change target
to ES2023
in tsconfig.json
( #6160 )
2025-07-30 12:48:31 -04:00
Bertie690
d75836d720
[Bug] Fix camel case bug in strings.ts
( #6161 )
2025-07-30 12:48:30 -04:00
NightKev
7842bf435f
[Docs] Add @module
modifier tag to tsdoc.json
2025-07-30 12:48:29 -04:00
Sirz Benjie
23cd816e32
[Refactor] Prevent serialization of full species in pokemon summon data
...
https://github.com/pagefaultgames/pokerogue/pull/6145
* Prevent serialization of entire species form in pokemon summon data
* Apply suggestions from code review
Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Apply Kev's suggestions from code review
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
---------
Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-07-30 12:48:28 -04:00
Bertie690
bc8d4947ba
[Misc] Moved + cleaned up string manipulation functions ( #6112 )
...
* Added string utility package to replace util functions
* Changed string manipulation functions fully over to `change-case`
* Fixed missing comma in package.json
trailing commas when :(
* fixed lockfile
* Hopefully re-added all the string utils
* fixed package json
* Fixed remaining cases of regex + code dupliation
* Fixed more bugs and errors
* Moved around functions and hopefully fixed the regex issues
* Minor renaming
* Fixed incorrect casing on setting strings
pascal snake case 💀
* ran biome
2025-07-30 12:48:28 -04:00
Bertie690
379bd51ed3
[Dev] Turned on checkJs
in TSConfig; fixed script type errors ( #6115 )
2025-07-30 12:48:27 -04:00
NightKev
dc5ad54506
[Misc] Fix import in vitest.d.ts
2025-07-30 12:48:26 -04:00
Bertie690
dc8cce53c8
[Test] Added custom equality matchers ( #6157 )
...
* Added rudimentary test matchers for `toEqualArrayUnsorted` and `toHaveTypes`
Might port the rest at a later date
* Actually run the effing setup matchers file + fixed ls lint to not be angy
* added dev dep
* Update .ls-lint.yml
* Update .ls-lint.yml
---------
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
Co-authored-by: Amani H. <109637146+xsn34kzx@users.noreply.github.com>
2025-07-30 12:48:25 -04:00
Sirz Benjie
3de9a49580
[Refactor] Refactor UI text ts ( #5946 )
...
* Add destroy method to pokemon-sprite-sparkle-handler
* Move TextStyle to enums, convert into const object
* Cleanup text.ts file
* Add necessary explicit types for TextStyle let vars
* Fix locales submodule commit
* Fix merge issue
---------
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-07-30 12:48:25 -04:00
Sirz Benjie
3c651e11b7
[Bug][Beta] Make bounce delay use fixed int ( #6156 )
...
Make bounce delay use fixed int
2025-07-30 12:48:24 -04:00
Sirz Benjie
9a89f48fd9
[Beta] [Bug] Fix shiny display issues ( #6154 )
...
Fix shininess check
2025-07-30 12:48:24 -04:00
damocleas
c622e26fd1
[i18n] Update Locales
2025-07-30 12:48:23 -04:00
NightKev
5a2c9d1712
[Dev] Add dist/
to ls-lint
ignore list
2025-07-30 12:48:22 -04:00
SmhMyHead
54d9740ae4
[UI/UX] Added "Hide Username" Setting ( #6105 )
...
* [UI/UX] Added "Hide Username" Setting
* Mask tid with asterisk instead of hiding completely
---------
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
2025-07-30 12:48:22 -04:00
Sirz Benjie
89cbf7a01a
[Refactor][Bug] Illusion no longer overwrites data of original Pokemon
...
https://github.com/pagefaultgames/pokerogue/pull/6140
2025-07-30 12:48:22 -04:00
Bertie690
6d7d2a5c6a
Added roost tests
2025-07-26 17:39:05 -04:00
Bertie690
3a255e59b5
Fxixed test
2025-07-26 15:02:13 -04:00
Bertie690
ea4fff4718
Merge remote-tracking branch 'upstream/beta' into heal-attr
2025-07-26 15:01:08 -04:00
Sirz Benjie
4f259e2c2f
[Misc] Fix import in decrypt-save.js ( #6149 )
2025-07-25 22:30:58 -07:00
Bertie690
bb46ba9f60
[Dev] Added typedoc deployments for Beta ( #6147 )
2025-07-25 21:58:15 -07:00
damocleas
556d588d67
[UI/UX] Replace 'Neutral' in the Arena Flyout with 'Field' ( #6139 )
...
Update arena-flyout.ts for Field > Neutral
2025-07-25 21:20:48 -04:00
Acelynn Zhang
2e3a7d47e0
[Bug] Fix Thrash continuing on caught Pokemon ( #6144 )
...
Fix Thrash continuing on caught Pokemon
2025-07-25 23:55:13 +00:00
Bertie690
ab394db9cf
[Refactor] Minor cleanup of initExpKeys
( #6127 )
2025-07-25 18:39:25 -05:00
NightKev
7b7edbb474
[Test] MoveHelper#changeMoveset
disables moveset overrides ( #5915 )
...
Also fix Assist tests and add `expect` for max moveset length
2025-07-25 16:22:52 -07:00
Sirz Benjie
ffa3d1cfe3
[UI/UX] [Bug] Fix ModifierSelectPhase
animation delay ( #6121 )
...
* Rework promise handling to ensure no races
* Add delay to ensure pokeball opening animation can be seen
* Remove leftover debug statements.
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Add tween bouncing pokeball to tweens that must complete for promise to resolve
* Fix typo in tsdoc
Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>
---------
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>
2025-07-25 20:36:21 +00:00
Acelynn Zhang
fc128a2f4c
[Bug] Fix when variable move power is called ( #6126 )
...
* Apply variable power attribute before type boost
* Update test/abilities/normal-move-type-change.test.ts
Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>
* Minor test improvements
---------
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-07-24 23:16:23 -07:00
Madmadness65
99545cf3c7
[Misc] Sinistea and Poltchageist line alt forms now available ( #4989 )
...
* Sinistea and Poltchageist line alt forms now available
* Unmark Poltchageist line as unobtainable, fix sprite key of alt forms
* Correct forms not being marked as starter selectable
* Reduce wild chance for Antique/Masterpiece forms
Instead of being 1/2 chance to get the Antique or Masterpiece forms, it is now only a 1/16 chance to get them.
---------
Co-authored-by: damocleas <damocleas25@gmail.com>
2025-07-25 01:45:09 +00:00
Bertie690
6ad11015f7
[Dev] Remove sanitizeOverrides
, consolidate initialization code into 1 file
...
https://github.com/pagefaultgames/pokerogue/pull/6134
* Removed `sanitizeOverrides`
* Moved initialization code to its own file
* Hopefully fixed test contamination
* Actually listened to people now
* fixed the thingy
* Run stub setup on init because
* Update testFileInitialization.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
---------
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-07-25 01:23:13 +00:00
Acelynn Zhang
6211fbd471
[Bug] Unblock priority spread under Psychic Terrain ( #6136 )
...
Unblock priority spread under Psychic Terrain
Co-authored-by: Acelynn Zhang <acelynnzhang@Acelynns-MacBook-Pro.local>
2025-07-25 01:05:14 +00:00
Bertie690
3940abbeaf
[Dev] test:silent now passes --silent='passed-only' to Vitest ( #6131 )
...
* [Dev] test:silent now passes --silent='passed-only' to Vitest
* Update test shard to actually use `test-silent`
* Removed obselete `project` flag
2025-07-24 17:56:11 -07:00
Sirz Benjie
51d4c33de0
[Misc] Standardize-file-names ( #6137 )
...
* Standardize filenames to kebab-case
Co-authored-by: pymilkmaiden <cassiopeiamahler56@gmail.com>
* Move script outside of public folder
* Move update_exp_sprites to scripts
* Add ls-lint to lint file and directory names
* Update lefthook.yml to skip merge / rebase on all pre-commit commands
---------
Co-authored-by: pymilkmaiden <cassiopeiamahler56@gmail.com>
2025-07-24 16:38:31 -04:00
Lugiad
58876a2086
[UI/UX] [Localization] Apply single-column Game Stats to more languages ( #6135 )
...
Apply sigle-column Game Stats to more languages
2025-07-24 11:48:52 -04:00
Sirz Benjie
ef843debee
[UI/UX] Allow adjustable column count in stats-ui-handler
...
https://github.com/pagefaultgames/pokerogue/pull/6087
* Make column count modular
Co-authored by: ShinigamiHolo <128856544+ShinigamiHolo@users.noreply.github.com>
* Make game stats ui handler use phaser method chaining
* Adjust max cursor calculation
* Make arrowUp start invisible
* Add implementations for setFlip methods in MockSprite
* Misc cleanup
* Address kev's review comments
* Address kev's review comments
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* improve clarity of doc comment
Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>
---------
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>
2025-07-23 23:06:17 -04:00
Bertie690
06290774c2
Fixed import issues i think
2025-07-23 22:57:47 -04:00
Bertie690
6ee2f89182
Merge remote-tracking branch 'upstream/beta' into heal-attr
2025-07-23 22:33:10 -04:00
Lugiad
adee68a6d5
[UI/UX] Optimized Pokémon PNGs ( #6130 )
...
Optimized Pokémon PNGs
2025-07-23 11:16:09 -07:00
Sirz Benjie
b1e1a383fb
[Bug] Appropriately load delayed attack when target index was player
...
https://github.com/pagefaultgames/pokerogue/pull/6128
2025-07-22 16:10:43 -07:00
Sirz Benjie
069e8a47d6
[Bug][Refactor] Fix loading arena tags ( #6110 )
...
* Improve type safety; add missing loadTag overrides to wish and neutralizing gas
* More automatic type safety for arena tags
* Fixup wording of lead comment in arena-tag.ts
* Apply kev's suggestions from code review
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Allow abstract constructors for arena methods
* Address dean's comments from code review
* Add missing newline after interface definition
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Apply suggestions from code review
Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>
* Apply suggestions from code review
Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>
* Format with biome
* Update tsdoc of ConditionalProtectTag
Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>
* Apply kev's suggestions from code review
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
---------
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>
2025-07-22 11:26:27 -07:00
Bertie690
6937effa16
[Misc/Docs] Assorted code cleanups + doc updates ( #5745 )
...
* Squashed changes into 1 commit, reverted unneeded stuff
* Update ability-class.ts comments
* Update move.ts comments
* Fixed flaky test
* Applied PR reviews
* Update move.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Fixed ab code
* Added comment for BattlerIndex
* ddd
* ren biome
* Update battler-tags.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Update battler-tags.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Update pokemon.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Update pokemon.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Update pokemon.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Fixed the things
* Fixed up a few `default` stuff and random enum stuff
* Update move.ts comments
* Revert change to pokemon.ts
* Update battle-scene.ts
* fixed import oopsie
* Update src/field/pokemon.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Update src/data/abilities/ability.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Update src/data/abilities/ability.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Fix incorrect TSDoc
* Update ability.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
---------
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-07-22 10:28:10 -07:00