Commit Graph

4761 Commits

Author SHA1 Message Date
Dean
39b4d74e95
[Bug] Fix #5029 Memory leak when saving and exiting (#5128)
* Add destroy function to ui handlers

* Implement destroy() for StarterSelectUiHandler

* Update battlescene to free memory when resetting

* Document destroy for starter select

---------

Co-authored-by: damocleas <damocleas25@gmail.com>
2025-01-15 02:06:09 -07:00
AJ Fontaine
e2c6bec418
[Bug] Fix Poltergeist message displaying before move use (#5040) 2025-01-15 00:53:16 -08:00
Wlowscha
d2a3e4bb2d
[UI/UX] Looping cursor in save slot selection screen (#5109)
* Save slot selection allows looping

* Removed debug logs

---------

Co-authored-by: damocleas <damocleas25@gmail.com>
2025-01-15 00:23:38 -07:00
Wlowscha
7ae216f0d6
[UI/UX] Shop cursor freedom (#5110)
* Allowing cursor in shop to cycle horizontally

* Improved cycling of commands

---------

Co-authored-by: damocleas <damocleas25@gmail.com>
2025-01-14 23:18:24 -07:00
damocleas
d5f84cf3df
Change Archen HA from Emergency Exit to Wimp Out (#5124) 2025-01-14 19:07:09 -07:00
Amani H.
6681a913fe
[Bug] Prevent Duplicate Signature Species in Trainer Battles (#5059)
* [Bug] Prevent Duplicate Signature Species in Trainer Battles

* Apply Kev's Suggestion

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: damocleas <damocleas25@gmail.com>
2025-01-14 18:25:18 -07:00
schmidtc1
001b61c1c7
[Bug][Move] Refactor moves that call a random move (#3380)
* Combine moveset from allies and uses it to get a move

* Clearer implementation of combining user and teammates' moves

* Refactor assist and sleep talk to use metronome's attribute for calling a move

* Refactor move filtering in RandomMovesetMoveAttr, creates arrays with invalid moves for assist/sleep talk

* Refactor RandomMoveAttr to set moveId in condition, places reused code in callMove in RandomMoveAttr

* Correct invalid move lists, adds Max/Z moves to metronome's list

* Remove ignoresVirtual from beta merge

* Remove Max/Z moves per frutescens' comment

* Fix bug with metronome/copycat/assist/sleep talk targeting ally

* Experimental async/await to be tested

* Refactor other attributes to extend CallMoveAttr

* Replace QueuedMove with TurnMove, refactor to attempt two-turn move fix for metronome

* Fix Swallow test due to TurnMove refactor

* Further fixes for TurnMove refactor

* Fix metronome two turn moves for enemy pokemon

* Replace nested ternary with if-else block per DayKev's comment

* Minor fixes

* Adjust command phase args handling

* Create metronome test, refactor RandomMoveAttr for easier testing

* Add unit test for recharge moves

* Refactor Copycat and Mirror Move, adjust move targeting

* Add unit test for ally targeting with Aromatic Mist

* Add tests for secondary effects and recharge moves for metronome

* Add test for Roar, remove test for Acupressure

* Create test for Assist

* Add test for assist failing

* Add sleep talk unit test coverage

* Adjust move-phase to better track last move for copycat, write and update unit tests for assist/copycat

* Create moveHistory in Battle to track all moves used, adjust mirror move to use this, writes unit tests

* Correct mirror move implementation, rewrite unit test to adjust

* Add docs to attrs, update assist to only grab allies sets

* Update assist unit test to match expected functionality

* Update metronome unit test to use getMoveOverride

* Update copycat unit test to use metronome getMoveOverride mock

* Fix phase interception

* Add docs from missed conversations

* Update assist tests to use manual moveset overrides

Minor fixes to other tests

* Remove `export` from `CallMoveAttr`

* Add missing `.unimplemented()` to some Max- and Z-Moves

---------

Co-authored-by: Tempoanon <163687446+Tempo-anon@users.noreply.github.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-01-14 15:26:35 -08:00
Jimmybald1
f1e500400a
[Balance][Bug] Fix off by one error in Generate random biome and Daily Mode now has its own function (#5121)
* [Balance] Allow Island and Laboratory in Generate Random Biome

* [Bug] Fix off by one error in Generate Random Biome

* [Balance] Daily Mode now has its own Generate Random Starting Biome

* [Misc] Filtering out Town and End specifically instead of assuming enum value stays consistent forever

---------

Co-authored-by: Jimmybald1 <147992650+IBBCalc@users.noreply.github.com>
2025-01-14 15:45:11 -07:00
NightKev
3a3ebfb783
[Balance] Multi-hit moves now use gen 5+ behavior (#5117) 2025-01-12 15:39:06 -08:00
NightKev
0107b1d47e
[Refactor] Create global scene variable (#4766)
* Replace various `scene` pass-arounds with global scene variable

* Modify tests

* Add scene back to `fade[in|out]()` calls

Co-authored-by: Moka <54149968+MokaStitcher@users.noreply.github.com>

* Fix Bug Superfan ME test

Co-authored-by: Moka <54149968+MokaStitcher@users.noreply.github.com>

* Re-enable fixed test

Co-authored-by: Moka <54149968+MokaStitcher@users.noreply.github.com>

* Rename `gScene` to `globalScene`

* Move `globalScene` to its own file to fix import/async issues

* Fix `SelectModifierPhase` tests

* Fix ME tests by removing `scene` from `expect()`s

* Resolve merge issues

* Remove tsdocs referencing `scene` params

Remove missed instances of `.scene`

* Remove unnecessary `globalScene` usage in `loading-scene.ts`

* Fix merge conflicts

* Attempt to fix circular import issue

* Found the source of the import issue

* Fix merge issues

---------

Co-authored-by: Moka <54149968+MokaStitcher@users.noreply.github.com>
2025-01-12 15:33:05 -08:00
Madmadness65
f83ab00ce4 Add missing 'unused' comment before Max Moves 2025-01-12 13:34:21 -06:00
Ori shalhon
d3fafa2770
[UI/UX] Add random selection option during starter select (#5075)
* Update submodule public/locales to the latest upstream commit

* feat: add random selection option during starter select

* move random selection behavior to seperate label

* Update public/locales submodule reference

* Remove debug console.log statement

* Update locales

* Update src/ui/starter-select-ui-handler.ts

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* Update src/ui/starter-select-ui-handler.ts

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* Update src/ui/starter-select-ui-handler.ts

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* Update locales submodule

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-01-10 20:10:52 -06:00
Amani H.
29087710b7
[Balance] Adjust Orb & Light Ball Weight Functions (#5070)
* [Balance] Adjust Orb & Light Ball Weight Functions

* Apply Kev's Suggestions

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: damocleas <damocleas25@gmail.com>
2025-01-10 19:34:16 -05:00
Zain
b0c347e20d
[Bug] Fixed defog not removing the target's Safeguard and Mist (#5107)
* Fixed defog not removing the target's Safeguard and Mist

* Made requested changes and added unit test

* Remove stray newline

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-01-10 18:29:25 -06:00
Wlowscha
47cb203068
Showing types on Pokémon page 2025-01-10 00:02:09 +01:00
Wlowscha
726b975f11
Handling uncaught pokemon 2025-01-09 23:53:07 +01:00
Wlowscha
215f9e8141
Pokemon name shown while in alt form is no more capitalized 2025-01-09 01:07:04 +01:00
Wlowscha
113d134b33
UI changes to make dex pages work in legacy style 2025-01-09 00:57:27 +01:00
Jimmybald1
d0db6a35d2
[Bug] fix #5102 Catching Charm now always max weight in Daily Mode (#5103)
Co-authored-by: Jimmybald1 <147992650+IBBCalc@users.noreply.github.com>
2025-01-08 20:27:23 +01:00
Wlowscha
a53195f174
Attempting to exit from filter text is now allowed if current option is empty 2025-01-08 00:17:29 +01:00
Wlowscha
c340b8be28
Removed candy upgrade instructions from evolved pokemon; attempting to buy candies from evolution now gives error sound instead of crashing the game 2025-01-07 22:30:03 +01:00
Wlowscha
f86ab7bd46
More cleanup 2025-01-07 22:28:25 +01:00
Wlowscha
cc3d518914
Adding some comments, removing useless elements 2025-01-07 21:44:06 +01:00
Unicornpowerstar
07b69c9485
[Sprite] Fix Issues with the 658-ash.json to display sprite correctly (#5055)
* [Sprite][Color] Fixing Issues with the 658-ash.json to display sprite correctly

- Fix colors not being shown correctly in the json.
   - Said fix are adding a new entry to separate the whites that are F8f8f8 by adding f4f4f4
   - Changed the wrong color into the correct one on the rare.

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-01-06 16:26:00 -08:00
NightKev
197b264fb0
[Bug] Gimmighoul & Eevee eggs will now properly randomize their forms (#5080) 2025-01-06 16:24:08 -08:00
Wlowscha
36b41fe566
Fix to pokemon number localization 2025-01-06 22:53:24 +01:00
Wlowscha
b5a3afdb91
Fix to pokemon number localization 2025-01-06 22:52:27 +01:00
Wlowscha
aac5e2f704
Localization of pokemon number label 2025-01-06 22:47:36 +01:00
Wlowscha
fb6454bbb6
Fixed bug with supportHover and skipped indices in option select ui handler 2025-01-06 22:41:35 +01:00
Wlowscha
125b8ba3df
Fixed bug of overlapping labels in text filters 2025-01-06 22:36:27 +01:00
Wlowscha
8d27907336
Passing a TextStyle to option select ui handler to allow for shadowed text 2025-01-06 22:35:51 +01:00
Wlowscha
41841ace1b
Fix to getStarterSpeciesId to work with all-unlocks files 2025-01-06 21:13:16 +01:00
Wlowscha
3597d34e44
Changing menu colors to textstyle options supporting a legacy version. 2025-01-06 18:40:04 +01:00
Wlowscha
8e9d7f97e0
Adding sound effects to menu, and pokemon cry when opening page 2025-01-06 17:34:42 +01:00
Wlowscha
e04a8f18f5
Showing proper descriptions for menu 2025-01-06 17:26:05 +01:00
Wlowscha
44b2cb6001
Better messages for evolution conditions 2025-01-06 16:34:13 +01:00
Wlowscha
d529bb78b2
Regional forms display name of region in evolutions and prevolutions 2025-01-06 16:24:32 +01:00
Wlowscha
c72296172d
Fixed bug in base stats overlay 2025-01-06 14:26:20 +01:00
Wlowscha
08b9a36cba
-Pokedex page showing biomes from prevolutions; displaying correct biomes for forms of Rotom, Burmy and Lycanroc 2025-01-06 14:16:20 +01:00
Wlowscha
cedc020e11
Working logic for select ui handler with skips and scroll 2025-01-06 12:53:49 +01:00
Wlowscha
c78ea78be5
Including evolutions when filtering by biome 2025-01-06 02:45:17 +01:00
Wlowscha
1d90bff5e5
Including baby forms among uncatchable mons 2025-01-06 02:29:59 +01:00
Wlowscha
82bccd4a2d
Displaying base stats as bars in an overlay 2025-01-06 02:21:48 +01:00
Wlowscha
717a2c38f7
Can buy candy upgrades through pokedex 2025-01-05 21:43:08 +01:00
Wlowscha
76fa8e2415
Changing background to make instructions visible 2025-01-05 21:07:27 +01:00
Wlowscha
0b53fde453
C and V buttons snap cursor to filters 2025-01-05 20:49:26 +01:00
Wlowscha
2b81bab116
Merge branch 'internal-pokedex' of https://github.com/Wlowscha/pokerogue into internal-pokedex 2025-01-05 12:41:27 +01:00
Wlowscha
ed826ad9b6
Biome filter option for uncatchable mons 2025-01-05 12:39:19 +01:00
Lugiad
d49837cd21
Merge branch 'beta' into internal-pokedex 2025-01-05 12:39:02 +01:00
Wlowscha
54d7ca8559
Added filter for starters / evolutions 2025-01-05 12:20:37 +01:00