Commit Graph

5004 Commits

Author SHA1 Message Date
Glorax
ea5ccc2385
Update biomes.ts 2025-04-12 19:40:56 -07:00
Glorax
bc6e3e71b9
Update biomes.ts 2025-04-12 19:19:33 -07:00
Glorax
b0986f5b39
Biome and Rarity Alterations
Changed the biomes of several legendary Pokémon in order to better distrubute them among the game's biomes. Mythical Pokémon that aren't already assigned to biomes have been given biomes.

List of Biome Changes: 
- Celebi: N/A -> Forest
   Reason: The guardian of Ilex Forest.
- Celesteela: Space -> Wasteland
   Reason: Resembles home dimension of Ultra Crater.
- Deoxys: N/A -> Space
   Reason: Deoxys used to be encountered in Space, until it was removed because Space had too many ultra rare encounters. If the Light Trio is moved to Island, that leaves only Deoxys and Rayquaza.
- Dialga: Wasteland -> Ancient Ruins
   Reason: Dialga is traditionally encountered at the Spear Pillar.
- Genesect: Factory -> Laboratory
   Reason: Genesect is a Pokémon altered by science, not by industry, so it has more to do with the Laboratory than the Factory.
- Jirachi: N/A -> Mountain
   Reason: Jirachi is said to be found in the mountains.
- Koraidon: Ancient Ruins -> Wasteland
   Reason: Swapped with Dialga. Koraidon has no particular association with Ruins in Scarlet and Violet, so this assignment is based on its Dragon typing.
- Lunala: Space (Night) -> Island (Night)
   Reason: Cosmog and its evolutions don't actually come from outer space, and their close ties to the Alola region justify moving Lunala there to make space for Deoxys.
- Manaphy: N/A -> Sea Bed
- Mew: N/A -> Jungle
   Reason: Mew was first discovered in the jungle.
- Miraidon: Laboratory -> Factory
   Reason: Moved so that Factory has an Ultra Rare boss encounter.
- Necrozma: Space -> Metropolis
   Reason: In the story of Sun and Moon, Necrozma was imprisoned in the alternate universe city of Ultra Megalopolis. Moving Necrozma to Metropolis gives Metropolis an Ultra Rare boss encounter.
- Palkia: Abyss -> Ancient Ruins
   Reason: Palkia is traditionally encountered at the Spear Pillar.
- Pecharunt: N/A -> Swamp
   Reason: For type reasons. Fills the gap left by Poipole/Naganadel.
- Phione: N/A -> Sea Bed
- Poipole/Naganadel: Swamp -> Metropolis
   Reason: Resembles home dimension of Ultra Megalopolis.
- Solgaleo: Space (Day) -> Island (Day)
   Reason: Cosmog and its evolutions don't actually come from outer space, and their close ties to the Alola region justify moving Solgaleo there to make space for Deoxys.
- Victini: N/A -> Island
   Reason: Victini is found on Liberty Garden Island in Black and White.
- Terapagos: Cave -> Fairy Cave
   Reason: Fills the encounter slot formerly occupied by Xerneas. Though Terapagos isn't Fairy type, Fairy Cave is somewhat reminiscient of the Area Zero Underdepths.
- Victini: N/A -> Island
   Reason: Victini is found on Liberty Garden Island in Black and White.
- Xerneas: Fairy Cave -> Meadow
   Reason: Moved so that Meadow has an Ultra Rare boss encounter. Also, Xerneas doesn't seem like it would be found in a cave.
- Zeraora: Power Plant -> Metropolis
- Zygarde: Laboratory -> Cave
   Reason: Zygarde is encountered in Terminus Cave in X and Y. Moved so that Mewtwo is the only Ultra Rare Laboratory boss encounter.

Other Changes:
- Rotom boss encounter rarities adjusted on a case-by-case basis.  Biomes with few super rare encounters (like Tall Grass) have been untouched, while those with many other super rare boss encounters (like Volcano) have had Rotom shifted to rare.
- Varoom/Revavroom added to Factory.
- Kleavor boss encounter rarity reduced to same level as Scizor.
- Leafeon and Glaceon given non-boss encounters to match other Eeveelutions.
- Chatot encounter rarity changed from super rare to rare (dawn/day).
2025-04-12 18:41:42 -07:00
Jimmybald1
f9ff4abfb0
[Bug] Fixed biome map options counting rng twice (#5648)
Fixed biome map options counting rng twice

Co-authored-by: Jimmybald1 <147992650+IBBCalc@users.noreply.github.com>
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
2025-04-12 14:56:04 +00:00
NightKev
6f56dce771
[Biome] Add and apply lint/style/noNamespaceImport (#5650)
* Add `lint/style/noNamespaceImport` Biome rule

* Apply Biome rule, add exception for `*.test.ts` files
2025-04-12 01:31:56 -04:00
Blitzy
81f424dc71
[Balance] Fix and Adjust TM Compatibility
Curse
Skill Swap
Aqua Tail
Zen Headbutt
Hidden Power
Tera Blast
2025-04-11 16:33:25 -04:00
NightKev
1a7442511c
[Bug] Fix Biome selection RNG (#5645) 2025-04-10 23:22:42 -07:00
Sirz Benjie
787feceb14
[Refactor] Refactor variant sprite code part 1 (#5592)
* Move exp to its own masterlist, simplify initVariantData

* Update test/sprites/pokemonSprite.test.ts

* Extract loadPokemonVariantAssets out of BattleScene

* move variant.ts and update pokemon.loadAssets

* Add fuzzy matching for applying variant recolors

* Move glsl shaders to their own files

* Remove extra variants from shader masterlist

Their exp sprites have since been removed.

Co-authored-by: Unicorn_Power <189861924+Unicornpowerstar@users.noreply.github.com>

* Make exp sprite keys a set instead of an array

* Remove outdated exp sprite jsons

Co-authored-by: Unicorn_Power <189861924+Unicornpowerstar@users.noreply.github.com>

---------

Co-authored-by: Unicorn_Power <189861924+Unicornpowerstar@users.noreply.github.com>
2025-04-09 10:43:05 -05:00
damocleas
b3a4c75c06
[Refactor] Delete stale pokemon objects at the end of a battle 2025-04-08 18:10:39 -04:00
NightKev
2c2a34cfaf
Merge branch 'beta' into refactor/delete-stale-pokemon-objects 2025-04-08 15:08:34 -07:00
Dean
31835e6d53
[Bug] Fix #4972 Status-Prevention Abilities do not Cure Status (#5406)
* Add PostSummonHealAbAttr and give it to appropriate abilities

* Add attr to insomnia

* Remove attr from leaf guard (it does not activate on gain with sun up)

* Add tests and remove attr from shields down

* Add PostSummonRemoveBattlerTag and give it to oblivious and own tempo

* Add tests for oblivious and own tempo

* Fix oblivious test sometimes failing

* Remove Comatose changes as it doesn't reapply

* Remove unused tagRemoved field

* Fix tests checking status instead of tag

* Fix attr comments

* Add PostSetStatusHealStatusAbAttr

* Add ResetStatusPhase

* Modify pokemon.resetStatus to use ResetStatusPhase

* Move post status effects to ObtainStatusEffectPhase

* Ensure status overriding (ie rest) works properly

* Add PostApplyBattlerTagRemoveTagAbAttr for own tempo and oblivious

* Guard removeTag call in PostApplyBattlerTagRemoveTagAbAttr

* Commenting

* Handle Mold Breaker case in MoveEndPhase

* Remove PostSummonHealStatusAbAttr from purifying salt

* Fix not passing overrideStatus to canSetStatus

* Apply suggestions from code review

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* Add isNullOrUndefined import

* Add canApply to new attrs

* Add followup argument back

* Remove guard around new MoveEndPhase

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-04-07 16:32:10 -07:00
NightKev
1171656d12 Update console message 2025-04-07 16:02:58 -07:00
NightKev
17a56cc6c1 Move try/catch inside for loop
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
2025-04-07 15:58:17 -07:00
NightKev
cb5deb408f [Refactor] Delete stale pokemon objects at the end of a battle
Co-authored-by: Frutescens <info@laptop>
2025-04-07 15:58:17 -07:00
NightKev
1b79d1f832
[Refactor] Re-implement save migration system (#5634) 2025-04-07 22:53:35 +00:00
Diogo Cruz Diniz
0479b9dfcc
Fix #2735: Hazard moves incorrectly require targets (#5635)
* Fix #2735: Hazard moves incorrectly require targets
Hazard moves should no longer require targets to successfully execute

* Apply suggestions from code review made by NightKev

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-04-07 08:50:52 -05:00
NightKev
1e6ceb5581
[Misc] Clean up various phases (part 1) (#4797)
* Clean up various phases

Remove redundant code, utilize default parameters,
clean up some leftover `strict-null` `TODO`s,
replace `integer` with `number`

* Replace `* as Utils` imports with named imports

* Apply Biome
2025-04-06 03:10:52 +00:00
damocleas
fdf8c1a695
[Balance] Remove accuracy cap from Wide Lens 2025-04-05 01:45:10 -04:00
Sirz Benjie
46d234983c
Merge branch 'beta' into balance/remove-wide-lens-cap 2025-04-05 00:43:30 -05:00
Sirz Benjie
5318d717b3
[Refactor] [Docs] Minor refactor of move.checkFlags into move.doesFlagEffectApply (#5264)
* Refactor Move.checkFlags

* Improve jsdoc clarity

* Fix improper recursive call for the IGNORE_PROTECT check

* Fix improper placement of followUp check

* Get rid of unnecssary break

* Fix last import

* Remove latent checkFlag call in move-effect-phase

* Remedy perish body oversight

* Apply kev's suggestions from code review

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-04-05 00:43:46 +00:00
Sirz Benjie
9e4162d429
[Bug] Fix super luck implementation (#5625)
* Fix super luck implementation

* Use numberholder instead of booleanholder

* Update tsdoc for getCritStage
2025-04-04 17:40:25 -07:00
Sirz Benjie
420c2e37c2
[GitHub] Add path filters to avoid unnecessarily re-running tests (#5497)
* Add path filters to avoid unnecessarily re-running tests

* Apply suggestions from kev's review

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* Update .github/workflows/tests.yml

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* Don't ignore image files for tests

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-04-04 22:13:21 +00:00
Sirz Benjie
e31bf91223
[Bug][Ability] Fix mold breaker effect lingering if the user's move runs out of PP (#5265)
* Fix mold breaker pp bug

* Update Dancer test to account for changed phase behavior

* Update doc comment for move-phase's `end` method

* Add null handling for pokemon in `move-end` phase

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-04-04 23:57:39 +02:00
Sirz Benjie
b364bb1899
[Bug][Ability] Fix wimp out and emergency exit skipping waves in double battles (#5261)
Fix wimp out causing battles to skip
2025-04-04 14:39:53 -07:00
damocleas
68f10dc199
Merge branch 'main' into beta 2025-04-03 00:28:55 -04:00
NightKev
7b38596a12
Sync locales and update version to 1.8.4 (#5620) 2025-04-02 19:37:48 -07:00
damocleas
333975017f
Hotfixes 1.8.3 2025-04-02 20:37:45 -04:00
damocleas
d0703e0e0b
Merge branch 'main' into beta 2025-04-02 20:31:13 -04:00
Dean
4c8f81bb09
[Bug] Fix uses of getAlly() (#5618)
* Fix plus/minus crash

* Update getAlly() uses
2025-04-02 17:28:58 -07:00
Wlowscha
c6721521ab
[BUG] Fix broken forms of Pichu starter (#5616)
* Unlock base Pichu form when catching a Pikachu form

* Implementing migrator for broken Pichu forms
2025-04-02 19:59:31 -04:00
Wlowscha
db7ed43ad7
[Bug][UI/UX] Make sure forms and evolutions are counted in challenges again (#5617)
Making sure to actually count forms...
2025-04-02 19:42:36 -04:00
Unicorn_Power
a7394130a7
(Beta) Undoing the Pika-etern stuff (#5615) 2025-04-02 17:21:04 -04:00
damocleas
cf1616212c
Hotfixes 1.18.2 2025-04-02 03:05:51 -04:00
damocleas
7f4b37a36f
Merge branch 'main' into beta 2025-04-02 02:58:27 -04:00
Dean
2773354193
[Bug][Hotfix] Fix various ability flyouts not disappearing (#5614)
* Add hide phases for rogue ability showing

* Hide ability bar on game over

* Hide ability bar in TurnEndPhase
2025-04-02 02:56:19 -04:00
damocleas
951d8b633d
[Balance] Minor Passive Adjustments for 1.8.2 (#5613)
* Update passives.ts
2025-04-02 02:42:10 -04:00
damocleas
d92bf29030 [i18n] Update locales submodule and 1.8.2 bump 2025-04-02 00:25:05 -04:00
NightKev
70ba974348 [Balance] Remove accuracy cap from Wide Lens 2025-04-01 21:02:14 -07:00
Dean
5416c76ecb
[Bug][Hotfix] Fix crash when pulling trainer names for (certain) non-English languages (#5608)
* Fix key usage for trainer locales

* Update gts

* Fix partner name generation

---------

Co-authored-by: Wlowscha <54003515+Wlowscha@users.noreply.github.com>
2025-04-01 21:31:52 -04:00
Amani H.
4a4e766135
[Bug] Prevent Mystical Rock after Max Stack (#5606)
* [Bug] Prevent `Mystical Rock` after Max Stack

* Update modifier-type.ts

* fixed ordering, testing locally

---------

Co-authored-by: damocleas <damocleas25@gmail.com>
2025-04-01 17:18:49 -04:00
Jimmybald1
5217703d2b
[Bug] Mystical Rock modifier missing Drought check 2025-04-01 20:18:10 +00:00
Dean
1229bfe004
[Bug][Hotfix] Fix Parental bond + Pollen Puff softlock (#5607)
* Fix parental bond softlock

* Add test for pollen puff

---------

Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
2025-04-01 12:10:59 -07:00
damocleas
7d6b375f6f
Hotfixes 1.8.1
- Fix Flower Gift / Forecast flyout - P3
- Fix Sinistcha/Poltchageist Crash in the Pokedex - P1
- Undid a dependency update, fixing Mobile fullscreen and the opponent status UI being misaligned
- Hopefully update locales properly this time
2025-04-01 02:55:04 -04:00
Sirz Benjie
6477be99f5
[Misc] Rollback phaser update (package-lock.json) (#5603)
Update package-lock.json
2025-04-01 01:34:47 -05:00
damocleas
13b118454c Update package-lock.json 2025-04-01 01:27:42 -04:00
Sirz Benjie
a975192cf4
[Misc] Rollback Phaser Update 2025-04-01 04:54:48 +00:00
damocleas
6538eddf91
[Bug][Hotfix] Mark Sinistcha/Poltchageist forms as unselectable/unobtainable 2025-04-01 00:05:24 -04:00
damocleas
318b0c25d8
Merge branch 'beta' into sinis 2025-04-01 00:03:10 -04:00
damocleas
fd40bb50e9 Update beta to 1.8.1 2025-03-31 22:54:15 -04:00
Dean
95194ce8f1 Mark Sinistcha/Poltchageist forms as unselectable/unobtainable 2025-03-31 18:20:49 -07:00