Commit Graph

96 Commits

Author SHA1 Message Date
Bertie690
f70207b2b7
[GitHub] Improved linting workflow to show intermediate step status
https://github.com/pagefaultgames/pokerogue/pull/6657

* Added `workflow_dispatch` trigger to linting workflow

* fixed using `always` instead of `!cancelled`
2025-10-15 18:24:03 -07:00
NightKev
f482e8d3d7 [Dev] Add NODE_ENV = beta to beta deploy workflow
Hopefully this will force it to actually build in beta mode
2025-10-05 06:45:02 -07:00
NightKev
f7fd72b08c
[Dev] Don't use "production" mode for beta server (#6616)
* [Dev] Don't use "production" mode for beta server

* Fix `build` command in `package.json`
2025-10-05 06:33:57 -07:00
Sirz Benjie
c695df777c
[Refactor][Dev] Move public to its own submodule (#6590)
* Remove public folder to prepare for submodule

* Add submodule and update licensing

* Stop serving non-asset files during build

* Update pull request template

* Update CODEOWNERS

* Add locales submodule

* Update pull request template regarding locales

* remove post-checkout lefthook in favor of git config

* chore: add license info to new script

* Update gh pages workflow

* Apply kev's suggestions from code review

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* update assets
2025-09-27 11:01:12 -05:00
Sirz Benjie
6766940fa1
[Misc] Make the repo REUSE compliant (#6474)
* Add license information

* Add reuse lint workflow

* Add snippets for spdx

* fix: minor wording adjustments and typo fixes

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* chore: add FileContributor attributions for Bertie

Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>

* begin licensing some audio assets

* Add pokemon reborn sound affect attribution

* Annotate Leavannite's section

* Add more licensing info

* Add license info to license files ._.

* Move ps1 files out of public

* Add license for animation jsons

* Add license for bat scripts in public

* Update licensing in scripts

* Fix typo in license ref

* Fix AGPL-3.0-or-later

* Add license info to typedoc.config.js

* Add MIT license for snippets

* chore: update license info for files in scripts

* chore: update license info

* chore: update license info

* chore: update license info

* Remove licenses used only by public before linting with reuse

* Add license info to new files added by docker PR

* chore: apply biome

* fix: add back linting workflow lost during merge

* Add attribution based on Hanniel's information

* Add attribution based on Officer Porkchop and Green Ninja's information

* add attribution to unicorn_power for reshiram/zekrom/kyurem epic variant

* Fixup minor typo

* Adjust sprite test to not think REUSE.toml is a sprite json

* Add missing continue-on-error to workflow

* fix: address kev's comments from code review

* docs: minor touchups

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>
2025-09-23 08:49:03 -05:00
Domagoj
65c72c65b9
[Dev] Add Podman support (#6150)
* Add Dockerfile

* Refactor for improved podman support

* Podman support + docs

* Update documentation for podman usage

* Update docs/podman.md with working podman run command

* Add package manager constraint to package.json and Dockerfile
Update podman.md docs

* Remove package manager constraints from github workflows per DayKev
Update podman.md docs with extra steps for locales and testing command
Remove missleading comment from Dockerfile

* Remove Dockerfile comment

* Re-add `pnpm` version to Github Pages workflow

* Mention podman in CONTRIBUTING.md
Fix typo in docs/podman.md test command

* Fix path to docs/podman.md

---------

Co-authored-by: Lugiad <adrien.grivel@hotmail.fr>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
2025-09-10 14:23:13 -05:00
Bertie690
e570c2eba5
[Dev] Stop creating dummy RELEASE file in release workflow (#6442)
* [Dev] Stop creating dummy RELEASE file in release workflow

* Delete RELEASE file

* Update .github/workflows/create-release.yml

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* Update `create-release.yml` step desc

* Update `create-release.yml` to use `pnpm version`
2025-09-10 14:17:01 -05:00
Sirz Benjie
d3462a1412
fix: get log.png 2025-09-10 11:42:38 -05:00
Sirz Benjie
965f3d0eef
[GitHub] Optimize workflow files (#6539)
* Use sparse checkout for paths-filter to only grab the test-filters file

* Tweak docs workflow to not download public directory

* stop downloading openssh and git
2025-09-10 11:39:36 -05:00
Bertie690
8b95361d61
[Dev] Added egg move parse script & script type checking (#6116)
* Added egg move parse utility script

* Update interactive.js

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* Update interactive.js

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* Update interactive.js

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* Applied kev's reviews

* Removed `basePath` from tsconfig

the docs literally recommend against using it so yeah

* Fixed up configs so that script folder has its own file

* Reverted changes to egg move contents

* renamed boilerplate so biome doesn't lint it

* Fix `jsconfig.json` so that it doesn't typecheck all of `node_modules`

See https://github.com/microsoft/TypeScript/issues/50862#issuecomment-1565175938 for more info

* Update tsconfig.json

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* Updated workflows and fixed issues

* Removed eslint from linting workflow

* Fixed type error in d.ts file to shut up linters

* Reverted test-filters.yml

* Update biome.jsonc

* Update decrypt-save.js comment

* Update interactive.js

* Apply Biome

* Fixed type errors for scripts

* Fixed biome from removing tsdoc linkcodes

* Update test/@types/vitest.d.ts

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-09-07 11:35:52 -07:00
Sirz Benjie
f29bfa31cd
[GitHub] [Docs] Use rsync in workflow run 2025-09-06 11:16:31 -05:00
Sirz Benjie
550f3b896e
[GitHub] [Docs] Copy entirety of docs folder 2025-09-06 10:58:03 -05:00
Bertie690
21aa40e46a
[GitHub] [Docs] Update github-pages.yml to add the files into the right subdirectory (#6500) 2025-09-06 10:39:09 -05:00
Bertie690
e94417940f
[Dev] Fix extra dot in github-pages.yml (#6494) 2025-09-05 22:14:38 -05:00
Bertie690
9ddd6fe026
[Dev] Fix GH pages workflow to push docs correctly (#6493) 2025-09-05 21:54:48 -05:00
NightKev
db8458fdb7
[GitHub] Fix Typedoc workflow (#6490)
* [GitHub] Fix Typedoc workflow

* Remove `--allow-empty`
2025-09-05 21:23:32 -05:00
Bertie690
850fa6f6de
[Dev] Added Typedoc plugins + README badges (#6400)
* Add copyright in footer

* Customized typedoc configuration + added coverage SVG

* Finally figured out how to slap the SVG onto the docs' readme per branch

* Fixed up config, made final tweaks to SVG length and renamed script

* Added missing closing bracket to type config declaration

* Fixed title + added GitHub navigation link

* Fixed name typo

* Update README.md

* Moved badges on same line
2025-09-05 11:34:22 -07:00
Bertie690
dcb2f32129
[Test] Made test workflow not stop when a shard fails (#6403) 2025-08-27 19:43:04 -07:00
NightKev
2afd4f57cb
[GitHub] Workflows will now time out after 10 minutes (#6441) 2025-08-27 08:39:26 +02:00
NightKev
8dea0ce840
[GitHub] Update pages workflow to only deploy on main and beta (#6386) 2025-08-23 20:28:42 -07:00
Sirz Benjie
a8b54eba6d
[Test] Mark failing test/ui/manage-item-button.test.ts as TODO (#6375)
* Ensure hotfix runs tests

* Unnest promise

* ensure workflows run when pushed to hotfix

* Mark test todo
2025-08-23 16:56:58 -05:00
NightKev
1df82565f2
[GitHub] Workflows will now run on release branch (#6329) 2025-08-21 14:49:41 -07:00
Sirz Benjie
8773a0faf9
Add token output to workflow (#6319) 2025-08-20 22:43:52 -05:00
Sirz Benjie
2664700eb1
[GitHub] Add token output to workflow (#6318)
Add token output to workflow
2025-08-20 22:40:24 -05:00
NightKev
79576ad117
[GitHub] Update .github/CODEOWNERS file (#6240)
* [GitHub] Update `.github/CODEOWNERS` file

`@pagefaultgames/senior-dev-team` added to
`package.json` and `pnpm-lock.yaml`

`@pagefaultgames/balance-team` added to `/src/data/trainers`

* Move senior dev team entries to the bottom of the file
2025-08-09 03:18:40 +00:00
Bertie690
c92b895946
[Dev] Add workflow-dispatch trigger to tests github workflow (#6152)
Add `workflow-dispatch` trigger to github workflow

Co-authored-by: damocleas <damocleas25@gmail.com>
2025-07-28 20:43:36 +02:00
Bertie690
bb46ba9f60
[Dev] Added typedoc deployments for Beta (#6147) 2025-07-25 21:58:15 -07:00
Bertie690
3940abbeaf
[Dev] test:silent now passes --silent='passed-only' to Vitest (#6131)
* [Dev] test:silent now passes --silent='passed-only' to Vitest

* Update test shard to actually use `test-silent`

* Removed obselete `project` flag
2025-07-24 17:56:11 -07:00
Sirz Benjie
51d4c33de0
[Misc] Standardize-file-names (#6137)
* Standardize filenames to kebab-case

Co-authored-by: pymilkmaiden <cassiopeiamahler56@gmail.com>

* Move script outside of public folder

* Move update_exp_sprites to scripts

* Add ls-lint to lint file and directory names

* Update lefthook.yml to skip merge / rebase on all pre-commit commands

---------

Co-authored-by: pymilkmaiden <cassiopeiamahler56@gmail.com>
2025-07-24 16:38:31 -04:00
NightKev
a6e4459ecd
[Dev] Fix if statement in beta deploy script (#6107) 2025-07-17 03:38:58 -07:00
NightKev
232f26a60d
[Dev] Migrate from npm to pnpm (#6018)
* Replace `package-lock.json` with `pnpm-lock.yaml`

* Update `package.json`

* Update `lefthook.yml`

* Update GitHub workflows

* Update references to `npm`/`npx`

* Update `CONTRIBUTING.md`

* Update `linting.md` and `comments.md`

* Update comment in `create-test.js`

* Add missing dependency `chalk` for `create-test.js`
2025-06-23 17:05:59 -07:00
NightKev
4fc77e4de9
[Dev] Update Biome to 2.0.0 (#6004)
* Run `npm audit fix`

* Update Biome to 2.0.0

* Migrate `biome.jsonc` to 2.0

* Apply Biome and fix some suppression comments

* Fix some suppression comments and update config

* More config updates

Added at "error": `noUnusedLabels`, `noThisInStatic`

Changed `useDefaultParameterLast` from "off" to "warn"

Changed `noDocumentCookie` (from recommended) from "warn" to "off"

Changed `noExcessiveCognitiveComplexity` from "warn" to "info"

* Add a bunch of rules

* Apply Biome safe fixes

* Apply Biome unsafe fixes

* Remove irrelevant `useSelfClosingElements` rule

* Upgrade already followed rules to "error"

* Remove unnecessary type cast

* Disable fixer for `useDefaultParameterLast`

* Disable `useJsonImportAttribute` rule and revert changes

* Fix `mockImage.ts`

* ...there's a `@ts-nocheck` in this file

* Use whole-file lint suppression comment in `version_converter.ts`

* Add a couple comments to `biome.jsonc`

* Remove ESLint packages and GitHub workflow
2025-06-20 23:24:11 -07:00
NightKev
f8d8a3de84
[Dev] Enable dependency cruiser workflow (#5966)
* Update `.dependency-cruiser.cjs` config file

* Update GitHub workflow

* Have `depcruise` check `test/` as well

* Remove circular import between `battle-anims.ts` and `battler-tags.ts`
2025-06-15 00:51:21 -07:00
Bertie690
a41de39d4f
[Misc] Run biome on all files; update some rules to be errors now
https://github.com/pagefaultgames/pokerogue/pull/5962/

* Fixed lint issue; ran biome on entire repository

* Fixed biome.jsonc

* Trimmed trailing whitespace... again...

* Fixed PR template md

* Fixed package json

* Fixed void return issues + ran biome again

* ran biome
2025-06-14 00:59:34 -07:00
Bertie690
d91a6ee11e
[Github] Update pull_request_template.md with more labels
https://github.com/pagefaultgames/pokerogue/pull/5974

* Update pull_request_template.md with more labels

More better

* Fix create test script name post refactor

Forgot to change it earlier
2025-06-14 01:38:54 +00:00
Sirz Benjie
e1be360e74
[GitHub] Change total shard numbers and change job name (#5905) 2025-05-30 14:42:12 -07:00
Sirz Benjie
5eeff18407
[GitHub] Fix gh action path filter (#5904)
* Fix test workflow syntax to use negation properly

* Add missing id and comparison check in tests.yml

* Fix missing curly brace
2025-05-30 12:35:38 -07:00
Sirz Benjie
9dedf7548b
[GitHub] Make tests skip if no filters are matched (#5744)
* Make tests skip if filters are matched

* Tweak filter path

* Make thing checkout thing

* Change where workflow is skipped

* Change where workflow is skipped

* Update github test filters

* Update test-filters.yml

---------

Co-authored-by: Wlowscha <54003515+Wlowscha@users.noreply.github.com>
2025-05-21 19:05:09 -05:00
Sirz Benjie
9283be652d
[GitHub] Create release action workflows (#5743)
* Create release actions

* Add release branch to push/pull events that invoke test workflows
2025-05-03 08:47:04 +00:00
Sirz Benjie
84a2ce979f
[GitHub] Update pull request template to say test:silent (#5733) 2025-04-29 19:48:06 -07:00
NightKev
efad0d1324
[GitHub] Use .nvmrc for pages workflow (#5666) 2025-04-15 20:55:29 -07:00
Sirz Benjie
8216a379bf
[Dev][GitHub] Update to node 22 (#5586)
* Update node and workflows to use version 22.14

* Update @types/node package

* Update engines field in package.json

* Hardcode node version in github pages workflow

* Update to checkout@v4 in github pages workflow
2025-04-14 12:37:26 -05:00
Sirz Benjie
420c2e37c2
[GitHub] Add path filters to avoid unnecessarily re-running tests (#5497)
* Add path filters to avoid unnecessarily re-running tests

* Apply suggestions from kev's review

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* Update .github/workflows/tests.yml

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* Don't ignore image files for tests

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-04-04 22:13:21 +00:00
Sirz Benjie
35e733e87a
[Test] [Refactor] [GitHub] Enable no isolate for vitest (#5566)
* Reuse global scene between tests

Co-authored-by: PigeonBar <56974298+PigeonBar@users.noreply.github.com>

* Add missing each method to mockContainer

* Fix select-modifier-phase test

* Sanitize overrides before tests

Co-authored-by: PigeonBar <56974298+PigeonBar@users.noreply.github.com>

* Sanitize overrides before tests

Co-authored-by: PigeonBar <56974298+PigeonBar@users.noreply.github.com>

* [WIP] fix things

* Fix tests not working with --no-isolate

* Update npm tests to use no isolate

* Update test-shard-template

* Update package.json

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

---------

Co-authored-by: PigeonBar <56974298+PigeonBar@users.noreply.github.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-03-28 17:30:38 -04:00
Sirz Benjie
7f226df8d6
[GitHub] Automatically add issue-type in issue templates (#5499) 2025-03-09 22:15:24 +00:00
Sirz Benjie
408b66f913
[Misc][Refactor][GitHub] Ditch eslint for biome, and add a formatter (#5495)
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-03-09 14:13:25 -07:00
Sirz Benjie
73afb35c4d
[GitHub] Update CODEOWNERS to fix team ownership (#5465) 2025-03-02 10:40:40 -08:00
NightKev
6eed6c24c2
[GitHub] Overhaul GitHub pull request template (#4895)
Co-authored-by: Adrian T. <68144167+torranx@users.noreply.github.com>
Co-authored-by: Moka <54149968+MokaStitcher@users.noreply.github.com>
2024-11-18 17:52:54 -08:00
NightKev
f9691b872b
Change deploy script to specify "main" instead of default_branch (#4557) 2024-10-06 05:47:34 +01:00
Frederico Santos
5e151f5604
[Refactor] External locales (#4529)
* Removed local translation files

added translations submodule

[Enhancement] Add post-merge command to update submodules in lefthook configuration

[Enhancement] Add postinstall script to install lefthook after package installation

[Enhancement] Update postinstall script to run post-merge command after lefthook installation

* Add subproject commit for locales directory

* Remove translation team assignments from CODEOWNERS

* Add recursive submodule checkout to workflow files and update README for translations

* fix: run without locales present (#4539)

some code was hard-wired with  locales having to be present. This is no longer the case now

---------

Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
2024-10-01 23:41:09 +01:00