damocleas
b41eee3c7f
Revert "[Refactor] Move many interfaces and enums to their own file" ( #5661 )
...
Revert "[Refactor] Move many interfaces and enums to their own file (#5646 )"
This reverts commit c82e01eed3
2025-04-14 12:28:36 -04:00
Sirz Benjie
c82e01eed3
[Refactor] Move many interfaces and enums to their own file ( #5646 )
...
* Move LearnMoveSituation to its own file
* Remove unused selfStatLowerMoves array
* Move all-moves to its own file
* Move TurnMove interface to its own file
* move AiType to its own file
* Move PokemonMove to its own file
* Move DamageCalculationResult interface to its own file
* Move fieldPosition to its own file
* Move hit-result to its own file
* Move DamageResult to its own file
* Move SpeciesWildEvolutionDelay to its own file
* move EvolutionItem to its own file
2025-04-14 08:31:26 -07:00
Lylian BALL
15e535a1a0
[Ability] Implement Illusion ( #3273 )
...
* implement illusion ability with unit test and localizations
* try removing whitespace change on unnecessary files
* nit corrections
* nit update src/field/pokemon.ts
Co-authored-by: Adrian T. <68144167+torranx@users.noreply.github.com>
* nit update src/phases.ts
Co-authored-by: Amani H. <109637146+xsn34kzx@users.noreply.github.com>
* illusion test correction
* unexpected error correction
* refactor property pokemon.illusion to pokemon.battleData.illusion
* nit
* nit
* update unit test up-to-date
* add docs
* merge up to date
* bugfix
* bugfix
* merge up to date
* refactor field illusion out of battleData
* fix nit
* fix nit
* Zoroark change illusion after lastPokemon update
* Zoroark change illusion after lastPokemon update
* refactor bug fix
* bugfix
* bug fix on tests
* Update src/field/pokemon.ts
Co-authored-by: innerthunder <168692175+innerthunder@users.noreply.github.com>
* use GetFailedText
* remove useless import
* add condition 'no illusion' into transform move
* wild Zoroark creates an illusion according to the current biome
* wild Zoroark creates an illusion according to the current biome
* delete console.log()
* add doc
* Update src/field/pokemon.ts
Co-authored-by: innerthunder <168692175+innerthunder@users.noreply.github.com>
* fix tests
* update locales submodule
* update Illusion interface
* bug fix
* bug fix
* bugfix
* rename some params for future implementations
* Zoroark keep illusion between battles
* Zoroark keep illusion between battles
* delete draft
* merge up-to-date
* bugfix
* merge
* merge
* implement canApplyPresummon method
* Update test/abilities/illusion.test.ts
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
* Update src/data/ability.ts
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
* Update src/data/ability.ts
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
* Update test/abilities/illusion.test.ts
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
* Update test/abilities/illusion.test.ts
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
* nit
* review corrections
* nit
* type hints affected by enemy illusion
* type hints affected by enemy illusionin fight-ui-handler
* nit
* rename some parameters back in useIllusion
* Update src/field/pokemon.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Update src/field/pokemon.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* refactor battleData.illusion as summonData.illusion and delete oncePerBattleClause
* add comments
* illusion will break before evolution
* Update src/field/pokemon.ts
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
* Update src/data/ability.ts
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
* Update src/data/ability.ts
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
* Update src/data/ability.ts
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
* Update src/data/ability.ts
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
* bug fix
* g
* get submodule back
* get submodule back
* bug fix to save illusion status
* add pokemon.getPokeball()
* Update src/field/pokemon.ts
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
* Update src/field/pokemon.ts
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
* Update src/field/pokemon.ts
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
* Update src/data/ability.ts
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
* Update src/field/pokemon.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Update src/field/pokemon.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Update src/field/pokemon.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Update src/field/pokemon.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
---------
Co-authored-by: Adrian T. <68144167+torranx@users.noreply.github.com>
Co-authored-by: Amani H. <109637146+xsn34kzx@users.noreply.github.com>
Co-authored-by: innerthunder <168692175+innerthunder@users.noreply.github.com>
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-04-12 21:22:04 -04:00
Jimmybald1
f9ff4abfb0
[Bug] Fixed biome map options counting rng twice ( #5648 )
...
Fixed biome map options counting rng twice
Co-authored-by: Jimmybald1 <147992650+IBBCalc@users.noreply.github.com>
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
2025-04-12 14:56:04 +00:00
NightKev
6f56dce771
[Biome] Add and apply lint/style/noNamespaceImport ( #5650 )
...
* Add `lint/style/noNamespaceImport` Biome rule
* Apply Biome rule, add exception for `*.test.ts` files
2025-04-12 01:31:56 -04:00
Blitzy
81f424dc71
[Balance] Fix and Adjust TM Compatibility
...
Curse
Skill Swap
Aqua Tail
Zen Headbutt
Hidden Power
Tera Blast
2025-04-11 16:33:25 -04:00
NightKev
1a7442511c
[Bug] Fix Biome selection RNG ( #5645 )
2025-04-10 23:22:42 -07:00
Sirz Benjie
787feceb14
[Refactor] Refactor variant sprite code part 1 ( #5592 )
...
* Move exp to its own masterlist, simplify initVariantData
* Update test/sprites/pokemonSprite.test.ts
* Extract loadPokemonVariantAssets out of BattleScene
* move variant.ts and update pokemon.loadAssets
* Add fuzzy matching for applying variant recolors
* Move glsl shaders to their own files
* Remove extra variants from shader masterlist
Their exp sprites have since been removed.
Co-authored-by: Unicorn_Power <189861924+Unicornpowerstar@users.noreply.github.com>
* Make exp sprite keys a set instead of an array
* Remove outdated exp sprite jsons
Co-authored-by: Unicorn_Power <189861924+Unicornpowerstar@users.noreply.github.com>
---------
Co-authored-by: Unicorn_Power <189861924+Unicornpowerstar@users.noreply.github.com>
2025-04-09 10:43:05 -05:00
NightKev
2c2a34cfaf
Merge branch 'beta' into refactor/delete-stale-pokemon-objects
2025-04-08 15:08:34 -07:00
Dean
31835e6d53
[Bug] Fix #4972 Status-Prevention Abilities do not Cure Status ( #5406 )
...
* Add PostSummonHealAbAttr and give it to appropriate abilities
* Add attr to insomnia
* Remove attr from leaf guard (it does not activate on gain with sun up)
* Add tests and remove attr from shields down
* Add PostSummonRemoveBattlerTag and give it to oblivious and own tempo
* Add tests for oblivious and own tempo
* Fix oblivious test sometimes failing
* Remove Comatose changes as it doesn't reapply
* Remove unused tagRemoved field
* Fix tests checking status instead of tag
* Fix attr comments
* Add PostSetStatusHealStatusAbAttr
* Add ResetStatusPhase
* Modify pokemon.resetStatus to use ResetStatusPhase
* Move post status effects to ObtainStatusEffectPhase
* Ensure status overriding (ie rest) works properly
* Add PostApplyBattlerTagRemoveTagAbAttr for own tempo and oblivious
* Guard removeTag call in PostApplyBattlerTagRemoveTagAbAttr
* Commenting
* Handle Mold Breaker case in MoveEndPhase
* Remove PostSummonHealStatusAbAttr from purifying salt
* Fix not passing overrideStatus to canSetStatus
* Apply suggestions from code review
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Add isNullOrUndefined import
* Add canApply to new attrs
* Add followup argument back
* Remove guard around new MoveEndPhase
---------
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-04-07 16:32:10 -07:00
NightKev
1171656d12
Update console message
2025-04-07 16:02:58 -07:00
NightKev
17a56cc6c1
Move try/catch inside for loop
...
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
2025-04-07 15:58:17 -07:00
NightKev
cb5deb408f
[Refactor] Delete stale pokemon objects at the end of a battle
...
Co-authored-by: Frutescens <info@laptop>
2025-04-07 15:58:17 -07:00
NightKev
1b79d1f832
[Refactor] Re-implement save migration system ( #5634 )
2025-04-07 22:53:35 +00:00
Diogo Cruz Diniz
0479b9dfcc
Fix #2735 : Hazard moves incorrectly require targets ( #5635 )
...
* Fix #2735 : Hazard moves incorrectly require targets
Hazard moves should no longer require targets to successfully execute
* Apply suggestions from code review made by NightKev
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
---------
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-04-07 08:50:52 -05:00
NightKev
1e6ceb5581
[Misc] Clean up various phases (part 1) ( #4797 )
...
* Clean up various phases
Remove redundant code, utilize default parameters,
clean up some leftover `strict-null` `TODO`s,
replace `integer` with `number`
* Replace `* as Utils` imports with named imports
* Apply Biome
2025-04-06 03:10:52 +00:00
Sirz Benjie
46d234983c
Merge branch 'beta' into balance/remove-wide-lens-cap
2025-04-05 00:43:30 -05:00
Sirz Benjie
5318d717b3
[Refactor] [Docs] Minor refactor of move.checkFlags into move.doesFlagEffectApply ( #5264 )
...
* Refactor Move.checkFlags
* Improve jsdoc clarity
* Fix improper recursive call for the IGNORE_PROTECT check
* Fix improper placement of followUp check
* Get rid of unnecssary break
* Fix last import
* Remove latent checkFlag call in move-effect-phase
* Remedy perish body oversight
* Apply kev's suggestions from code review
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
---------
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-04-05 00:43:46 +00:00
Sirz Benjie
9e4162d429
[Bug] Fix super luck implementation ( #5625 )
...
* Fix super luck implementation
* Use numberholder instead of booleanholder
* Update tsdoc for getCritStage
2025-04-04 17:40:25 -07:00
Sirz Benjie
e31bf91223
[Bug][Ability] Fix mold breaker effect lingering if the user's move runs out of PP ( #5265 )
...
* Fix mold breaker pp bug
* Update Dancer test to account for changed phase behavior
* Update doc comment for move-phase's `end` method
* Add null handling for pokemon in `move-end` phase
---------
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-04-04 23:57:39 +02:00
Sirz Benjie
b364bb1899
[Bug][Ability] Fix wimp out and emergency exit skipping waves in double battles ( #5261 )
...
Fix wimp out causing battles to skip
2025-04-04 14:39:53 -07:00
Dean
4c8f81bb09
[Bug] Fix uses of getAlly() ( #5618 )
...
* Fix plus/minus crash
* Update getAlly() uses
2025-04-02 17:28:58 -07:00
Wlowscha
c6721521ab
[BUG] Fix broken forms of Pichu starter ( #5616 )
...
* Unlock base Pichu form when catching a Pikachu form
* Implementing migrator for broken Pichu forms
2025-04-02 19:59:31 -04:00
Wlowscha
db7ed43ad7
[Bug][UI/UX] Make sure forms and evolutions are counted in challenges again ( #5617 )
...
Making sure to actually count forms...
2025-04-02 19:42:36 -04:00
Dean
2773354193
[Bug][Hotfix] Fix various ability flyouts not disappearing ( #5614 )
...
* Add hide phases for rogue ability showing
* Hide ability bar on game over
* Hide ability bar in TurnEndPhase
2025-04-02 02:56:19 -04:00
damocleas
951d8b633d
[Balance] Minor Passive Adjustments for 1.8.2 ( #5613 )
...
* Update passives.ts
2025-04-02 02:42:10 -04:00
NightKev
70ba974348
[Balance] Remove accuracy cap from Wide Lens
2025-04-01 21:02:14 -07:00
Dean
5416c76ecb
[Bug][Hotfix] Fix crash when pulling trainer names for (certain) non-English languages ( #5608 )
...
* Fix key usage for trainer locales
* Update gts
* Fix partner name generation
---------
Co-authored-by: Wlowscha <54003515+Wlowscha@users.noreply.github.com>
2025-04-01 21:31:52 -04:00
Amani H.
4a4e766135
[Bug] Prevent Mystical Rock after Max Stack ( #5606 )
...
* [Bug] Prevent `Mystical Rock` after Max Stack
* Update modifier-type.ts
* fixed ordering, testing locally
---------
Co-authored-by: damocleas <damocleas25@gmail.com>
2025-04-01 17:18:49 -04:00
Jimmybald1
5217703d2b
[Bug] Mystical Rock modifier missing Drought check
2025-04-01 20:18:10 +00:00
Dean
1229bfe004
[Bug][Hotfix] Fix Parental bond + Pollen Puff softlock ( #5607 )
...
* Fix parental bond softlock
* Add test for pollen puff
---------
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
2025-04-01 12:10:59 -07:00
Dean
95194ce8f1
Mark Sinistcha/Poltchageist forms as unselectable/unobtainable
2025-03-31 18:20:49 -07:00
Dean
136ea70a6e
[Bug][Hotfix] Fix Flower Gift/Forecast flyout ( #5599 )
...
Fix Flower Gift flyout
2025-03-31 20:01:30 -05:00
NightKev
efa3662099
[Misc] AFD Event ( #5596 )
...
* global timed event manager
* more
* Music change
* Add AFD track loop points
* Add AFD music tracks
* changed music for afd
* Enable Seasonal Splash Text, adjust event values
* Add daily run challenge support
* update event date, change trainer shiny chance to 20%
* add banners lol
* fix activeeventhasbanner function
* Fix banner
* Update locales submodule
---------
Co-authored-by: AJ Fontaine <fontbane@gmail.com>
Co-authored-by: damocleas <damocleas25@gmail.com>
Co-authored-by: Madmadness65 <59298170+Madmadness65@users.noreply.github.com>
Co-authored-by: Dean <me@deann.dev>
Co-authored-by: AJ Fontaine <36677462+Fontbane@users.noreply.github.com>
2025-03-31 15:11:01 -07:00
damocleas
6add614e1c
[Balance] Trash to Treasure and The Strong Stuff minor adjustments ( #5593 )
...
* Update trash-to-treasure-encounter.ts
* Update the-strong-stuff-encounter.ts
* add 'set' items to garbodor
* Update relevant tests
---------
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-03-31 12:34:16 -04:00
damocleas
7e4151f1ef
[Balance] Even more Split Passive fixes ( #5591 )
...
* Initial Split Passives
* Update split passives final v1
* Lock Battle Bond Froakie/Frogadier Ability, Gallade back to Inner Focus
* fix mispell
* remove unneeded ability on froakie and frogadier after testing
* fix some form passives
* Update passives.ts
* Update passives.ts
* Correct BB Froakie, G-Max changes for Flapple, Appletun, Toxtricity, Hatterene, Grimmsnarl, Alcremie
* Update egg-moves.ts
* Seviper now matches Zangoose's egg tier wow
* fix mispell
* Update passives.ts
* Update passives.ts
2025-03-31 01:19:58 -04:00
NightKev
51f765d67a
[Move] Add message for called moves failing due to no targets ( #5590 )
2025-03-31 00:00:59 -04:00
Lugiad
111390631d
[Localization] LATAM Spanish inclusion ( #5582 )
...
* Update i18n.ts
* Update settings.ts
* Update settings-display-ui-handler.ts
* Update starter-select-ui-handler.ts
* Update utils.ts
* Add files via upload
* Update i18n.ts
* Add files via upload
* Update loading-scene.ts
---------
Co-authored-by: Dean <69436131+emdeann@users.noreply.github.com>
2025-03-30 19:29:28 +00:00
damocleas
28234e577e
[Balance] Beta Passive Fixes, 1.8 Egg Move Changes, Egg Tier Change, and G-Max Form Re-Evaluation finished ( #5588 )
...
* Update passives.ts
* Correct BB Froakie, G-Max changes for Flapple, Appletun, Toxtricity, Hatterene, Grimmsnarl, Alcremie
* Update egg-moves.ts
* Seviper now matches Zangoose's egg tier wow
2025-03-30 06:21:12 +00:00
AJ Fontaine
d2ffc12d65
[Refactor] Remove game mode param from applyChallenges ( #5585 )
2025-03-30 06:18:18 +00:00
Wlowscha
05691970e2
[Bug] Fix pokedex option after catching ( #5574 )
...
* Fix pokedex entry after catching
* Allow turning pages
* Using isSeen in more places
* Evolutions show up as seen after catching
* Apply suggestions from code review
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Showing battle forms correctly for seen mons
---------
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-03-30 06:14:19 +00:00
Dean
b33d95d27d
[Bug][Refactor] Fix Unsuppressable Abilities being Unreplaceable ( #5547 )
...
* Switch unsuppressable to unswappable
* Update test
* Change suppress/replace/copy flags
* Make flower gift unreplaceable
* Make forecast unreplaceable
* No holding hands
* [Sprite] Reduce Mystical Rock sprite's size (#5570 )
* Updating the size to be smaller
* Update item atlas
* Fix Malicious Armor missing outline
Noticed when exporting atlas that the item sprite broke
---------
Co-authored-by: Madmadness65 <blaze.the.fireman@gmail.com>
Co-authored-by: damocleas <damocleas25@gmail.com>
* Switch unsuppressable to unswappable
* Update test
* Change suppress/replace/copy flags
* Make flower gift unreplaceable
* Make forecast unreplaceable
* No holding hands
* Apply suggestions from code review
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Remove trivial type annotations
---------
Co-authored-by: Unicorn_Power <189861924+Unicornpowerstar@users.noreply.github.com>
Co-authored-by: Madmadness65 <blaze.the.fireman@gmail.com>
Co-authored-by: damocleas <damocleas25@gmail.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-03-30 05:37:35 +00:00
Sirz Benjie
66bc83fce4
[Ability] Flower Veil implementation ( #5327 )
...
* [WIP] flower veil implementation
Signed-off-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
* Remove promises
Signed-off-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
* Fully implement Flower Veil
Signed-off-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
* Fix ally interaction for battler tag
* Condense and cleanup test files
* Remove a console.log message
* Remove stray excess import
* Update doc comments and apply kev's suggestions from code review
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Remove duplicated test
---------
Signed-off-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-03-29 21:32:35 -07:00
Sirz Benjie
451b1f6b08
[Misc] Update packages ( #5462 )
...
* Update via `npm audit fix --force`
* Update i18next family
* Update typescript family
* Update vite-tsconfig-paths
* Update jsdom to 26.0
Important! Security fixes, and performance/stability improvements.
* Update @stylistic/eslint-plugin-js to 4.1.0
* Update inquirer to 12.4.2
* Remove commented code and defunct import
* Run npm-audit fix
* Fix ts errors
* Update eslint family
* Update phaser family
* Update eslint plugin
* Update rest of imports
2025-03-29 22:13:50 -05:00
Blitzy
9c13fa5f80
[Balance] Evil Team Tweaks ( #5579 )
...
* Update evil-admin-trainer-pools.ts
* Update trainer-config.ts
* Fix Pokemon names
* Update / Fix Teams
* typo
* Rotom Revival Protocol (and Ponyta)
Accidentally removed Rotom from two different places
* unevolve the buddies
* Update evil-admin-trainer-pools.ts
---------
Co-authored-by: Madmadness65 <59298170+Madmadness65@users.noreply.github.com>
2025-03-30 03:02:27 +00:00
schmidtc1
27a1638243
[Bug] Fix interactions for Pollen Puff Parental Bond, Multi-Lens, Grip Claw Ally Healing ( #5550 )
...
* Checks for hit result status on Grip Claw application
* Adds a boolean check for the Pollen Puff edge case in canBeMultiStrikeEnhanced
* Adds parental bond test
* Adds grip claw and multi lens tests
2025-03-29 18:25:34 +00:00
damocleas
4f19e4a126
[Move] False Swipe/Hold Back don't fail if the target has 1 HP ( #5577 )
...
* Remove condition from `SurviveDamageAttr`
* Add test for False Swipe
---------
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: EmberCM <kooly213@hotmail.com>
2025-03-29 17:10:07 +00:00
NightKev
25b9fa7933
[Biome] Add "no unused imports" rule ( #5580 )
...
* Apply Biome to files
* Add `lint/correctness/noUnusedImports` rule
* Apply rule
* Remove obsolete eslint directives
* Fix variable naming in `game-speed.ts`
2025-03-29 10:24:23 +00:00
Dean
a727375730
[Bug] Fix Flash Fire has No Message ( #5578 )
...
Add flash fire message
2025-03-29 09:51:28 +01:00
Sirz Benjie
5f01caffae
[Refactor] Minor refactor of trainer-config files ( #5573 )
...
* Move trainer-config.ts
* move TeraAIMode enum to its own file
* Move TrainerPoolTier enum to its own file
* Move TrainerSlot enum to its own file
* Reorder and group imports
* Move TrainerPartyTemplate to its own file
* Remove speciesPoolPerEvilTeamAdmin method
* Apply kev's suggestions from code review
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Fix typo in zinzolin's name
---------
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-03-29 00:19:35 -04:00
