mika/pokerogue
1
0
Fork 0
mirror of https://github.com/pagefaultgames/pokerogue.git synced 2025-06-21 09:02:47 +02:00
Code Issues Packages Projects Releases Wiki Activity

corrected casing + dejanked seed tag

Browse Source
This commit is contained in:
Bertie690 2025-06-04 13:57:45 -04:00
parent 4dfcca1501
commit cc6a13cce3
2 changed files with 5 additions and 108 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/data/battler-tags.ts
View File

@ -1002,17 +1002,18 @@ export class SeedTag extends BattlerTag {
new CommonAnimPhase(source.getBattlerIndex(), pokemon.getBattlerIndex(), CommonAnim.LEECH_SEED), new CommonAnimPhase(source.getBattlerIndex(), pokemon.getBattlerIndex(), CommonAnim.LEECH_SEED),
); );
// Damage the target and restore our HP (or take damage in the case of liquid ooze)
const damage = pokemon.damageAndUpdate(toDmgValue(pokemon.getMaxHp() / 8), { result: HitResult.INDIRECT }); const damage = pokemon.damageAndUpdate(toDmgValue(pokemon.getMaxHp() / 8), { result: HitResult.INDIRECT });
const reverseDrain = pokemon.hasAbilityWithAttr(ReverseDrainAbAttr, false); const reverseDrain = pokemon.hasAbilityWithAttr(ReverseDrainAbAttr, false);
globalScene.unshiftPhase( globalScene.unshiftPhase(
new PokemonHealPhase( new PokemonHealPhase(
source.getBattlerIndex(), source.getBattlerIndex(),
!reverseDrain ? damage : damage * -1, reverseDrain ? -damage : damage,
!reverseDrain reverseDrain
? i18next.t("battlerTags:seededLapse", { ? i18next.t("battlerTags:seededLapseShed", {
pokemonNameWithAffix: getPokemonNameWithAffix(pokemon), pokemonNameWithAffix: getPokemonNameWithAffix(pokemon),
}) })
: i18next.t("battlerTags:seededLapseShed", { : i18next.t("battlerTags:seededLapse", {
pokemonNameWithAffix: getPokemonNameWithAffix(pokemon), pokemonNameWithAffix: getPokemonNameWithAffix(pokemon),
}), }),
false, false,

104
test/field/pokemon_id_checks.test.ts
View File

@ -1,104 +0,0 @@
import { allMoves } from "#app/data/moves/move";
import type Pokemon from "#app/field/pokemon";
import { BerryModifier } from "#app/modifier/modifier";
import { Abilities } from "#enums/abilities";
import { BattleType } from "#enums/battle-type";
import { BattlerTagType } from "#enums/battler-tag-type";
import { BerryType } from "#enums/berry-type";
import { Moves } from "#enums/moves";
import { Species } from "#enums/species";
import { Stat } from "#enums/stat";
import GameManager from "#test/testUtils/gameManager";
import Phaser from "phaser";
import { afterEach, beforeAll, beforeEach, describe, expect, it, vi } from "vitest";
describe("Field - Pokemon ID Checks", () => {
let phaserGame: Phaser.Game;
let game: GameManager;
beforeAll(() => {
phaserGame = new Phaser.Game({
type: Phaser.HEADLESS,
});
});
afterEach(() => {
game.phaseInterceptor.restoreOg();
});
beforeEach(() => {
game = new GameManager(phaserGame);
game.override
.moveset(Moves.SPLASH)
.ability(Abilities.NO_GUARD)
.battleStyle("single")
.disableCrits()
.enemyLevel(100)
.enemySpecies(Species.MAGIKARP)
.enemyAbility(Abilities.BALL_FETCH)
.enemyMoveset(Moves.SPLASH);
});
function onlyUnique<T>(array: T[]): T[] {
return [...new Set<T>(array)];
}
// TODO: We currently generate IDs as a pure random integer; remove once unique UUIDs are added
it.todo("2 Pokemon should not be able to generate with the same ID during 1 encounter", async () => {
game.override.battleType(BattleType.TRAINER); // enemy generates 2 mons
await game.classicMode.startBattle([Species.FEEBAS, Species.ABRA]);
const ids = (game.scene.getPlayerParty() as Pokemon[]).concat(game.scene.getEnemyParty()).map((p: Pokemon) => p.id);
const uniqueIds = onlyUnique(ids);
expect(ids).toHaveLength(uniqueIds.length);
});
it("should not prevent item theft with PID of 0", async () => {
game.override
.moveset([Moves.THIEF, Moves.SPLASH])
.enemyHeldItems([{ name: "BERRY", count: 1, type: BerryType.APICOT }]);
vi.spyOn(allMoves[Moves.THIEF], "chance", "get").mockReturnValue(100);
await game.classicMode.startBattle([Species.TREECKO]);
const player = game.scene.getPlayerPokemon()!;
const enemy = game.scene.getEnemyPokemon()!;
// Override enemy pokemon PID to be 0
enemy.id = 0;
game.scene.getModifiers(BerryModifier, false).forEach(modifier => {
modifier.pokemonId = enemy.id;
});
expect(enemy.getHeldItems()).toHaveLength(1);
expect(player.getHeldItems()).toHaveLength(0);
// Player uses Thief and steals the opponent's item
game.move.select(Moves.THIEF);
await game.phaseInterceptor.to("TurnEndPhase");
expect(enemy.getHeldItems()).toHaveLength(0);
expect(player.getHeldItems()).toHaveLength(1);
});
it("should not prevent Syrup Bomb triggering if user has PID of 0", async () => {
game.override.moveset(Moves.SYRUP_BOMB);
await game.classicMode.startBattle([Species.TREECKO]);
const player = game.scene.getPlayerPokemon()!;
// Override player pokemon PID to be 0
player.id = 0;
const enemy = game.scene.getEnemyPokemon()!;
expect(enemy.getTag(BattlerTagType.SYRUP_BOMB)).toBeUndefined();
game.move.select(Moves.SYRUP_BOMB);
await game.phaseInterceptor.to("TurnEndPhase");
const syrupTag = enemy.getTag(BattlerTagType.SYRUP_BOMB)!;
expect(syrupTag).toBeDefined();
expect(syrupTag.getSourcePokemon()).toBe(player);
expect(enemy.getStatStage(Stat.SPD)).toBe(-1);
});
});