Apply suggestions from code review

This commit is contained in:
Lugiad 2024-10-02 21:56:11 +02:00 committed by GitHub
parent bb47241313
commit a1a23614aa
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with 8 additions and 8 deletions

View File

@ -56,12 +56,12 @@ const fonts: Array<LoadingFontFaceProperty> = [
{ {
face: new FontFace("emerald", "url(./fonts/unifont-15.1.05.subset.woff2)", { unicodeRange: rangesByLanguage.chinese }), face: new FontFace("emerald", "url(./fonts/unifont-15.1.05.subset.woff2)", { unicodeRange: rangesByLanguage.chinese }),
extraOptions: { sizeAdjust: "70%", format: "woff2" }, extraOptions: { sizeAdjust: "70%", format: "woff2" },
only: [ "en", "es", "fr", "it", "de", "zh", "pt", "ko", "ca", "dk" ], only: [ "en", "es", "fr", "it", "de", "zh", "pt", "ko", "ca", "da" ],
}, },
{ {
face: new FontFace("pkmnems", "url(./fonts/unifont-15.1.05.subset.woff2)", { unicodeRange: rangesByLanguage.chinese }), face: new FontFace("pkmnems", "url(./fonts/unifont-15.1.05.subset.woff2)", { unicodeRange: rangesByLanguage.chinese }),
extraOptions: { format: "woff2" }, extraOptions: { format: "woff2" },
only: [ "en", "es", "fr", "it", "de", "zh", "pt", "ko", "ca", "dk" ], only: [ "en", "es", "fr", "it", "de", "zh", "pt", "ko", "ca", "da" ],
}, },
// japanese // japanese
{ {
@ -120,7 +120,7 @@ export async function initI18n(): Promise<void> {
await i18next.init({ await i18next.init({
nonExplicitSupportedLngs: true, nonExplicitSupportedLngs: true,
fallbackLng: "en", fallbackLng: "en",
supportedLngs: ["en", "es", "fr", "it", "de", "zh", "pt", "ko", "ja", "ca", "dk"], supportedLngs: ["en", "es", "fr", "it", "de", "zh", "pt", "ko", "ja", "ca", "da"],
defaultNS: "menu", defaultNS: "menu",
ns: Object.keys(enConfig), ns: Object.keys(enConfig),
detection: { detection: {
@ -164,7 +164,7 @@ export async function initI18n(): Promise<void> {
"ca-ES": { "ca-ES": {
...caEsConfig ...caEsConfig
}, },
"dk": { "da": {
...dkConfig ...dkConfig
} }
}, },

View File

@ -907,7 +907,7 @@ export function setSetting(scene: BattleScene, setting: string, value: integer):
// }, // },
{ {
label: "Dansk", label: "Dansk",
handler: () => changeLocaleHandler("dk") handler: () => changeLocaleHandler("da")
}, },
{ {
label: i18next.t("settings:back"), label: i18next.t("settings:back"),

View File

@ -89,7 +89,7 @@ export default class SettingsDisplayUiHandler extends AbstractSettingsUiHandler
value: "Català", value: "Català",
label: "Català", label: "Català",
}; };
case "dk": case "da":
this.settings[languageIndex].options[0] = { this.settings[languageIndex].options[0] = {
value: "Dansk", value: "Dansk",
label: "Dansk", label: "Dansk",

View File

@ -117,7 +117,7 @@ const languageSettings: { [key: string]: LanguageSetting } = {
starterInfoTextSize: "56px", starterInfoTextSize: "56px",
instructionTextSize: "38px", instructionTextSize: "38px",
}, },
"dk":{ "da":{
starterInfoTextSize: "56px", starterInfoTextSize: "56px",
instructionTextSize: "38px", instructionTextSize: "38px",
}, },

View File

@ -492,7 +492,7 @@ export function verifyLang(lang?: string): boolean {
case "es": case "es":
case "fr": case "fr":
case "de": case "de":
case "dk": case "da":
case "it": case "it":
case "zh-CN": case "zh-CN":
case "zh-TW": case "zh-TW":