From a1a23614aa091c9226b33c0a553824f203b72e2f Mon Sep 17 00:00:00 2001
From: Lugiad <2070109+Adri1@users.noreply.github.com>
Date: Wed, 2 Oct 2024 21:56:11 +0200
Subject: [PATCH] Apply suggestions from code review

---
 src/plugins/i18n.ts                            | 8 ++++----
 src/system/settings/settings.ts                | 2 +-
 src/ui/settings/settings-display-ui-handler.ts | 2 +-
 src/ui/starter-select-ui-handler.ts            | 2 +-
 src/utils.ts                                   | 2 +-
 5 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/plugins/i18n.ts b/src/plugins/i18n.ts
index 75f3cc21c18..3c9e1136dfe 100644
--- a/src/plugins/i18n.ts
+++ b/src/plugins/i18n.ts
@@ -56,12 +56,12 @@ const fonts: Array<LoadingFontFaceProperty> = [
   {
     face: new FontFace("emerald", "url(./fonts/unifont-15.1.05.subset.woff2)", { unicodeRange: rangesByLanguage.chinese }),
     extraOptions: { sizeAdjust: "70%", format: "woff2" },
-    only: [ "en", "es", "fr", "it", "de", "zh", "pt", "ko", "ca", "dk" ],
+    only: [ "en", "es", "fr", "it", "de", "zh", "pt", "ko", "ca", "da" ],
   },
   {
     face: new FontFace("pkmnems", "url(./fonts/unifont-15.1.05.subset.woff2)", { unicodeRange: rangesByLanguage.chinese }),
     extraOptions: { format: "woff2" },
-    only: [ "en", "es", "fr", "it", "de", "zh", "pt", "ko", "ca", "dk" ],
+    only: [ "en", "es", "fr", "it", "de", "zh", "pt", "ko", "ca", "da" ],
   },
   // japanese
   {
@@ -120,7 +120,7 @@ export async function initI18n(): Promise<void> {
   await i18next.init({
     nonExplicitSupportedLngs: true,
     fallbackLng: "en",
-    supportedLngs: ["en", "es", "fr", "it", "de", "zh", "pt", "ko", "ja", "ca", "dk"],
+    supportedLngs: ["en", "es", "fr", "it", "de", "zh", "pt", "ko", "ja", "ca", "da"],
     defaultNS: "menu",
     ns: Object.keys(enConfig),
     detection: {
@@ -164,7 +164,7 @@ export async function initI18n(): Promise<void> {
       "ca-ES": {
         ...caEsConfig
       },
-      "dk": {
+      "da": {
         ...dkConfig
       }
     },
diff --git a/src/system/settings/settings.ts b/src/system/settings/settings.ts
index f3a3f9b1aa1..64f22911b72 100644
--- a/src/system/settings/settings.ts
+++ b/src/system/settings/settings.ts
@@ -907,7 +907,7 @@ export function setSetting(scene: BattleScene, setting: string, value: integer):
             // },
             {
               label: "Dansk",
-              handler: () => changeLocaleHandler("dk")
+              handler: () => changeLocaleHandler("da")
             },
             {
               label: i18next.t("settings:back"),
diff --git a/src/ui/settings/settings-display-ui-handler.ts b/src/ui/settings/settings-display-ui-handler.ts
index fb0e62719b5..c6a224a0cea 100644
--- a/src/ui/settings/settings-display-ui-handler.ts
+++ b/src/ui/settings/settings-display-ui-handler.ts
@@ -89,7 +89,7 @@ export default class SettingsDisplayUiHandler extends AbstractSettingsUiHandler
           value: "Català",
           label: "Català",
         };
-      case "dk":
+      case "da":
         this.settings[languageIndex].options[0] = {
           value: "Dansk",
           label: "Dansk",
diff --git a/src/ui/starter-select-ui-handler.ts b/src/ui/starter-select-ui-handler.ts
index cb8aa0145ca..7bb822e0185 100644
--- a/src/ui/starter-select-ui-handler.ts
+++ b/src/ui/starter-select-ui-handler.ts
@@ -117,7 +117,7 @@ const languageSettings: { [key: string]: LanguageSetting } = {
     starterInfoTextSize: "56px",
     instructionTextSize: "38px",
   },
-  "dk":{
+  "da":{
     starterInfoTextSize: "56px",
     instructionTextSize: "38px",
   },
diff --git a/src/utils.ts b/src/utils.ts
index a45ad72a376..1dbb054e834 100644
--- a/src/utils.ts
+++ b/src/utils.ts
@@ -492,7 +492,7 @@ export function verifyLang(lang?: string): boolean {
   case "es":
   case "fr":
   case "de":
-  case "dk":
+  case "da":
   case "it":
   case "zh-CN":
   case "zh-TW":