mika/pokerogue
1
0
Fork 0
mirror of https://github.com/pagefaultgames/pokerogue.git synced 2025-07-04 07:22:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

Apply kev's suggestions from code review

Browse Source 
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
This commit is contained in:
Sirz Benjie 2025-06-09 18:21:07 -05:00
parent 37af6d9c52
commit 7e52862704
No known key found for this signature in database
GPG Key ID: 4A524B4D196C759E
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/@types/move-types.ts
View File

@ -17,7 +17,8 @@ export type * from "#app/data/moves/move";
* Does not include the ChargeMove subclasses. For that, use `ChargingMoveClassMap`. * Does not include the ChargeMove subclasses. For that, use `ChargingMoveClassMap`.
* *
* @privateremarks * @privateremarks
* The `Never` field is necessary to ensure typescript does not improperly narrow a failed `is` guard to `never`. * The `never` field (`declare private _: never`) in some classes is necessary
* to ensure typescript does not improperly narrow a failed `is` guard to `never`.
* *
* For example, if we did not have the never, and wrote * For example, if we did not have the never, and wrote
* ``` * ```
@ -35,10 +36,6 @@ export type MoveClassMap = {
SelfStatusMove: SelfStatusMove; SelfStatusMove: SelfStatusMove;
}; };
/*
* Without the `Never: never` field, typescript will
*/
/** /**
* Union type of all move subclass names * Union type of all move subclass names
*/ */