From 7e5286270470790adb9257746f31060e97faff31 Mon Sep 17 00:00:00 2001 From: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com> Date: Mon, 9 Jun 2025 18:21:07 -0500 Subject: [PATCH] Apply kev's suggestions from code review Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com> --- src/@types/move-types.ts | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/@types/move-types.ts b/src/@types/move-types.ts index 28d603d21bb..d9a06fd20ee 100644 --- a/src/@types/move-types.ts +++ b/src/@types/move-types.ts @@ -17,7 +17,8 @@ export type * from "#app/data/moves/move"; * Does not include the ChargeMove subclasses. For that, use `ChargingMoveClassMap`. * * @privateremarks - * The `Never` field is necessary to ensure typescript does not improperly narrow a failed `is` guard to `never`. + * The `never` field (`declare private _: never`) in some classes is necessary + * to ensure typescript does not improperly narrow a failed `is` guard to `never`. * * For example, if we did not have the never, and wrote * ``` @@ -35,10 +36,6 @@ export type MoveClassMap = { SelfStatusMove: SelfStatusMove; }; -/* - * Without the `Never: never` field, typescript will - */ - /** * Union type of all move subclass names */