Remove package manager constraints from github workflows per DayKev

Update podman.md docs with extra steps for locales and testing command
Remove missleading comment from Dockerfile
This commit is contained in:
Domagoj 2025-08-16 14:59:27 +02:00
parent 72b86ca6ad
commit 7b1b91647c
6 changed files with 10 additions and 14 deletions

View File

@ -21,8 +21,6 @@ jobs:
- name: Install pnpm - name: Install pnpm
uses: pnpm/action-setup@v4 uses: pnpm/action-setup@v4
with:
version: 10
- uses: actions/setup-node@v4 - uses: actions/setup-node@v4
with: with:

View File

@ -19,8 +19,6 @@ jobs:
- name: Install pnpm - name: Install pnpm
uses: pnpm/action-setup@v4 uses: pnpm/action-setup@v4
with:
version: 10
- uses: actions/setup-node@v4 - uses: actions/setup-node@v4
with: with:

View File

@ -37,8 +37,6 @@ jobs:
- name: Install pnpm - name: Install pnpm
uses: pnpm/action-setup@v4 uses: pnpm/action-setup@v4
with:
version: 10
- name: Setup Node 22.14.1 - name: Setup Node 22.14.1
uses: actions/setup-node@v4 uses: actions/setup-node@v4

View File

@ -25,8 +25,6 @@ jobs:
- name: Install pnpm - name: Install pnpm
uses: pnpm/action-setup@v4 uses: pnpm/action-setup@v4
with:
version: 10
- name: Set up Node.js - name: Set up Node.js
uses: actions/setup-node@v4 uses: actions/setup-node@v4

View File

@ -31,8 +31,6 @@ jobs:
- name: Install pnpm - name: Install pnpm
uses: pnpm/action-setup@v4 uses: pnpm/action-setup@v4
with:
version: 10
- name: Set up Node.js - name: Set up Node.js
uses: actions/setup-node@v4 uses: actions/setup-node@v4

View File

@ -9,13 +9,19 @@
1. `podman build -t pokerogue -f Dockerfile .` 1. `podman build -t pokerogue -f Dockerfile .`
2. `podman create --name temp-pokerogue localhost/pokerogue` 2. `podman create --name temp-pokerogue localhost/pokerogue`
3. `podman cp temp-pokerogue:/app/node_modules ./` 3. `podman cp temp-pokerogue:/app/node_modules ./`
4. `podman rm temp-pokerogue` 4. `podman cp temp-pokerogue:/app/public/locales ./public/`
5. `podman run --rm -p 8000:8000 -v $(pwd):/app:Z --userns=keep-id -u $(id -u):$(id -g) localhost/pokerogue` 5. `podman rm temp-pokerogue`
6. Visit `http://localhost:8000/` 6. `podman run --rm -p 8000:8000 -v $(pwd):/app:Z --userns=keep-id -u $(id -u):$(id -g) localhost/pokerogue`
7. Visit `http://localhost:8000/`
Note: Note:
1. Steps 2,3,4 are required because mounting working directory without installed `node_modules/` locally will be empty, 1. Steps 2,3,4 are required because mounting working directory without installed `node_modules/` locally will be empty,
this way we prevent it by copying them from the container itself to local directory this way we prevent it by copying them from the container itself to local directory
2. `podman run` may take a couple of minutes to mount the working directory 2. `podman run` may take a couple of minutes to mount the working directory
### Running tests inside container
1. `podman run --rm -p 8000:8000 -v $(pwd):/app:Z --userns=keep-id -u $(id -u):$(id -g) localhost/pokerogue2 pnpm test:silent
`