diff --git a/.github/workflows/deploy-beta.yml b/.github/workflows/deploy-beta.yml index 0894032c8ad..b12e0f1f83a 100644 --- a/.github/workflows/deploy-beta.yml +++ b/.github/workflows/deploy-beta.yml @@ -21,8 +21,6 @@ jobs: - name: Install pnpm uses: pnpm/action-setup@v4 - with: - version: 10 - uses: actions/setup-node@v4 with: diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index 0e7102a41dd..439f1e7749f 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -19,8 +19,6 @@ jobs: - name: Install pnpm uses: pnpm/action-setup@v4 - with: - version: 10 - uses: actions/setup-node@v4 with: diff --git a/.github/workflows/github-pages.yml b/.github/workflows/github-pages.yml index 1588a15afeb..994409bbb30 100644 --- a/.github/workflows/github-pages.yml +++ b/.github/workflows/github-pages.yml @@ -37,8 +37,6 @@ jobs: - name: Install pnpm uses: pnpm/action-setup@v4 - with: - version: 10 - name: Setup Node 22.14.1 uses: actions/setup-node@v4 diff --git a/.github/workflows/linting.yml b/.github/workflows/linting.yml index 82f5abd23a1..b6edb11ebe6 100644 --- a/.github/workflows/linting.yml +++ b/.github/workflows/linting.yml @@ -25,8 +25,6 @@ jobs: - name: Install pnpm uses: pnpm/action-setup@v4 - with: - version: 10 - name: Set up Node.js uses: actions/setup-node@v4 diff --git a/.github/workflows/test-shard-template.yml b/.github/workflows/test-shard-template.yml index 124004f380f..80fca34bcb2 100644 --- a/.github/workflows/test-shard-template.yml +++ b/.github/workflows/test-shard-template.yml @@ -31,8 +31,6 @@ jobs: - name: Install pnpm uses: pnpm/action-setup@v4 - with: - version: 10 - name: Set up Node.js uses: actions/setup-node@v4 diff --git a/docs/podman.md b/docs/podman.md index 7f1c2d8a653..80fee3258d1 100644 --- a/docs/podman.md +++ b/docs/podman.md @@ -9,13 +9,19 @@ 1. `podman build -t pokerogue -f Dockerfile .` 2. `podman create --name temp-pokerogue localhost/pokerogue` 3. `podman cp temp-pokerogue:/app/node_modules ./` -4. `podman rm temp-pokerogue` -5. `podman run --rm -p 8000:8000 -v $(pwd):/app:Z --userns=keep-id -u $(id -u):$(id -g) localhost/pokerogue` -6. Visit `http://localhost:8000/` +4. `podman cp temp-pokerogue:/app/public/locales ./public/` +5. `podman rm temp-pokerogue` +6. `podman run --rm -p 8000:8000 -v $(pwd):/app:Z --userns=keep-id -u $(id -u):$(id -g) localhost/pokerogue` +7. Visit `http://localhost:8000/` Note: 1. Steps 2,3,4 are required because mounting working directory without installed `node_modules/` locally will be empty, this way we prevent it by copying them from the container itself to local directory -2. `podman run` may take a couple of minutes to mount the working directory \ No newline at end of file +2. `podman run` may take a couple of minutes to mount the working directory + +### Running tests inside container + +1. `podman run --rm -p 8000:8000 -v $(pwd):/app:Z --userns=keep-id -u $(id -u):$(id -g) localhost/pokerogue2 pnpm test:silent +` \ No newline at end of file