pokerogue/test
AJ Fontaine e3108603e3
[Refactor] Rework evolution conditions and descriptions (#5679)
* Refactor evo conditions and descriptions

* Fix test

* Fix Shedinja

* Simplify Gimmighoul evolution

* Primeape and Stantler evolve by using their move 10 times

* Basculin white stripe evolves by taking 294 recoil damage

* Primeape and Stantler use modifiers for tracking

* Basculin uses modifier too

* Remove evo count from pokemon data

* No more evo counter data, Gallade/Froslass

* Fix allmoves import

* Clamperl

* Struggle shouldn't count for Basc recoil

* Change to nicer type

* Apply Benjie's suggestions

Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>

* Address formatting

* Undo new evolution changes

* Remove unused imports

* Fix speciesid

* Fixed up descriptions a little

* Change a key name

* Fix Gimmighoul

* Apply Biome

* Apply Biome unsafe fixes

* Review suggestions

- Convert `EvoCondKey` enum to `const` object

- Use early returns in `SpeciesEvolutionCondition#description`
and `SpeciesFormEvolution#description`

- Replace `!!x.find` with `x.some`
and `y.indexOf() > -1` with `y.includes()`

- Implement `coerceArray`

- Fix Shelmet evolution condition
checking for Shelmet and not Karrablast

- Remove unnecessary type casting in `battle-scene.ts`

* Remove leftover enforce func loop

* Fix circular imports issue

- `getPokemonSpecies` moved to `src/utils/pokemon-utils.ts`
- `allSpecies` moved to `src/data/data-lists.ts`

---------

Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-06-16 05:57:51 -07:00
..
abilities [Test] Reworked crit override to allow for forced crits (#5738) 2025-06-16 05:36:09 -07:00
achievements [Test] Convert game.override calls into chained line where possible 2025-06-15 00:40:41 -07:00
arena [Test] Reworked crit override to allow for forced crits (#5738) 2025-06-16 05:36:09 -07:00
battle [Refactor] Rework evolution conditions and descriptions (#5679) 2025-06-16 05:57:51 -07:00
battlerTags [Refactor] Remove circular deps 3 (#5959) 2025-06-09 16:24:13 -07:00
data [Test] Reworked crit override to allow for forced crits (#5738) 2025-06-16 05:36:09 -07:00
eggs [Refactor] Rework evolution conditions and descriptions (#5679) 2025-06-16 05:57:51 -07:00
field [Test] Convert game.override calls into chained line where possible 2025-06-15 00:40:41 -07:00
inputs [Misc][Refactor][GitHub] Ditch eslint for biome, and add a formatter (#5495) 2025-03-09 14:13:25 -07:00
items [Test] Reworked crit override to allow for forced crits (#5738) 2025-06-16 05:36:09 -07:00
moves [Refactor] Rework evolution conditions and descriptions (#5679) 2025-06-16 05:57:51 -07:00
mystery-encounter [Refactor] Rework evolution conditions and descriptions (#5679) 2025-06-16 05:57:51 -07:00
phases [Refactor] Rework evolution conditions and descriptions (#5679) 2025-06-16 05:57:51 -07:00
plugins/api [Bug] Fix clear ignoring errors from server (#5722) 2025-04-29 23:55:42 -07:00
settingMenu [Refactor/Bug/Ability] Reworked BattleData, fixed Rage Fist, Harvest, Belch + Implemented Cud Chew (#5655) 2025-05-02 00:06:07 -05:00
sprites [Refactor] Refactor variant sprite code part 1 (#5592) 2025-04-09 10:43:05 -05:00
system [Misc] Improve enum naming (#5933) 2025-06-04 14:54:27 -07:00
testUtils [Refactor] Rework evolution conditions and descriptions (#5679) 2025-06-16 05:57:51 -07:00
ui [Refactor] Rework evolution conditions and descriptions (#5679) 2025-06-16 05:57:51 -07:00
account.test.ts [Refactor] Remove circular imports part 1 (#5663) 2025-04-19 11:57:03 +00:00
battle-scene.test.ts [Test] Move test folder out of src (#5398) 2025-02-22 22:52:07 -06:00
boss-pokemon.test.ts [Refactor] Rework evolution conditions and descriptions (#5679) 2025-06-16 05:57:51 -07:00
daily_mode.test.ts [Misc] Improve enum naming (#5933) 2025-06-04 14:54:27 -07:00
endless_boss.test.ts [Test] Reworked crit override to allow for forced crits (#5738) 2025-06-16 05:36:09 -07:00
enemy_command.test.ts [Refactor] Remove circular deps 3 (#5959) 2025-06-09 16:24:13 -07:00
escape-calculations.test.ts [Test] Remove unneeded mockRestore and testTimeout calls in tests 2025-06-15 00:48:16 -07:00
evolution.test.ts [Test] Convert game.override calls into chained line where possible 2025-06-15 00:40:41 -07:00
final_boss.test.ts [Test] Reworked crit override to allow for forced crits (#5738) 2025-06-16 05:36:09 -07:00
fontFace.setup.ts [Test] Move test folder out of src (#5398) 2025-02-22 22:52:07 -06:00
game-mode.test.ts [Test] Remove unneeded mockRestore and testTimeout calls in tests 2025-06-15 00:48:16 -07:00
imports.test.ts [Refactor] Remove circular deps 3 (#5959) 2025-06-09 16:24:13 -07:00
internals.test.ts [Misc] Improve enum naming (#5933) 2025-06-04 14:54:27 -07:00
misc.test.ts [Misc][Refactor][GitHub] Ditch eslint for biome, and add a formatter (#5495) 2025-03-09 14:13:25 -07:00
reload.test.ts [Test] Remove unneeded mockRestore and testTimeout calls in tests 2025-06-15 00:48:16 -07:00
utils.test.ts [Refactor/Bug/Ability] Reworked BattleData, fixed Rage Fist, Harvest, Belch + Implemented Cud Chew (#5655) 2025-05-02 00:06:07 -05:00
vitest.setup.ts [Biome] Add "no unused imports" rule (#5580) 2025-03-29 10:24:23 +00:00