pokerogue/test/battle
AJ Fontaine e3108603e3
[Refactor] Rework evolution conditions and descriptions (#5679)
* Refactor evo conditions and descriptions

* Fix test

* Fix Shedinja

* Simplify Gimmighoul evolution

* Primeape and Stantler evolve by using their move 10 times

* Basculin white stripe evolves by taking 294 recoil damage

* Primeape and Stantler use modifiers for tracking

* Basculin uses modifier too

* Remove evo count from pokemon data

* No more evo counter data, Gallade/Froslass

* Fix allmoves import

* Clamperl

* Struggle shouldn't count for Basc recoil

* Change to nicer type

* Apply Benjie's suggestions

Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>

* Address formatting

* Undo new evolution changes

* Remove unused imports

* Fix speciesid

* Fixed up descriptions a little

* Change a key name

* Fix Gimmighoul

* Apply Biome

* Apply Biome unsafe fixes

* Review suggestions

- Convert `EvoCondKey` enum to `const` object

- Use early returns in `SpeciesEvolutionCondition#description`
and `SpeciesFormEvolution#description`

- Replace `!!x.find` with `x.some`
and `y.indexOf() > -1` with `y.includes()`

- Implement `coerceArray`

- Fix Shelmet evolution condition
checking for Shelmet and not Karrablast

- Remove unnecessary type casting in `battle-scene.ts`

* Remove leftover enforce func loop

* Fix circular imports issue

- `getPokemonSpecies` moved to `src/utils/pokemon-utils.ts`
- `allSpecies` moved to `src/data/data-lists.ts`

---------

Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-06-16 05:57:51 -07:00
..
ability_swap.test.ts [Test] Reworked crit override to allow for forced crits (#5738) 2025-06-16 05:36:09 -07:00
battle-order.test.ts [Test] Remove unneeded mockRestore and testTimeout calls in tests 2025-06-15 00:48:16 -07:00
battle.test.ts [Refactor] Rework evolution conditions and descriptions (#5679) 2025-06-16 05:57:51 -07:00
damage_calculation.test.ts [Test] Reworked crit override to allow for forced crits (#5738) 2025-06-16 05:36:09 -07:00
double_battle.test.ts [Test] Remove unneeded mockRestore and testTimeout calls in tests 2025-06-15 00:48:16 -07:00
inverse_battle.test.ts [Refactor] Remove circular deps 3 (#5959) 2025-06-09 16:24:13 -07:00
special_battle.test.ts [Test] Remove unneeded mockRestore and testTimeout calls in tests 2025-06-15 00:48:16 -07:00