pokerogue/src/system
AJ Fontaine e3108603e3
[Refactor] Rework evolution conditions and descriptions (#5679)
* Refactor evo conditions and descriptions

* Fix test

* Fix Shedinja

* Simplify Gimmighoul evolution

* Primeape and Stantler evolve by using their move 10 times

* Basculin white stripe evolves by taking 294 recoil damage

* Primeape and Stantler use modifiers for tracking

* Basculin uses modifier too

* Remove evo count from pokemon data

* No more evo counter data, Gallade/Froslass

* Fix allmoves import

* Clamperl

* Struggle shouldn't count for Basc recoil

* Change to nicer type

* Apply Benjie's suggestions

Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>

* Address formatting

* Undo new evolution changes

* Remove unused imports

* Fix speciesid

* Fixed up descriptions a little

* Change a key name

* Fix Gimmighoul

* Apply Biome

* Apply Biome unsafe fixes

* Review suggestions

- Convert `EvoCondKey` enum to `const` object

- Use early returns in `SpeciesEvolutionCondition#description`
and `SpeciesFormEvolution#description`

- Replace `!!x.find` with `x.some`
and `y.indexOf() > -1` with `y.includes()`

- Implement `coerceArray`

- Fix Shelmet evolution condition
checking for Shelmet and not Karrablast

- Remove unnecessary type casting in `battle-scene.ts`

* Remove leftover enforce func loop

* Fix circular imports issue

- `getPokemonSpecies` moved to `src/utils/pokemon-utils.ts`
- `allSpecies` moved to `src/data/data-lists.ts`

---------

Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-06-16 05:57:51 -07:00
..
settings [Misc] Run biome on all files; update some rules to be errors now 2025-06-14 00:59:34 -07:00
version_migration [Refactor] Rework evolution conditions and descriptions (#5679) 2025-06-16 05:57:51 -07:00
achv.ts [Refactor] Remove circular imports part 1 (#5663) 2025-04-19 11:57:03 +00:00
arena-data.ts [Misc] Improve enum naming (#5933) 2025-06-04 14:54:27 -07:00
challenge-data.ts [Refactor] Replace all instances of integer with number (#5250) 2025-02-04 17:56:13 -07:00
egg-data.ts [Misc] Improve enum naming (#5933) 2025-06-04 14:54:27 -07:00
game-data.ts [Refactor] Rework evolution conditions and descriptions (#5679) 2025-06-16 05:57:51 -07:00
game-speed.ts [Refactor] Remove circular imports part 1 (#5663) 2025-04-19 11:57:03 +00:00
game-stats.ts [Refactor] Replace all instances of integer with number (#5250) 2025-02-04 17:56:13 -07:00
modifier-data.ts [Misc][Refactor][GitHub] Ditch eslint for biome, and add a formatter (#5495) 2025-03-09 14:13:25 -07:00
pokemon-data.ts [Refactor] Rework evolution conditions and descriptions (#5679) 2025-06-16 05:57:51 -07:00
trainer-data.ts [Refactor] Remove circular deps 3 (#5959) 2025-06-09 16:24:13 -07:00
unlockables.ts [Refactor] Remove circular dependencies (part 4) (#5964) 2025-06-11 19:42:04 -07:00
voucher.ts [Refactor] Minor refactor of trainer-config files (#5573) 2025-03-29 00:19:35 -04:00