pokerogue/test/moves/effectiveness.test.ts
AJ Fontaine e3108603e3
[Refactor] Rework evolution conditions and descriptions (#5679)
* Refactor evo conditions and descriptions

* Fix test

* Fix Shedinja

* Simplify Gimmighoul evolution

* Primeape and Stantler evolve by using their move 10 times

* Basculin white stripe evolves by taking 294 recoil damage

* Primeape and Stantler use modifiers for tracking

* Basculin uses modifier too

* Remove evo count from pokemon data

* No more evo counter data, Gallade/Froslass

* Fix allmoves import

* Clamperl

* Struggle shouldn't count for Basc recoil

* Change to nicer type

* Apply Benjie's suggestions

Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>

* Address formatting

* Undo new evolution changes

* Remove unused imports

* Fix speciesid

* Fixed up descriptions a little

* Change a key name

* Fix Gimmighoul

* Apply Biome

* Apply Biome unsafe fixes

* Review suggestions

- Convert `EvoCondKey` enum to `const` object

- Use early returns in `SpeciesEvolutionCondition#description`
and `SpeciesFormEvolution#description`

- Replace `!!x.find` with `x.some`
and `y.indexOf() > -1` with `y.includes()`

- Implement `coerceArray`

- Fix Shelmet evolution condition
checking for Shelmet and not Karrablast

- Remove unnecessary type casting in `battle-scene.ts`

* Remove leftover enforce func loop

* Fix circular imports issue

- `getPokemonSpecies` moved to `src/utils/pokemon-utils.ts`
- `allSpecies` moved to `src/data/data-lists.ts`

---------

Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-06-16 05:57:51 -07:00

101 lines
4.0 KiB
TypeScript

import { allMoves } from "#app/data/data-lists";
import { getPokemonSpecies } from "#app/utils/pokemon-utils";
import { TrainerSlot } from "#enums/trainer-slot";
import { PokemonType } from "#enums/pokemon-type";
import { AbilityId } from "#enums/ability-id";
import { MoveId } from "#enums/move-id";
import { SpeciesId } from "#enums/species-id";
import * as Messages from "#app/messages";
import GameManager from "#test/testUtils/gameManager";
import Phaser from "phaser";
import { afterEach, beforeAll, describe, expect, it, vi } from "vitest";
function testMoveEffectiveness(
game: GameManager,
move: MoveId,
targetSpecies: SpeciesId,
expected: number,
targetAbility: AbilityId = AbilityId.BALL_FETCH,
teraType?: PokemonType,
): void {
// Suppress getPokemonNameWithAffix because it calls on a null battle spec
vi.spyOn(Messages, "getPokemonNameWithAffix").mockReturnValue("");
game.override.enemyAbility(targetAbility);
const user = game.scene.addPlayerPokemon(getPokemonSpecies(SpeciesId.SNORLAX), 5);
const target = game.scene.addEnemyPokemon(getPokemonSpecies(targetSpecies), 5, TrainerSlot.NONE);
if (teraType !== undefined) {
target.teraType = teraType;
target.isTerastallized = true;
}
expect(target.getMoveEffectiveness(user, allMoves[move])).toBe(expected);
user.destroy();
target.destroy();
}
describe("Moves - Type Effectiveness", () => {
let phaserGame: Phaser.Game;
let game: GameManager;
beforeAll(() => {
phaserGame = new Phaser.Game({
type: Phaser.HEADLESS,
});
game = new GameManager(phaserGame);
game.override.ability(AbilityId.BALL_FETCH);
});
afterEach(() => {
game.phaseInterceptor.restoreOg();
});
it("Normal-type attacks are neutrally effective against Normal-type Pokemon", () =>
testMoveEffectiveness(game, MoveId.TACKLE, SpeciesId.SNORLAX, 1));
it("Normal-type attacks are not very effective against Steel-type Pokemon", () =>
testMoveEffectiveness(game, MoveId.TACKLE, SpeciesId.REGISTEEL, 0.5));
it("Normal-type attacks are doubly resisted by Steel/Rock-type Pokemon", () =>
testMoveEffectiveness(game, MoveId.TACKLE, SpeciesId.AGGRON, 0.25));
it("Normal-type attacks have no effect on Ghost-type Pokemon", () =>
testMoveEffectiveness(game, MoveId.TACKLE, SpeciesId.DUSCLOPS, 0));
it("Normal-type status moves are not affected by type matchups", () =>
testMoveEffectiveness(game, MoveId.GROWL, SpeciesId.DUSCLOPS, 1));
it("Electric-type attacks are super-effective against Water-type Pokemon", () =>
testMoveEffectiveness(game, MoveId.THUNDERBOLT, SpeciesId.BLASTOISE, 2));
it("Ghost-type attacks have no effect on Normal-type Pokemon", () =>
testMoveEffectiveness(game, MoveId.SHADOW_BALL, SpeciesId.URSALUNA, 0));
it("Electric-type attacks are doubly super-effective against Water/Flying-type Pokemon", () =>
testMoveEffectiveness(game, MoveId.THUNDERBOLT, SpeciesId.GYARADOS, 4));
it("Electric-type attacks are negated by Volt Absorb", () =>
testMoveEffectiveness(game, MoveId.THUNDERBOLT, SpeciesId.GYARADOS, 0, AbilityId.VOLT_ABSORB));
it("Electric-type attacks are super-effective against Tera-Water Pokemon", () =>
testMoveEffectiveness(game, MoveId.THUNDERBOLT, SpeciesId.EXCADRILL, 2, AbilityId.BALL_FETCH, PokemonType.WATER));
it("Powder moves have no effect on Grass-type Pokemon", () =>
testMoveEffectiveness(game, MoveId.SLEEP_POWDER, SpeciesId.AMOONGUSS, 0));
it("Powder moves have no effect on Tera-Grass Pokemon", () =>
testMoveEffectiveness(game, MoveId.SLEEP_POWDER, SpeciesId.SNORLAX, 0, AbilityId.BALL_FETCH, PokemonType.GRASS));
it("Prankster-boosted status moves have no effect on Dark-type Pokemon", () => {
game.override.ability(AbilityId.PRANKSTER);
testMoveEffectiveness(game, MoveId.BABY_DOLL_EYES, SpeciesId.MIGHTYENA, 0);
});
it("Prankster-boosted status moves have no effect on Tera-Dark Pokemon", () => {
game.override.ability(AbilityId.PRANKSTER);
testMoveEffectiveness(game, MoveId.BABY_DOLL_EYES, SpeciesId.SNORLAX, 0, AbilityId.BALL_FETCH, PokemonType.DARK);
});
});