[Hotfix] Retrieving the correct form index for correct cry keys (#4121)

* [DOCS] adding JSDocs to `arena.ts` (#3590)

* adding some docs

* Update src/field/pokemon.ts

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* seems like battleStats changed to statStages

* Apply suggestions from code review

editing doc text

Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>

* Update tsdocs, convert comment to tsdoc in `pokemon.ts`

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>

* [Bug] Fix scrappy (+ some immunity move and ability) in inverse battle (#4067)

* fix scrappy + etc. update inverse battle test code

* update test code following request from swain

* fix and optimize imports (#4061)

- remove any `.js` extension imports
- remove unncessary dynamic imports of `modifier.ts` file. The file was being imported statically & dynamically. Made it pure static
- increase vite chunk-size warning limit

Co-authored-by: Mumble <171087428+frutescens@users.noreply.github.com>

* returned main

* Fixed cry key

* Revert "[DOCS] adding JSDocs to `arena.ts` (#3590)"

This reverts commit 675e6a0635.

* Revert "[Bug] Fix scrappy (+ some immunity move and ability) in inverse battle (#4067)"

This reverts commit 45af0dd170.

* Revert "fix and optimize imports (#4061)"

This reverts commit e12548cdb0.

---------

Co-authored-by: DustinLin <39450497+DustinLin@users.noreply.github.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
Co-authored-by: Leo Kim <47556641+KimJeongSun@users.noreply.github.com>
Co-authored-by: frutescens <info@laptop>

src/battle-scene.ts

@@ -2765,8 +2765,8 @@ export default class BattleScene extends SceneBase {
     playerParty.forEach(p => {
       keys.push(p.getSpriteKey(true));
       keys.push(p.getBattleSpriteKey(true, true));
-      keys.push("cry/" + p.species.getCryKey(p.species.formIndex));
+      keys.push("cry/" + p.species.getCryKey(p.formIndex));
-      if (p.fusionSpecies && p.getSpeciesForm() !== p.getFusionSpeciesForm()) {
+      if (p.fusionSpecies) {
         keys.push("cry/"+p.fusionSpecies.getCryKey(p.fusionFormIndex));
       }
     });
@@ -2774,8 +2774,8 @@ export default class BattleScene extends SceneBase {
     const enemyParty = this.getEnemyParty();
     enemyParty.forEach(p => {
       keys.push(p.getSpriteKey(true));
-      keys.push("cry/" + p.species.getCryKey(p.species.formIndex));
+      keys.push("cry/" + p.species.getCryKey(p.formIndex));
-      if (p.fusionSpecies && p.getSpeciesForm() !== p.getFusionSpeciesForm()) {
+      if (p.fusionSpecies) {
         keys.push("cry/"+p.fusionSpecies.getCryKey(p.fusionFormIndex));
       }
     });

src/system/version-converter.ts

@@ -102,7 +102,7 @@ export function applySystemDataPatches(data: SystemSaveData) {
       // --- PATCHES ---
 
       // Fix Starter Data
-      if (data.gameVersion) {
+      if (data.starterData) {
         for (const starterId of defaultStarterSpecies) {
           data.starterData[starterId].abilityAttr |= AbilityAttr.ABILITY_1;
           data.dexData[starterId].caughtAttr |= DexAttr.FEMALE;