Merge e5499a9cdf into 0da37a0f0c

biome.jsonc

@@ -54,7 +54,7 @@
     "rules": {
       "recommended": true,
       "correctness": {
-        "noUndeclaredVariables": "off",
+        "noUndeclaredVariables": "error",
         "noUnusedVariables": "error",
         "noSwitchDeclarations": "error",
         "noVoidTypeReturn": "error",
@@ -67,6 +67,11 @@
         "noPrivateImports": "error"
       },
       "style": {
+        "useCollapsedIf": "warn", // TODO: promote to "error" eventually
+        "noDoneCallback": "error",
+        "noSubstr": "error",
+        "noYodaExpression": "warn", // TODO: Fix and promote to "error"
+        "useForOf": "warn", // TODO: Fix and promote to "error"
         "useEnumInitializers": "off", // large enums like Moves/Species would make this cumbersome
         "useBlockStatements": {
           "level": "error",
@@ -83,7 +88,7 @@
           "level": "warn",
           "fix": "none"
         },
-        "useSingleVarDeclarator": "off",
+        "useSingleVarDeclarator": "warn", // TODO: upgrade to "error"
         "useNodejsImportProtocol": "off",
         "useTemplate": "off", // string concatenation is faster: https://stackoverflow.com/questions/29055518/are-es6-template-literals-faster-than-string-concatenation
         "useAsConstAssertion": "error",
@@ -110,18 +115,19 @@
         // This can likely be enabled for all non-utils files once these are eventually reworked, but until then we leave it off.
         "noExplicitAny": "off",
         "noAssignInExpressions": "off",
-        "noPrototypeBuiltins": "off",
+        "noPrototypeBuiltins": "off", // TOZO: consider enabling?
         "noFallthroughSwitchClause": "error", // Prevents accidental automatic fallthroughs in switch cases (use disable comment if needed)
         "noImplicitAnyLet": "warn", // TODO: Refactor and make this an error
         "noRedeclare": "info", // TODO: Refactor and make this an error
-        "noGlobalIsNan": "off",
+        "noGlobalIsNan": "error",
         "noAsyncPromiseExecutor": "warn", // TODO: Refactor and make this an error
         "noVar": "error",
         "noDocumentCookie": "off" // Firefox has minimal support for the "Cookie Store API"
       },
       "complexity": {
+        "noUselessStringConcat": "error",
         "noExcessiveCognitiveComplexity": "info", // TODO: Refactor and make this an error
-        "useLiteralKeys": "off",
+        "useLiteralKeys": "off", // TODO: enable?
         "noForEach": "off", // Foreach vs for of is not that simple.
         "noUselessSwitchCase": "off", // Explicit > Implicit
         "noUselessConstructor": "error",
@@ -132,13 +138,16 @@
       },
       "performance": {
         "noNamespaceImport": "error",
-        "noDelete": "error"
+        "noDelete": "error",
+        "noBarrelFile": "error",
       },
       "nursery": {
+        "useSingleJsDocAsterisk": "error",
+        // "useUnifiedTypeSignature": "error", TODO: upgrade to biome 2.1 and enable
         "useAdjacentGetterSetter": "error",
         "noConstantBinaryExpression": "error",
         "noTsIgnore": "error",
-        "noAwaitInLoop": "off",
+        "noAwaitInLoop": "off", // we do this a lot
         "useJsonImportAttribute": "off", // "Import attributes are only supported when the '--module' option is set to 'esnext', 'node18', 'nodenext', or 'preserve'. ts(2823)"
         "useIndexOf": "error",
         "useObjectSpread": "error",
@@ -153,6 +162,7 @@
       "quoteStyle": "double",
       "arrowParentheses": "asNeeded"
     },
+    "globals": ["Phaser"],
     "parser": {
       "jsxEverywhere": false
     }