Sirz Benjie
5854b21da0
[Refactor] Remove circular imports part 1 ( #5663 )
...
* Extract Mode enum out of UI and into its own file
Reduces circular imports from 909 to 773
* Move around utility files
Reduces cyclical dependencies from 773 to 765
* Remove starterColors and bypassLogin from battle-scene
Reduces cyclical dependencies from 765 to 623
* Fix test runner error
* Update import for bypassLogin in test
* Update mocks for utils in tests
* Fix broken tests
* Update selectWithTera override
* Update path for utils in ab-attr.ts
* Update path for utils in ability-class.ts
* Fix utils import path in healer.test.ts
2025-04-19 11:57:03 +00:00
Lylian BALL
15e535a1a0
[Ability] Implement Illusion ( #3273 )
...
* implement illusion ability with unit test and localizations
* try removing whitespace change on unnecessary files
* nit corrections
* nit update src/field/pokemon.ts
Co-authored-by: Adrian T. <68144167+torranx@users.noreply.github.com>
* nit update src/phases.ts
Co-authored-by: Amani H. <109637146+xsn34kzx@users.noreply.github.com>
* illusion test correction
* unexpected error correction
* refactor property pokemon.illusion to pokemon.battleData.illusion
* nit
* nit
* update unit test up-to-date
* add docs
* merge up to date
* bugfix
* bugfix
* merge up to date
* refactor field illusion out of battleData
* fix nit
* fix nit
* Zoroark change illusion after lastPokemon update
* Zoroark change illusion after lastPokemon update
* refactor bug fix
* bugfix
* bug fix on tests
* Update src/field/pokemon.ts
Co-authored-by: innerthunder <168692175+innerthunder@users.noreply.github.com>
* use GetFailedText
* remove useless import
* add condition 'no illusion' into transform move
* wild Zoroark creates an illusion according to the current biome
* wild Zoroark creates an illusion according to the current biome
* delete console.log()
* add doc
* Update src/field/pokemon.ts
Co-authored-by: innerthunder <168692175+innerthunder@users.noreply.github.com>
* fix tests
* update locales submodule
* update Illusion interface
* bug fix
* bug fix
* bugfix
* rename some params for future implementations
* Zoroark keep illusion between battles
* Zoroark keep illusion between battles
* delete draft
* merge up-to-date
* bugfix
* merge
* merge
* implement canApplyPresummon method
* Update test/abilities/illusion.test.ts
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
* Update src/data/ability.ts
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
* Update src/data/ability.ts
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
* Update test/abilities/illusion.test.ts
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
* Update test/abilities/illusion.test.ts
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
* nit
* review corrections
* nit
* type hints affected by enemy illusion
* type hints affected by enemy illusionin fight-ui-handler
* nit
* rename some parameters back in useIllusion
* Update src/field/pokemon.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Update src/field/pokemon.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* refactor battleData.illusion as summonData.illusion and delete oncePerBattleClause
* add comments
* illusion will break before evolution
* Update src/field/pokemon.ts
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
* Update src/data/ability.ts
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
* Update src/data/ability.ts
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
* Update src/data/ability.ts
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
* Update src/data/ability.ts
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
* bug fix
* g
* get submodule back
* get submodule back
* bug fix to save illusion status
* add pokemon.getPokeball()
* Update src/field/pokemon.ts
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
* Update src/field/pokemon.ts
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
* Update src/field/pokemon.ts
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
* Update src/data/ability.ts
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
* Update src/field/pokemon.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Update src/field/pokemon.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Update src/field/pokemon.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Update src/field/pokemon.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
---------
Co-authored-by: Adrian T. <68144167+torranx@users.noreply.github.com>
Co-authored-by: Amani H. <109637146+xsn34kzx@users.noreply.github.com>
Co-authored-by: innerthunder <168692175+innerthunder@users.noreply.github.com>
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-04-12 21:22:04 -04:00
Sirz Benjie
408b66f913
[Misc][Refactor][GitHub] Ditch eslint for biome, and add a formatter ( #5495 )
...
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-03-09 14:13:25 -07:00
NightKev
0107b1d47e
[Refactor] Create global scene variable ( #4766 )
...
* Replace various `scene` pass-arounds with global scene variable
* Modify tests
* Add scene back to `fade[in|out]()` calls
Co-authored-by: Moka <54149968+MokaStitcher@users.noreply.github.com>
* Fix Bug Superfan ME test
Co-authored-by: Moka <54149968+MokaStitcher@users.noreply.github.com>
* Re-enable fixed test
Co-authored-by: Moka <54149968+MokaStitcher@users.noreply.github.com>
* Rename `gScene` to `globalScene`
* Move `globalScene` to its own file to fix import/async issues
* Fix `SelectModifierPhase` tests
* Fix ME tests by removing `scene` from `expect()`s
* Resolve merge issues
* Remove tsdocs referencing `scene` params
Remove missed instances of `.scene`
* Remove unnecessary `globalScene` usage in `loading-scene.ts`
* Fix merge conflicts
* Attempt to fix circular import issue
* Found the source of the import issue
* Fix merge issues
---------
Co-authored-by: Moka <54149968+MokaStitcher@users.noreply.github.com>
2025-01-12 15:33:05 -08:00
NightKev
b6b756a162
[P2] Fix issue with Pokemon not evolving until the next floor and clean up LevelUpPhase ( #4854 )
2024-11-12 06:44:28 -05:00
MokaStitcher
6e10f6600f
[P2] Fix damage achievements not awarding ( #4613 )
2024-10-08 11:08:25 -04:00
flx-sta
2bd07cb84e
fix and optimize imports ( #4061 )
...
- remove any `.js` extension imports
- remove unncessary dynamic imports of `modifier.ts` file. The file was being imported statically & dynamically. Made it pure static
- increase vite chunk-size warning limit
Co-authored-by: Mumble <171087428+frutescens@users.noreply.github.com>
2024-09-07 21:37:37 -07:00
Frederico Santos
ae2ab120dc
Deleted phases.ts ( #3618 )
2024-08-19 03:23:52 +01:00
