NightKev
280be34e7f
Apply Biome and fix some suppression comments
2025-06-17 18:36:53 -07:00
Bertie690
a41de39d4f
[Misc] Run biome on all files; update some rules to be errors now
...
https://github.com/pagefaultgames/pokerogue/pull/5962/
* Fixed lint issue; ran biome on entire repository
* Fixed biome.jsonc
* Trimmed trailing whitespace... again...
* Fixed PR template md
* Fixed package json
* Fixed void return issues + ran biome again
* ran biome
2025-06-14 00:59:34 -07:00
Sirz Benjie
48e911e03c
[Refactor] Remove circular deps 3 ( #5959 )
...
* Move game-mode to its own file
Reduces circular imports to 325
* Move battler-index to own file
Reduces circular deps to 314
* Move trainer-variant to own file
Reduces circ deps to 313
* Move enums in pokemon to their own file
* Move arena-tag-type to its own file
* Move pokemon-moves to its own file
* Move command to own file
* Move learnMoveType to own file
* Move form change item to own file
* Move battlerTagLapseType to own file
* Move anim enums to own shared file
* Move enums out of challenges
* Move species form change triggers to own file
Reduces circ imports to 291
* Update test importing pokemon move
* Replace move attribute imports with string names
* Untangle circular deps from game data
* Fix missing string call in switch summon phase
* Apply kev's suggestions from code review
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Ensure ChargeMove's is method calls super
* Use InstanceType for proper narrowing
* Apply kev's suggestions from code review
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
---------
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-06-09 16:24:13 -07:00
NightKev
9dcb904649
[Misc] Improve enum naming ( #5933 )
...
* Rename `Abilities` to `AbilityId`
* Rename `abilities.ts` to `ability-id.ts`
* Rename `Moves` to `MoveId`
* Rename `moves.ts` to `move-id.ts`
* Rename `Species` to `SpeciesId`
* Rename `species.ts` to `species-id.ts`
* Rename `Biome` to `BiomeId`
* Rename `biome.ts` to `biome-id.ts`
* Replace `Abilities` with `AbilityId` in comments
* Replace `Biome` with `BiomeId` in comments
* Replace `Moves` with `MoveId` in comments
* Replace `Species` with `SpeciesId` in comments
2025-06-04 14:54:27 -07:00
Sirz Benjie
5854b21da0
[Refactor] Remove circular imports part 1 ( #5663 )
...
* Extract Mode enum out of UI and into its own file
Reduces circular imports from 909 to 773
* Move around utility files
Reduces cyclical dependencies from 773 to 765
* Remove starterColors and bypassLogin from battle-scene
Reduces cyclical dependencies from 765 to 623
* Fix test runner error
* Update import for bypassLogin in test
* Update mocks for utils in tests
* Fix broken tests
* Update selectWithTera override
* Update path for utils in ab-attr.ts
* Update path for utils in ability-class.ts
* Fix utils import path in healer.test.ts
2025-04-19 11:57:03 +00:00
Sirz Benjie
54ce58411b
[Bug] Fix forced switch bugs in enemy partner trainer battles ( #5644 )
...
* Add isPartner method to trainer class
* Ensure force switches cannot pull pokemon from the wrong trainer
* Add override for battle type
* Fixup tests and broken assumptions
* Make move fail override semi-invuln check
Bandaid fix because move effect phase does not allow for the move to fail if all of its conditions fail
* Restore overrides
* Apply kev's suggestions from code review
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Fix illusion test battle type invocation
* Update struggle and healer tests to use battleStyle
---------
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-04-18 09:35:46 +00:00
NightKev
6f56dce771
[Biome] Add and apply lint/style/noNamespaceImport ( #5650 )
...
* Add `lint/style/noNamespaceImport` Biome rule
* Apply Biome rule, add exception for `*.test.ts` files
2025-04-12 01:31:56 -04:00
Sirz Benjie
787feceb14
[Refactor] Refactor variant sprite code part 1 ( #5592 )
...
* Move exp to its own masterlist, simplify initVariantData
* Update test/sprites/pokemonSprite.test.ts
* Extract loadPokemonVariantAssets out of BattleScene
* move variant.ts and update pokemon.loadAssets
* Add fuzzy matching for applying variant recolors
* Move glsl shaders to their own files
* Remove extra variants from shader masterlist
Their exp sprites have since been removed.
Co-authored-by: Unicorn_Power <189861924+Unicornpowerstar@users.noreply.github.com>
* Make exp sprite keys a set instead of an array
* Remove outdated exp sprite jsons
Co-authored-by: Unicorn_Power <189861924+Unicornpowerstar@users.noreply.github.com>
---------
Co-authored-by: Unicorn_Power <189861924+Unicornpowerstar@users.noreply.github.com>
2025-04-09 10:43:05 -05:00
Sirz Benjie
408b66f913
[Misc][Refactor][GitHub] Ditch eslint for biome, and add a formatter ( #5495 )
...
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-03-09 14:13:25 -07:00
Sirz Benjie
60a4db7059
[Refactor] Refactor moves.ts part 1 ( #5420 )
2025-03-07 19:10:29 -06:00
David Yang
6181afc6d2
[UI/UX] Make left button also go back to run history from run info ( #5474 )
2025-03-04 00:40:04 +00:00
Xavion3
90d32b886c
[Feature] Tera Rework ( #5233 )
...
* Commit old stashed changes
* Complete basic implementation of Tera
* Fix effectiveness test
* Make tera retain until forced recall or faint, regain on biome change
* Experimental sparkle fix
* Fix champion teras
* Attempted fix for double battles tera UI bug
* Fix the fix
* Fix linting and test issues
* Fix more tests
* Change int type
* Implement tera for ME trainers
* Cleanup species inclusivity check
* Make tera instant recharge if terapagos in party
* Make useless tera shards not generate
* Implement stellar tera damage boost
* Improve tera selection UI
* Tidy up animation and localisation
* Improve tera button sprite
* Fix Lance tera
* Make tera instant recharge during E4 in classic modes.
* Fix formatting in the tera common animation
The animation was also not playing due to `frameTimedEvents` being missing as well.
* Make tera effect start after animation
* Implement save migration
* Update version number for migration code
---------
Co-authored-by: Madmadness65 <blaze.the.fireman@gmail.com>
Co-authored-by: Madmadness65 <59298170+Madmadness65@users.noreply.github.com>
2025-02-16 16:20:50 -05:00
Wlowscha
8d043a9f55
[Refactor] Replace all instances of integer with number ( #5250 )
...
* Replaced instances of "integer" with "number"
2025-02-04 17:56:13 -07:00
NightKev
0107b1d47e
[Refactor] Create global scene variable ( #4766 )
...
* Replace various `scene` pass-arounds with global scene variable
* Modify tests
* Add scene back to `fade[in|out]()` calls
Co-authored-by: Moka <54149968+MokaStitcher@users.noreply.github.com>
* Fix Bug Superfan ME test
Co-authored-by: Moka <54149968+MokaStitcher@users.noreply.github.com>
* Re-enable fixed test
Co-authored-by: Moka <54149968+MokaStitcher@users.noreply.github.com>
* Rename `gScene` to `globalScene`
* Move `globalScene` to its own file to fix import/async issues
* Fix `SelectModifierPhase` tests
* Fix ME tests by removing `scene` from `expect()`s
* Resolve merge issues
* Remove tsdocs referencing `scene` params
Remove missed instances of `.scene`
* Remove unnecessary `globalScene` usage in `loading-scene.ts`
* Fix merge conflicts
* Attempt to fix circular import issue
* Found the source of the import issue
* Fix merge issues
---------
Co-authored-by: Moka <54149968+MokaStitcher@users.noreply.github.com>
2025-01-12 15:33:05 -08:00
Mumble
2b59a53285
[Bug][UI] Fixes to Run History Logging ( #4716 )
...
* new function
* weak attempt of documentation
* mysterious chest handled...? maybe.
* override comments
* one more instruction
* fixing up the logging lol
* lah
* fixing it up
* coommrent
* lalal
* run info fixes
* Addressed PigeonBar's comments
* Centered run info text + fixed trainer sprites.
* Fixed function name.
* Update tsdoc in `overrides.ts`
Co-authored-by: Moka <54149968+MokaStitcher@users.noreply.github.com>
* Fix tsdoc comment
* sligthly rewrite centering of biome and wave text in run info
---------
Co-authored-by: frutescens <info@laptop>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: Moka <54149968+MokaStitcher@users.noreply.github.com>
Co-authored-by: Moka <millennium.stitcher@gmail.com>
2024-12-01 19:48:43 +01:00
Moka
ae8efeedf8
[UI] Make ME text legible when using the legacy UI theme ( #4847 )
2024-11-16 23:34:14 +00:00
NightKev
00f7fd47df
[Refactor] Remove unnecessary re-exports ( #4818 )
...
* Remove unnecessary re-exports
* Move `Type` enum to `src/enums/type.ts`
* Remove import style change from `modifier-type.ts`
2024-11-08 17:44:34 -05:00
Lugiad
abc9264b3d
[Localization] Spanish modification form es to es-ES ( #4753 )
...
* Update and rename statuses_es.json to statuses_es-ES.json
* Rename statuses_es.png to statuses_es-ES.png
* Update and rename types_es.json to types_es-ES.json
* Rename types_es.png to types_es-ES.png
* Update i18n.ts
* Update settings.ts
* Update settings-display-ui-handler.ts
* Update starter-select-ui-handler.ts
* Update utils.ts
* Update settings-display-ui-handler.ts
* Update loading-scene.ts
* Update timed-event-manager.ts
* change remaining 'es' to 'es-ES' in various UIs
* change halloween event banner from es to es-ES
* update to latest locale commit
---------
Co-authored-by: Moka <54149968+MokaStitcher@users.noreply.github.com>
2024-10-31 21:54:05 +01:00
NightKev
39abac65be
Add eslint rule to enforce indenting of case statements ( #4692 )
2024-10-20 02:44:36 +01:00
Mumble
d01d856898
[Refactor] Default case to display challenge name ( #4656 )
...
Co-authored-by: frutescens <info@laptop>
2024-10-15 10:05:21 -04:00
Mumble
ffe941d235
[Feature][UI] Save Preview ( #4410 )
...
* Making 3 Option UI real
* idk anymore
* Revert "Making 3 Option UI real"
This reverts commit beaad44c1e
2024-10-09 15:04:13 -04:00
torranx
644c078a6c
add new lint rules....again
2024-10-04 13:08:31 +08:00
ImperialSympathizer
23f006bc43
[Enhancement] Remove unnecessary loading of trainer sprites in loading scene ( #4397 )
...
* Remove unnecessary loading of trainer sprites in loading scene
* load trainer assets on demand for run history UI
---------
Co-authored-by: ImperialSympathizer <imperialsympathizer@gmail.com>
2024-09-23 17:34:47 -04:00
MokaStitcher
4feb45f532
[P3Bug][UI] Fix run history scrolling and other small bugs ( #4326 )
2024-09-20 10:19:45 -04:00
Mumble
c4d5c923fc
[Bug] Run History Not Saving Correctly ( #4248 )
...
* Fix - need to test though
* New Line for Personal Best
* Run History basic Interpretation
* Stray console log
* Added personal best message fix
* argh
* removed a stray log
---------
Co-authored-by: frutescens <info@laptop>
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
2024-09-19 10:42:29 -04:00
Mumble
c76827156c
[P3 Bug] Run Result 'Victory!' Text not displaying correctly in Legacy UI Mode ( #4223 )
...
* idk what happened to legacy-summary:x
* Let's change it up.
---------
Co-authored-by: frutescens <info@laptop>
2024-09-13 22:13:47 -04:00
Mumble
f294f034aa
[Bug] Run History displays Pokemon that have their natures changed during the run ( #4149 )
...
* Nature mints... spaghetti...
* Update src/ui/run-info-ui-handler.ts
Co-authored-by: MokaStitcher <54149968+MokaStitcher@users.noreply.github.com>
* No effect when no items
---------
Co-authored-by: frutescens <info@laptop>
Co-authored-by: MokaStitcher <54149968+MokaStitcher@users.noreply.github.com>
2024-09-11 21:00:26 -04:00
Leo Kim
e657322294
[Enhancement] Update instruction for gamepad in run history UI ( #4053 )
...
* update instruction for pad in run history UI
* move getGamepadType function to ui.ts
* Update src/ui/ui.ts
Co-authored-by: Adrian T. <68144167+torranx@users.noreply.github.com>
---------
Co-authored-by: Adrian T. <68144167+torranx@users.noreply.github.com>
2024-09-10 23:45:53 -04:00
flx-sta
2bd07cb84e
fix and optimize imports ( #4061 )
...
- remove any `.js` extension imports
- remove unncessary dynamic imports of `modifier.ts` file. The file was being imported statically & dynamically. Made it pure static
- increase vite chunk-size warning limit
Co-authored-by: Mumble <171087428+frutescens@users.noreply.github.com>
2024-09-07 21:37:37 -07:00
Mumble
deb4e9dd24
[UI] Run history fixes and improvements ( #3987 )
...
* Challenge Rules Word Wrap
* Fixed Modifiers
* Fixed item count color.
* removed .js endings
---------
Co-authored-by: frutescens <info@laptop>
2024-09-02 22:14:09 -04:00
Leo Kim
c112abbcd2
[Challenge] Inverse battle challenge ( #3525 )
...
* add inverse battle challenge. refactoring type.ts for inverse battle challenge
* update type integer -> number
* add inverse battle condition to thunder wave, conversion 2.
* add inverse_battle test code, add checking gameMode in runToSummon not to overwrite gameMode to CLASSIC always
* update startBattle with isClassicMode default = true
* add inverse achievement
* fix achv validation condition
* remove unnecessary new line
* update defaultWidth 160 -> 200
* update locales
* fix korean translation
* fix korean translation2
* Update src/locales/de/achv.ts
Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>
* Update src/locales/de/challenges.ts
Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>
* Update src/locales/de/challenges.ts
Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>
* resize challenge description 96 -> 84
* update challenge select UI size.
* revert font size to 84. update de translation
* Update src/locales/fr/challenges.ts
Co-authored-by: Lugiad' <adrien.grivel@hotmail.fr>
* Update src/locales/fr/achv.ts
Co-authored-by: Lugiad' <adrien.grivel@hotmail.fr>
* Update src/locales/es/challenges.ts
Co-authored-by: Asdar <asdargmng@gmail.com>
* Update src/locales/fr/challenges.ts
Co-authored-by: Lugiad' <adrien.grivel@hotmail.fr>
* Update src/locales/fr/achv.ts
Co-authored-by: Lugiad' <adrien.grivel@hotmail.fr>
* Update src/locales/es/achv.ts
Co-authored-by: Asdar <asdargmng@gmail.com>
* Update src/locales/fr/achv.ts
Co-authored-by: Lugiad' <adrien.grivel@hotmail.fr>
* shrink de font size on achivement
* set middle align to achv title
* Update src/locales/zh_CN/achv.ts
Co-authored-by: mercurius-00 <80205689+mercurius-00@users.noreply.github.com>
* Update src/locales/zh_TW/achv.ts
Co-authored-by: mercurius-00 <80205689+mercurius-00@users.noreply.github.com>
* Update src/locales/zh_CN/challenges.ts
Co-authored-by: mercurius-00 <80205689+mercurius-00@users.noreply.github.com>
* Update src/locales/zh_TW/challenges.ts
Co-authored-by: mercurius-00 <80205689+mercurius-00@users.noreply.github.com>
* fix zh_TW ahiv.ts
* fix import code on inverse battle test for updated phase
* Update src/data/type.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* update requested changes
* Update src/locales/pt_BR/achv.ts
Co-authored-by: José Ricardo Fleury Oliveira <josefleury@discente.ufg.br>
* Update src/locales/pt_BR/achv.ts
Co-authored-by: José Ricardo Fleury Oliveira <josefleury@discente.ufg.br>
* Update src/locales/pt_BR/challenges.ts
Co-authored-by: José Ricardo Fleury Oliveira <josefleury@discente.ufg.br>
* [draft] update inverse battle apply function
* change the way how to use applyChallenge for inverse type
* resolve confilct
* fix test codes
* remove unnecessary multiplier variable and break codes
* update getTypeDamageMultiplier argument type from `number` to `Type`
* Fix inverse types tests (#1 )
* Fix Inverse Battle tests
* Add timeout parameter to tests
* update requested changes
* update requested changes
* update requested changes2
* update comments
* Update src/test/utils/helpers/challengeModeHelper.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Update src/test/utils/helpers/challengeModeHelper.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* fix mis pasted code
* revert loadChallenge code for FreshStartChallenge
* code refactoring
* restore challenge.json lost translations
* revert UI changes
* revert unreverted newlines
* Run History inclusion
* requested changes from torranx
* update WaterSuperEffectTypeMultiplierAttr for inverse battle matchup.
* fix test code. adding flying press test code
* update requested change from xavion3
* updated requested change from xavion 2
* update requested changes from xavion 3
* remove exception code which is not valid
* attach partial mark to Freeze dry. requested by xavion
* add missing game over phase code when we delete old phases.ts
* fix test codes
* merge conflict
* fix achv condition
* updated achv block condition. we don't want to change desc now
* resolve conflict
* Eternatus Moveset Tinkering
* Cleaning it up
---------
Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>
Co-authored-by: Lugiad' <adrien.grivel@hotmail.fr>
Co-authored-by: Asdar <asdargmng@gmail.com>
Co-authored-by: mercurius-00 <80205689+mercurius-00@users.noreply.github.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: José Ricardo Fleury Oliveira <josefleury@discente.ufg.br>
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
Co-authored-by: frutescens <info@laptop>
2024-08-29 19:59:33 +01:00
flx-sta
af918975a8
adapt gender context logic to run-history ( #3881 )
2024-08-29 09:25:45 -07:00
Mumble
f6551efc36
[Bug] Run History Day 1 patch ( #3715 )
...
* Money Display Fix + Partially localized import data
* Fixed Japanese text.
---------
Co-authored-by: frutescens <info@laptop>
2024-08-25 00:03:28 +01:00
Mumble
c5a66326dd
[QoL][Feature] Hall of Fame + Run History ( #3251 )
...
* Fixed SaveSessionData issue + Added loss details + removed Modifiers
* Final changes
* Updated code with the current repo + mode localization
* Final touches before moving to a clean branch
* Manual merging
* Some more merging + updating
* Fixed import
* TypeDocs issues
* Fixed relevant typedoc issues
* Manual merge
* More fixes
* So many commits for so little
* Localization Updates
* Very barebones implementation of 'favorite' runs - not planning to implement any time soon though
* menu-ui-handler.ts localizations
* Update src/locales/ko/run-history-ui-handler.ts
Thank you!
Co-authored-by: Enoch <enoch.jwsong@gmail.com>
* Update src/locales/de/run-history-ui-handler.ts
Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>
* Update src/locales/de/menu-ui-handler.ts
Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>
* The German name for Squirtle is silly
* Fixed Run-Entry Def
* Commented out networking functionality
* Commenting out network functionality pt2
* Update src/locales/pt_BR/menu-ui-handler.ts
Co-authored-by: José Ricardo Fleury Oliveira <josefleury@discente.ufg.br>
* Update src/locales/pt_BR/run-history-ui-handler.ts
Co-authored-by: José Ricardo Fleury Oliveira <josefleury@discente.ufg.br>
* Update src/locales/ko/menu-ui-handler.ts
Co-authored-by: Enoch <enoch.jwsong@gmail.com>
* Update src/locales/zh_CN/menu-ui-handler.ts
Co-authored-by: Yonmaru40 <47717431+40chyan@users.noreply.github.com>
* Update src/locales/zh_CN/run-history-ui-handler.ts
Co-authored-by: Yonmaru40 <47717431+40chyan@users.noreply.github.com>
* Update src/locales/fr/menu-ui-handler.ts
Co-authored-by: Lugiad' <adrien.grivel@hotmail.fr>
* Update src/locales/fr/run-history-ui-handler.ts
Co-authored-by: Lugiad' <adrien.grivel@hotmail.fr>
* Update src/locales/it/menu-ui-handler.ts
Co-authored-by: Niccolò <123510358+NicusPulcis@users.noreply.github.com>
* Update src/locales/it/run-history-ui-handler.ts
Co-authored-by: Niccolò <123510358+NicusPulcis@users.noreply.github.com>
* Update src/locales/fr/run-history-ui-handler.ts
Co-authored-by: Lugiad' <adrien.grivel@hotmail.fr>
* Update src/locales/de/run-history-ui-handler.ts
Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>
* Update src/locales/de/run-history-ui-handler.ts
Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>
* Update src/locales/de/run-history-ui-handler.ts
Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>
* Fixed SaveSessionData issue + Added loss details + removed Modifiers
* Final changes
* Updated code with the current repo + mode localization
* Final touches before moving to a clean branch
* Manual merging
* Some more merging + updating
* Fixed import
* TypeDocs issues
* Fixed relevant typedoc issues
* Manual merge
* More fixes
* So many commits for so little
* Localization Updates
* Very barebones implementation of 'favorite' runs - not planning to implement any time soon though
* menu-ui-handler.ts localizations
* Update src/locales/ko/run-history-ui-handler.ts
Thank you!
Co-authored-by: Enoch <enoch.jwsong@gmail.com>
* Update src/locales/de/run-history-ui-handler.ts
Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>
* Update src/locales/de/menu-ui-handler.ts
Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>
* The German name for Squirtle is silly
* Fixed Run-Entry Def
* Commented out networking functionality
* Commenting out network functionality pt2
* Fixed cursor-close out freeze and replaced hall of fame background
* Removed console.log
* Fixed cursor freeze bug + changed hall of fame background
* cursor freeze bug fix pt 2
* Revert "Disable egg gacha in rewards (#3304 )"
This reverts commit 3a87c8657fhttps://github.com/pagefaultgames/pokerogue into runHistoryNew"
This reverts commit 5c6fcf6ec4751bf4a433https://github.com/pagefaultgames/pokerogue into runHistoryNew""
This reverts commit f6c3580ad0
2024-08-23 19:23:16 +01:00
