mika/pokerogue
1
0
Fork 0
mirror of https://github.com/pagefaultgames/pokerogue.git synced 2025-07-27 10:42:25 +02:00
Code Issues Packages Projects Releases Wiki Activity

Updating logging for missing animations

Browse Source
This commit is contained in:
podar 2024-09-16 15:41:58 -05:00
parent 6db0cc8d08
commit f4d9620738
1 changed files with 18 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/data/battle-anims.ts
View File

@ -494,7 +494,8 @@ export function initMoveAnim(scene: BattleScene, move: Moves): Promise<void> {
.then(response => { .then(response => {
const contentType = response.headers.get("content-type"); const contentType = response.headers.get("content-type");
if (!response.ok || contentType?.indexOf("application/json") === -1) { if (!response.ok || contentType?.indexOf("application/json") === -1) {
useAndLogDefaultAnim(move, defaultMoveAnim, response.status, response.statusText); useDefaultAnim(move, defaultMoveAnim);
logMissingMoveAnim(move, response.status, response.statusText)
return resolve(); return resolve();
} }
return response.json(); return response.json();
@ -516,7 +517,8 @@ export function initMoveAnim(scene: BattleScene, move: Moves): Promise<void> {
} }
}) })
.catch(error => { .catch(error => {
useAndLogDefaultAnim(move, defaultMoveAnim, error); useDefaultAnim(move, defaultMoveAnim);
logMissingMoveAnim(move, error)
return resolve(); return resolve();
}); });
}; };
@ -530,14 +532,24 @@ export function initMoveAnim(scene: BattleScene, move: Moves): Promise<void> {
* *
* @param move the move to populate an animation for * @param move the move to populate an animation for
* @param defaultMoveAnim the default move to use as the default animation * @param defaultMoveAnim the default move to use as the default animation
* @param optionalParams parameters to add to the error logging
*/ */
function useAndLogDefaultAnim(move: Moves, defaultMoveAnim: Moves, ...optionalParams: any[]) { function useDefaultAnim(move: Moves, defaultMoveAnim: Moves) {
const moveName = Utils.animationFileName(move);
console.error(`Could not load animation file for move '${moveName}'`, ...optionalParams);
populateMoveAnim(move, moveAnims.get(defaultMoveAnim)); populateMoveAnim(move, moveAnims.get(defaultMoveAnim));
} }
/**
* Helper method to call when an move animation is missing.
*
* @param move the move to populate an animation for
* @param optionalParams parameters to add to the error logging
*
* @remarks use {@link useDefaultAnim} to use a default animation
*/
function logMissingMoveAnim(move: Moves, ...optionalParams: any[]) {
const moveName = Utils.animationFileName(move);
console.warn(`Could not load animation file for move '${moveName}'`, ...optionalParams);
}
/** /**
* Fetches animation configs to be used in a Mystery Encounter * Fetches animation configs to be used in a Mystery Encounter
* @param scene * @param scene