mika/pokerogue
1
0
Fork 0
mirror of https://github.com/pagefaultgames/pokerogue.git synced 2025-08-24 08:19:33 +02:00
Code Issues Packages Projects Releases Wiki Activity

chore: apply review suggestions

Browse Source 
by @torranx
This commit is contained in:
flx-sta 2024-09-30 17:26:21 -07:00
parent cea3a5f01d
commit ee126fc8d4
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/modifier/modifier.ts
View File

@ -481,12 +481,12 @@ export class TempStatStageBoosterModifier extends LapsingPersistentModifier {
/** /**
* Checks if {@linkcode args} contains the necessary elements and if the * Checks if {@linkcode args} contains the necessary elements and if the
* incoming stat is matches {@linkcode stat}. * incoming stat is matches {@linkcode stat}.
* @param tempBattleStat {@linkcode TempBattleStat} N/A * @param tempBattleStat {@linkcode TempBattleStat} being affected
* @param statLevel {@linkcode Utils.NumberHolder} that holds the resulting value of the stat stage multiplier * @param statLevel {@linkcode Utils.NumberHolder} that holds the resulting value of the stat stage multiplier
* @returns `true` if the modifier can be applied, false otherwise * @returns `true` if the modifier can be applied, false otherwise
*/ */
override shouldApply(tempBattleStat?: TempBattleStat, statLevel?: Utils.NumberHolder): boolean { override shouldApply(tempBattleStat?: TempBattleStat, statLevel?: Utils.NumberHolder): boolean {
return !!tempBattleStat && !!statLevel && TEMP_BATTLE_STATS.includes(tempBattleStat) && (tempBattleStat === this.stat) && (statLevel instanceof Utils.NumberHolder); return !!tempBattleStat && !!statLevel && TEMP_BATTLE_STATS.includes(tempBattleStat) && (tempBattleStat === this.stat);
} }
/** /**
@ -521,11 +521,11 @@ export class TempCritBoosterModifier extends LapsingPersistentModifier {
/** /**
* Checks if {@linkcode args} contains the necessary elements. * Checks if {@linkcode args} contains the necessary elements.
* @param critLevel {@linkcode Utils.NumberHolder} N/A * @param critLevel {@linkcode Utils.NumberHolder} that holds the resulting critical-hit level
* @returns `true` if the critical-hit stage boost applies successfully * @returns `true` if the critical-hit stage boost applies successfully
*/ */
override shouldApply(critLevel?: Utils.NumberHolder): boolean { override shouldApply(critLevel?: Utils.NumberHolder): boolean {
return !!critLevel && (critLevel instanceof Utils.NumberHolder); return !!critLevel;
} }
/** /**