From edeb116ead3105cba8b22b5ec096c0e4a4560541 Mon Sep 17 00:00:00 2001 From: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com> Date: Fri, 22 Aug 2025 15:27:55 -0500 Subject: [PATCH] [Bug] Ensure MEs disabled in a challenge mode only do so while challenge is active (#6337) * Ensure MEs disabled in a challenge mode only do so while challenge is active * Optimize checking disallowed challenges --- src/battle-scene.ts | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/src/battle-scene.ts b/src/battle-scene.ts index 4d3f190c02a..be02962867c 100644 --- a/src/battle-scene.ts +++ b/src/battle-scene.ts @@ -3684,15 +3684,8 @@ export class BattleScene extends SceneBase { ) { return false; } - if (this.gameMode.modeId === GameModes.CHALLENGE) { - const disallowedChallenges = encounterCandidate.disallowedChallenges; - if ( - disallowedChallenges && - disallowedChallenges.length > 0 && - this.gameMode.challenges.some(challenge => disallowedChallenges.includes(challenge.id)) - ) { - return false; - } + if (encounterCandidate.disallowedChallenges?.some(challenge => this.gameMode.hasChallenge(challenge))) { + return false; } if (!encounterCandidate.meetsRequirements()) { return false;