mika/pokerogue
1
0
Fork 0
mirror of https://github.com/pagefaultgames/pokerogue.git synced 2025-08-20 22:39:31 +02:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
This commit is contained in:
innerthunder 2024-10-23 13:28:35 -07:00 committed by GitHub
parent c6f401cf04
commit e4f2d00a4f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/data/move.ts
View File

@ -985,7 +985,7 @@ interface MoveEffectAttrOptions {
export class MoveEffectAttr extends MoveAttr { export class MoveEffectAttr extends MoveAttr {
/** /**
* Defines when this effect should trigger in the move's effect order * Defines when this effect should trigger in the move's effect order
* @see {@linkcode phases.MoveEffectPhase.start} * @see {@linkcode MoveEffectPhase}
*/ */
public trigger: MoveEffectTrigger; public trigger: MoveEffectTrigger;
/** /**
@ -1002,7 +1002,8 @@ export class MoveEffectAttr extends MoveAttr {
/** /**
* `true` if this effect should only trigger on the first hit of * `true` if this effect should only trigger on the first hit of
* multi-hit moves. Defaults to `false`. * multi-hit moves.
* @default false
*/ */
public get firstHitOnly () { public get firstHitOnly () {
return this.options?.firstHitOnly ?? false; return this.options?.firstHitOnly ?? false;
@ -1010,7 +1011,8 @@ export class MoveEffectAttr extends MoveAttr {
/** /**
* `true` if this effect should only trigger on the last hit of * `true` if this effect should only trigger on the last hit of
* multi-hit moves. Defaults to `false`. * multi-hit moves.
* @default false
*/ */
public get lastHitOnly () { public get lastHitOnly () {
return this.options?.lastHitOnly ?? false; return this.options?.lastHitOnly ?? false;
@ -1019,7 +1021,7 @@ export class MoveEffectAttr extends MoveAttr {
/** /**
* `true` if this effect should apply only upon hitting a target * `true` if this effect should apply only upon hitting a target
* for the first time when targeting multiple {@linkcode Pokemon}. * for the first time when targeting multiple {@linkcode Pokemon}.
* Defaults to `false`. * @default false
*/ */
public get firstTargetOnly () { public get firstTargetOnly () {
return this.options?.firstTargetOnly ?? false; return this.options?.firstTargetOnly ?? false;
@ -2839,14 +2841,14 @@ interface StatStageChangeAttrOptions extends MoveEffectAttrOptions {
*/ */
export class StatStageChangeAttr extends MoveEffectAttr { export class StatStageChangeAttr extends MoveEffectAttr {
public stats: BattleStat[]; public stats: BattleStat[];
public stages: integer; public stages: number;
/** /**
* Container for optional parameters to this attribute. * Container for optional parameters to this attribute.
* @see {@linkcode StatStageChangeAttrOptions} for available optional params * @see {@linkcode StatStageChangeAttrOptions} for available optional params
*/ */
protected override options?: StatStageChangeAttrOptions; protected override options?: StatStageChangeAttrOptions;
constructor(stats: BattleStat[], stages: integer, selfTarget?: boolean, moveEffectTrigger: MoveEffectTrigger = MoveEffectTrigger.HIT, options?: StatStageChangeAttrOptions) { constructor(stats: BattleStat[], stages: number, selfTarget?: boolean, moveEffectTrigger: MoveEffectTrigger = MoveEffectTrigger.HIT, options?: StatStageChangeAttrOptions) {
super(selfTarget, moveEffectTrigger, options); super(selfTarget, moveEffectTrigger, options);
this.stats = stats; this.stats = stats;
this.stages = stages; this.stages = stages;
@ -2863,7 +2865,7 @@ export class StatStageChangeAttr extends MoveEffectAttr {
/** /**
* `true` to display a message for the stat change. * `true` to display a message for the stat change.
* Defaults to `true`. * @default true
*/ */
private get showMessage () { private get showMessage () {
return this.options?.showMessage ?? true; return this.options?.showMessage ?? true;