mika/pokerogue
1
0
Fork 0
mirror of https://github.com/pagefaultgames/pokerogue.git synced 2025-07-14 04:12:18 +02:00
Code Issues Packages Projects Releases Wiki Activity

Added fixes for the Review by TempsRay.

Browse Source
This commit is contained in:
Jannik Tappert 2024-05-14 22:48:41 +02:00
parent 08a5da0f8b
commit e28b1bdc5d
1 changed files with 16 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
src/data/move.ts
View File

@ -741,19 +741,20 @@ export class RecoilAttr extends MoveEffectAttr {
/** /**
* Attribute used for moves which self KO the user regardless if the move hits a target * Attribute used for moves which self KO the user regardless if the move hits a target
* */ **/
export class SacrificialAttr extends MoveEffectAttr { export class SacrificialAttr extends MoveEffectAttr {
constructor() { constructor() {
super(true, MoveEffectTrigger.PRE_APPLY); super(true, MoveEffectTrigger.PRE_APPLY);
} }
/** /**
* Applies the sacrificial effect to the user * Deals damage to the user equal to their current hp
* @param user Pokemon that used the move * @param user Pokemon that used the move
* @param target The target of the move * @param target The target of the move
* @param move Move with this attribute * @param move Move with this attribute
* @param args N/A * @param args N/A
*/ * @returns true if the function succeeds
**/
apply(user: Pokemon, target: Pokemon, move: Move, args: any[]): boolean { apply(user: Pokemon, target: Pokemon, move: Move, args: any[]): boolean {
user.damageAndUpdate(user.hp, HitResult.OTHER, false, true, true); user.damageAndUpdate(user.hp, HitResult.OTHER, false, true, true);
user.turnData.damageTaken += user.hp; user.turnData.damageTaken += user.hp;
@ -762,10 +763,11 @@ export class SacrificialAttr extends MoveEffectAttr {
} }
/** /**
* * The AI is calculating how beneficial it is to use this move. Bosses will always return -20. Otherwise, the score is calculated based on the user's current hp ratio and the move's type effectiveness against the user
* @param user Pokemon that used the move * @param user Pokemon that used the move
* @param target The target of the move * @param target The target of the move
* @param move Move with this attribute * @param move Move with this attribute
* @returns The benefit score of using this move (how likely the AI is to use this move)
*/ */
getUserBenefitScore(user: Pokemon, target: Pokemon, move: Move): integer { getUserBenefitScore(user: Pokemon, target: Pokemon, move: Move): integer {
if (user.isBoss()) if (user.isBoss())
@ -783,15 +785,16 @@ export class SacrificialAttrOnHit extends MoveEffectAttr {
} }
/** /**
* Applies the sacrificial effect to the user * Deals damage to the user equal to their current hp
* @param user Pokemon that used the move * @param user Pokemon that used the move
* @param target The target of the move * @param target The target of the move
* @param move Move with this attribute * @param move Move with this attribute
* @param args N/A * @param args N/A
* @returns true if the function succeeds
*/ */
apply(user: Pokemon, target: Pokemon, move: Move, args: any[]): boolean { apply(user: Pokemon, target: Pokemon, move: Move, args: any[]): boolean {
// If the move hits a target, the user will self KO // If the move fails to hit a target, then the user does not faint and the function returns false
if (!super.apply(user, target, move, args)) if (!super.apply(user, target, move, args))
return false; return false;
@ -802,10 +805,11 @@ export class SacrificialAttrOnHit extends MoveEffectAttr {
} }
/** /**
* * The AI is calculating how beneficial it is to use this move. Bosses will always return -20. Otherwise, the score is calculated based on the user's current hp ratio and the move's type effectiveness against the user
* @param user Pokemon that used the move * @param user Pokemon that used the move
* @param target The target of the move * @param target The target of the move
* @param move Move with this attribute * @param move Move with this attribute
* @returns The benefit score of using this move (how likely the AI is to use this move)
*/ */
getUserBenefitScore(user: Pokemon, target: Pokemon, move: Move): integer { getUserBenefitScore(user: Pokemon, target: Pokemon, move: Move): integer {
if (user.isBoss()) if (user.isBoss())