mika/pokerogue
1
0
Fork 0
mirror of https://github.com/pagefaultgames/pokerogue.git synced 2025-07-18 22:32:32 +02:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from kev's review

Browse Source 
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
This commit is contained in:
Sirz Benjie 2025-03-15 23:06:20 -04:00
parent 6e3c95ccf8
commit e2628aa60c
No known key found for this signature in database
GPG Key ID: 4A524B4D196C759E
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
.github/workflows/tests.yml vendored
View File

@ -12,7 +12,7 @@ on:
# src and test files # src and test files
- "src/**" - "src/**"
- "test/**" - "test/**"
- "public/**" # PLEASE REVIEW -- Does it make sense to include this? Can modifying these break tests? (REMOVE COMMENT AFTER REVIEW) - "public/**"
# Workflows that can impact tests # Workflows that can impact tests
- ".github/workflows/test*.yml" - ".github/workflows/test*.yml"
# top-level files # top-level files
@ -21,7 +21,7 @@ on:
- "vite.*.ts" # vite.config.ts, vite.vitest.config.ts, vitest.workspace.ts - "vite.*.ts" # vite.config.ts, vite.vitest.config.ts, vitest.workspace.ts
- "tsconfig*.json" # tsconfig.json tweaking can impact compilation - "tsconfig*.json" # tsconfig.json tweaking can impact compilation
- "global.d.ts" # I think this can impact tests? (REMOVE COMMENT AFTER REVIEW) - "global.d.ts" # I think this can impact tests? (REMOVE COMMENT AFTER REVIEW)
- ".env.*" # PLEASE REVIEW -- can these impact test behavior? - ".env.*"
# Blanket negations for files that cannot impact tests # Blanket negations for files that cannot impact tests
- "!**/*.py" # No .py files - "!**/*.py" # No .py files
- "!**/*.sh" # No .sh files - "!**/*.sh" # No .sh files
@ -38,7 +38,7 @@ on:
# src and test files # src and test files
- "src/**" - "src/**"
- "test/**" - "test/**"
- "public/**" # PLEASE REVIEW -- Does it make sense to include this? Can modifying these break tests? (REMOVE COMMENT AFTER REVIEW) - "public/**"
# Workflows that can impact tests # Workflows that can impact tests
- ".github/workflows/test*.yml" - ".github/workflows/test*.yml"
# top-level files # top-level files
@ -47,13 +47,13 @@ on:
- "vite*" # vite.config.ts, vite.vitest.config.ts, vitest.workspace.ts - "vite*" # vite.config.ts, vite.vitest.config.ts, vitest.workspace.ts
- "tsconfig*.json" # tsconfig.json tweaking can impact compilation - "tsconfig*.json" # tsconfig.json tweaking can impact compilation
- "global.d.ts" # I think this can impact tests? (REMOVE COMMENT AFTER REVIEW) - "global.d.ts" # I think this can impact tests? (REMOVE COMMENT AFTER REVIEW)
- ".env.*" # PLEASE REVIEW -- can these impact test behavior? - ".env.*"
# Blanket negations for files that cannot impact tests # Blanket negations for files that cannot impact tests
- "!**/*.py" # No .py files - "!**/*.py" # No .py files
- "!**/*.sh" # No .sh files - "!**/*.sh" # No .sh files
- "!**/*.md" # No .md files - "!**/*.md" # No .md files
- "!**/*.png" # TODO: Can the deletion of these files break tests? (REMOVE COMMENT AFTER REVIEW) - "!**/*.png"
- "!**/*.jpg" # TODO: Can the deletion of these files break tests? (REMOVE COMMENT AFTER REVIEW) - "!**/*.jpg"
- "!**/.git*" # .gitkeep and family - "!**/.git*" # .gitkeep and family
merge_group: merge_group:
types: [checks_requested] types: [checks_requested]