mika/pokerogue
1
0
Fork 0
mirror of https://github.com/pagefaultgames/pokerogue.git synced 2025-08-07 07:59:26 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix behavior of ally-targeting moves during sleep

Browse Source
This commit is contained in:
Acelynn Zhang 2025-07-28 16:16:15 -04:00
parent 10b9cfcdb0
commit e20d7047f7
2 changed files with 45 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/phases/move-phase.ts
View File

@ -122,14 +122,8 @@ export class MovePhase extends BattlePhase {
console.log(MoveId[this.move.moveId], enumValueToKey(MoveUseMode, this.useMode)); console.log(MoveId[this.move.moveId], enumValueToKey(MoveUseMode, this.useMode));
// Check if move is unusable (e.g. running out of PP due to a mid-turn Spite if (!this.pokemon.isActive(true)) {
// or the user no longer being on field), ending the phase early if not. this.cancel();
if (!this.canMove(true)) {
if (this.pokemon.isActive(true)) {
this.fail();
this.showMoveText();
this.showFailedText();
}
this.end(); this.end();
return; return;
} }
@ -157,6 +151,7 @@ export class MovePhase extends BattlePhase {
this.resolveCounterAttackTarget(); this.resolveCounterAttackTarget();
// Check status cancellation from sleep, freeze, etc.
this.resolvePreMoveStatusEffects(); this.resolvePreMoveStatusEffects();
this.lapsePreMoveAndMoveTags(); this.lapsePreMoveAndMoveTags();
@ -182,6 +177,18 @@ export class MovePhase extends BattlePhase {
const targets = this.getActiveTargetPokemon(); const targets = this.getActiveTargetPokemon();
const moveQueue = this.pokemon.getMoveQueue(); const moveQueue = this.pokemon.getMoveQueue();
// Check if move is unusable (e.g. running out of PP due to a mid-turn Spite
// or the user no longer being on field)
if (!this.canMove(true)) {
if (this.pokemon.isActive(true)) {
this.fail();
this.showMoveText();
this.showFailedText();
}
return;
}
if ( if (
(targets.length === 0 && !this.move.getMove().hasAttr("AddArenaTrapTagAttr")) || (targets.length === 0 && !this.move.getMove().hasAttr("AddArenaTrapTagAttr")) ||
(moveQueue.length > 0 && moveQueue[0].move === MoveId.NONE) (moveQueue.length > 0 && moveQueue[0].move === MoveId.NONE)

31
test/data/status-effect.test.ts
View File

@ -353,7 +353,7 @@ describe("Status Effects", () => {
beforeEach(() => { beforeEach(() => {
game = new GameManager(phaserGame); game = new GameManager(phaserGame);
game.override game.override
.moveset([MoveId.SPLASH]) .moveset([MoveId.SPLASH, MoveId.DRAGON_CHEER])
.ability(AbilityId.BALL_FETCH) .ability(AbilityId.BALL_FETCH)
.battleStyle("single") .battleStyle("single")
.criticalHits(false) .criticalHits(false)
@ -390,6 +390,35 @@ describe("Status Effects", () => {
expect(player.status).toBeFalsy(); expect(player.status).toBeFalsy();
expect(player.getLastXMoves(1)[0].result).toBe(MoveResult.SUCCESS); expect(player.getLastXMoves(1)[0].result).toBe(MoveResult.SUCCESS);
}); });
it("Sleep turns should tick down when failing to use ally-targeting moves", async () => {
await game.classicMode.startBattle([SpeciesId.FEEBAS]);
const player = game.field.getPlayerPokemon();
player.status = new Status(StatusEffect.SLEEP, 0, 4);
game.move.select(MoveId.DRAGON_CHEER);
await game.toNextTurn();
expect(player.status.effect).toBe(StatusEffect.SLEEP);
game.move.select(MoveId.DRAGON_CHEER);
await game.toNextTurn();
expect(player.status.effect).toBe(StatusEffect.SLEEP);
game.move.select(MoveId.DRAGON_CHEER);
await game.toNextTurn();
expect(player.status.effect).toBe(StatusEffect.SLEEP);
expect(player.getLastXMoves(1)[0].result).toBe(MoveResult.FAIL);
game.move.select(MoveId.DRAGON_CHEER);
await game.toNextTurn();
expect(player.status).toBeFalsy();
expect(player.getLastXMoves(1)[0].result).toBe(MoveResult.FAIL);
});
}); });
describe("Behavior", () => { describe("Behavior", () => {