mika/pokerogue
1
0
Fork 0
mirror of https://github.com/pagefaultgames/pokerogue.git synced 2025-08-21 23:09:27 +02:00
Code Issues Packages Projects Releases Wiki Activity

[UI/UX] Save in starter select screen after moveset changes (#6287)

Browse Source 
* Save after moveset changes

* Saving only when the moveset is actually changed

* Removed logs, added docs

* Update src/ui/starter-select-ui-handler.ts

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
This commit is contained in:
Wlowscha 2025-08-20 22:57:13 +02:00 committed by GitHub
parent 6bdfb7eb31
commit d2e9615457
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/ui/starter-select-ui-handler.ts
View File

@ -401,6 +401,12 @@ export class StarterSelectUiHandler extends MessageUiHandler {
private starterPreferences: StarterPreferences; private starterPreferences: StarterPreferences;
/**
* Used to check whether any moves were swapped using the reorder menu, to decide
* whether a save should be performed or not.
*/
private hasSwappedMoves = false;
protected blockInput = false; protected blockInput = false;
constructor() { constructor() {
@ -1957,6 +1963,14 @@ export class StarterSelectUiHandler extends MessageUiHandler {
handler: () => { handler: () => {
this.moveInfoOverlay.clear(); this.moveInfoOverlay.clear();
this.clearText(); this.clearText();
// Only saved if moves were actually swapped
if (this.hasSwappedMoves) {
globalScene.gameData.saveSystem().then(success => {
if (!success) {
return globalScene.reset(true);
}
});
}
ui.setMode(UiMode.STARTER_SELECT); ui.setMode(UiMode.STARTER_SELECT);
return true; return true;
}, },
@ -1975,6 +1989,7 @@ export class StarterSelectUiHandler extends MessageUiHandler {
options.push({ options.push({
label: i18next.t("starterSelectUiHandler:manageMoves"), label: i18next.t("starterSelectUiHandler:manageMoves"),
handler: () => { handler: () => {
this.hasSwappedMoves = false;
showSwapOptions(this.starterMoveset!); // TODO: is this bang correct? showSwapOptions(this.starterMoveset!); // TODO: is this bang correct?
return true; return true;
}, },
@ -2724,8 +2739,8 @@ export class StarterSelectUiHandler extends MessageUiHandler {
} else { } else {
starterData.moveset = updatedMoveset; starterData.moveset = updatedMoveset;
} }
this.hasSwappedMoves = true;
this.setSpeciesDetails(this.lastSpecies, { forSeen: false }); this.setSpeciesDetails(this.lastSpecies, { forSeen: false });
this.updateSelectedStarterMoveset(speciesId); this.updateSelectedStarterMoveset(speciesId);
} }