mika/pokerogue
1
0
Fork 0
mirror of https://github.com/pagefaultgames/pokerogue.git synced 2025-06-30 13:33:01 +02:00
Code Issues Packages Projects Releases Wiki Activity

[Dev] Enable Biome linting of move-effect-phase.ts (#5947)

Browse Source
This commit is contained in:
NightKev 2025-06-06 23:09:23 -07:00 committed by GitHub
parent a818c2b33f
commit c5db827381
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
biome.jsonc
View File

@ -42,9 +42,6 @@
// TODO: Remove if we ever get down to 0 circular imports // TODO: Remove if we ever get down to 0 circular imports
"organizeImports": { "enabled": false }, "organizeImports": { "enabled": false },
"linter": { "linter": {
"ignore": [
"src/phases/move-effect-phase.ts" // TODO: unignore after move-effect-phase refactor
],
"enabled": true, "enabled": true,
"rules": { "rules": {
"recommended": true, "recommended": true,

6
src/phases/move-effect-phase.ts
View File

@ -219,6 +219,7 @@ export class MoveEffectPhase extends PokemonPhase {
return; return;
} }
break; break;
// biome-ignore lint/suspicious/noFallthroughSwitchClause: The fallthrough is intentional
case HitCheckResult.NO_EFFECT: case HitCheckResult.NO_EFFECT:
globalScene.queueMessage( globalScene.queueMessage(
i18next.t(this.move.id === MoveId.SHEER_COLD ? "battle:hitResultImmune" : "battle:hitResultNoEffect", { i18next.t(this.move.id === MoveId.SHEER_COLD ? "battle:hitResultImmune" : "battle:hitResultNoEffect", {
@ -294,7 +295,8 @@ export class MoveEffectPhase extends PokemonPhase {
// If other effects were overriden, stop this phase before they can be applied // If other effects were overriden, stop this phase before they can be applied
if (overridden.value) { if (overridden.value) {
return this.end(); this.end();
return;
} }
// Lapse `MOVE_EFFECT` effects (i.e. semi-invulnerability) when applicable // Lapse `MOVE_EFFECT` effects (i.e. semi-invulnerability) when applicable
@ -743,7 +745,7 @@ export class MoveEffectPhase extends PokemonPhase {
firstTarget?: boolean | null, firstTarget?: boolean | null,
selfTarget?: boolean, selfTarget?: boolean,
): void { ): void {
return applyFilteredMoveAttrs( applyFilteredMoveAttrs(
(attr: MoveAttr) => (attr: MoveAttr) =>
attr instanceof MoveEffectAttr && attr instanceof MoveEffectAttr &&
attr.trigger === triggerType && attr.trigger === triggerType &&