Move game-mode to its own file

Reduces circular imports to 325

src/battle-scene.ts

@@ -80,7 +80,8 @@ import type { FixedBattleConfig } from "#app/battle";
 import Battle from "#app/battle";
 import { BattleType } from "#enums/battle-type";
 import type { GameMode } from "#app/game-mode";
-import { GameModes, getGameMode } from "#app/game-mode";
+import { getGameMode } from "#app/game-mode";
+import { GameModes } from "#enums/game-modes";
 import FieldSpritePipeline from "#app/pipelines/field-sprite";
 import SpritePipeline from "#app/pipelines/sprite";
 import PartyExpBar from "#app/ui/party-exp-bar";

src/data/mystery-encounters/mystery-encounter.ts

@@ -24,7 +24,7 @@ import type { BattlerIndex } from "#app/battle";
 import { MysteryEncounterTier } from "#enums/mystery-encounter-tier";
 import { MysteryEncounterMode } from "#enums/mystery-encounter-mode";
 import { MysteryEncounterOptionMode } from "#enums/mystery-encounter-option-mode";
-import type { GameModes } from "#app/game-mode";
+import type { GameModes } from "#enums/game-modes";
 import type { EncounterAnim } from "#enums/encounter-anims";
 import type { Challenges } from "#enums/challenges";
 import { globalScene } from "#app/global-scene";

src/data/trainers/TrainerPartyTemplate.ts

@@ -1,7 +1,7 @@
 import { startingWave } from "#app/starting-wave";
 import { globalScene } from "#app/global-scene";
 import { PartyMemberStrength } from "#enums/party-member-strength";
-import { GameModes } from "#app/game-mode";
+import { GameModes } from "#enums/game-modes";
 import { ClassicFixedBossWaves } from "#enums/fixed-boss-waves";
 
 export class TrainerPartyTemplate {

src/enums/game-modes.ts

@@ -0,0 +1,8 @@
+
+export enum GameModes {
+  CLASSIC,
+  ENDLESS,
+  SPLICED_ENDLESS,
+  DAILY,
+  CHALLENGE
+}

src/game-mode.ts

@@ -14,14 +14,7 @@ import { Challenges } from "./enums/challenges";
 import { globalScene } from "#app/global-scene";
 import { getDailyStartingBiome } from "./data/daily-run";
 import { CLASSIC_MODE_MYSTERY_ENCOUNTER_WAVES, CHALLENGE_MODE_MYSTERY_ENCOUNTER_WAVES } from "./constants";
-
-export enum GameModes {
-  CLASSIC,
-  ENDLESS,
-  SPLICED_ENDLESS,
-  DAILY,
-  CHALLENGE,
-}
+import { GameModes } from "#enums/game-modes";
 
 interface GameModeConfig {
   isClassic?: boolean;

src/phases/title-phase.ts

@@ -3,7 +3,8 @@ import { BattleType } from "#enums/battle-type";
 import { fetchDailyRunSeed, getDailyRunStarters } from "#app/data/daily-run";
 import { Gender } from "#app/data/gender";
 import { getBiomeKey } from "#app/field/arena";
-import { GameMode, GameModes, getGameMode } from "#app/game-mode";
+import { GameMode, getGameMode } from "#app/game-mode";
+import { GameModes } from "#enums/game-modes";
 import type { Modifier } from "#app/modifier/modifier";
 import {
   getDailyRunStarterModifiers,

src/system/game-data.ts

@@ -14,7 +14,8 @@ import PokemonData from "#app/system/pokemon-data";
 import PersistentModifierData from "#app/system/modifier-data";
 import ArenaData from "#app/system/arena-data";
 import { Unlockables } from "#app/system/unlockables";
-import { GameModes, getGameMode } from "#app/game-mode";
+import { getGameMode } from "#app/game-mode";
+import { GameModes } from "#enums/game-modes";
 import { BattleType } from "#enums/battle-type";
 import TrainerData from "#app/system/trainer-data";
 import { trainerConfigs } from "#app/data/trainers/trainer-config";

src/system/unlockables.ts

@@ -1,5 +1,6 @@
 import i18next from "i18next";
-import { GameMode, GameModes } from "../game-mode";
+import { GameMode } from "../game-mode";
+import { GameModes } from "#enums/game-modes";
 
 export enum Unlockables {
   ENDLESS_MODE,

src/ui/run-history-ui-handler.ts

@@ -1,5 +1,5 @@
 import { globalScene } from "#app/global-scene";
-import { GameModes } from "../game-mode";
+import { GameModes } from "#enums/game-modes";
 import { TextStyle, addTextObject } from "./text";
 import { UiMode } from "#enums/ui-mode";
 import { addWindow } from "./ui-theme";

src/ui/run-info-ui-handler.ts

@@ -1,4 +1,4 @@
-import { GameModes } from "../game-mode";
+import { GameModes } from "#enums/game-modes";
 import UiHandler from "./ui-handler";
 import type { SessionSaveData } from "../system/game-data";
 import { TextStyle, addTextObject, addBBCodeTextObject, getTextColor } from "./text";

src/ui/starter-select-ui-handler.ts

@@ -22,7 +22,7 @@ import type PokemonSpecies from "#app/data/pokemon-species";
 import { allSpecies, getPokemonSpeciesForm, getPokerusStarters } from "#app/data/pokemon-species";
 import { getStarterValueFriendshipCap, speciesStarterCosts, POKERUS_STARTER_COUNT } from "#app/data/balance/starters";
 import { PokemonType } from "#enums/pokemon-type";
-import { GameModes } from "#app/game-mode";
+import { GameModes } from "#enums/game-modes";
 import type { DexAttrProps, StarterMoveset, StarterAttributes, StarterPreferences } from "#app/system/game-data";
 import type { DexEntry } from "#app/@types/dex-data";
 import { AbilityAttr, DexAttr, loadStarterPreferences, saveStarterPreferences } from "#app/system/game-data";

test/battle/battle.test.ts

@@ -1,6 +1,7 @@
 import { allSpecies } from "#app/data/pokemon-species";
 import { Stat } from "#enums/stat";
-import { GameModes, getGameMode } from "#app/game-mode";
+import { getGameMode } from "#app/game-mode";
+import { GameModes } from "#enums/game-modes";
 import { BattleEndPhase } from "#app/phases/battle-end-phase";
 import { CommandPhase } from "#app/phases/command-phase";
 import { DamageAnimPhase } from "#app/phases/damage-anim-phase";

test/battle/double_battle.test.ts

@@ -1,6 +1,7 @@
 import { Status } from "#app/data/status-effect";
 import { AbilityId } from "#enums/ability-id";
-import { GameModes, getGameMode } from "#app/game-mode";
+import { getGameMode } from "#app/game-mode";
+import { GameModes } from "#enums/game-modes";
 import { BattleEndPhase } from "#app/phases/battle-end-phase";
 import { TurnInitPhase } from "#app/phases/turn-init-phase";
 import { MoveId } from "#enums/move-id";

test/endless_boss.test.ts

@@ -1,6 +1,6 @@
 import { BiomeId } from "#enums/biome-id";
 import { SpeciesId } from "#enums/species-id";
-import { GameModes } from "#app/game-mode";
+import { GameModes } from "#enums/game-modes";
 import { afterEach, beforeAll, beforeEach, describe, expect, it } from "vitest";
 import GameManager from "#test/testUtils/gameManager";
 

test/final_boss.test.ts

@@ -1,4 +1,4 @@
-import { GameModes } from "#app/game-mode";
+import { GameModes } from "#enums/game-modes";
 import { TurnHeldItemTransferModifier } from "#app/modifier/modifier";
 import { AbilityId } from "#enums/ability-id";
 import { BiomeId } from "#enums/biome-id";

test/game-mode.test.ts

@@ -1,5 +1,6 @@
 import type { GameMode } from "#app/game-mode";
-import { GameModes, getGameMode } from "#app/game-mode";
+import { getGameMode } from "#app/game-mode";
+import { GameModes } from "#enums/game-modes";
 import { afterEach, beforeAll, beforeEach, describe, expect, it, vi } from "vitest";
 import * as Utils from "#app/utils/common";
 import GameManager from "#test/testUtils/gameManager";

test/reload.test.ts

@@ -1,4 +1,4 @@
-import { GameModes } from "#app/game-mode";
+import { GameModes } from "#enums/game-modes";
 import { pokerogueApi } from "#app/plugins/api/pokerogue-api";
 import type OptionSelectUiHandler from "#app/ui/settings/option-select-ui-handler";
 import { UiMode } from "#enums/ui-mode";

test/testUtils/gameManager.ts

@@ -3,7 +3,8 @@ import { BattlerIndex } from "#app/battle";
 import BattleScene from "#app/battle-scene";
 import type { EnemyPokemon, PlayerPokemon } from "#app/field/pokemon";
 import Trainer from "#app/field/trainer";
-import { GameModes, getGameMode } from "#app/game-mode";
+import { getGameMode } from "#app/game-mode";
+import { GameModes } from "#enums/game-modes";
 import { globalScene } from "#app/global-scene";
 import { ModifierTypeOption, modifierTypes } from "#app/modifier/modifier-type";
 import overrides from "#app/overrides";

test/testUtils/gameManagerUtils.ts

@@ -5,7 +5,8 @@ import { getDailyRunStarters } from "#app/data/daily-run";
 import { Gender } from "#app/data/gender";
 import { getPokemonSpecies, getPokemonSpeciesForm } from "#app/data/pokemon-species";
 import { PlayerPokemon } from "#app/field/pokemon";
-import { GameModes, getGameMode } from "#app/game-mode";
+import { getGameMode } from "#app/game-mode";
+import { GameModes } from "#enums/game-modes";
 import type { StarterMoveset } from "#app/system/game-data";
 import type { Starter } from "#app/ui/starter-select-ui-handler";
 import { MoveId } from "#enums/move-id";

test/testUtils/helpers/classicModeHelper.ts

@@ -1,6 +1,7 @@
 import { BattleStyle } from "#app/enums/battle-style";
 import type { SpeciesId } from "#enums/species-id";
-import { GameModes, getGameMode } from "#app/game-mode";
+import { getGameMode } from "#app/game-mode";
+import { GameModes } from "#enums/game-modes";
 import overrides from "#app/overrides";
 import { CommandPhase } from "#app/phases/command-phase";
 import { EncounterPhase } from "#app/phases/encounter-phase";

test/ui/starter-select.test.ts

@@ -1,7 +1,7 @@
 import { Gender } from "#app/data/gender";
 import { Nature } from "#enums/nature";
 import { allSpecies } from "#app/data/pokemon-species";
-import { GameModes } from "#app/game-mode";
+import { GameModes } from "#enums/game-modes";
 import { EncounterPhase } from "#app/phases/encounter-phase";
 import { SelectStarterPhase } from "#app/phases/select-starter-phase";
 import type { TitlePhase } from "#app/phases/title-phase";