From b390324507960007ff13c1ac93b63491a2af4f53 Mon Sep 17 00:00:00 2001 From: Wlowscha <54003515+Wlowscha@users.noreply.github.com> Date: Sun, 9 Feb 2025 02:56:13 +0100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com> --- src/ui/pokedex-mon-container.ts | 1 + src/ui/pokedex-page-ui-handler.ts | 4 ++-- src/ui/pokedex-ui-handler.ts | 5 ++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/ui/pokedex-mon-container.ts b/src/ui/pokedex-mon-container.ts index 637665c7229..31a98c30d1c 100644 --- a/src/ui/pokedex-mon-container.ts +++ b/src/ui/pokedex-mon-container.ts @@ -11,6 +11,7 @@ interface SpeciesDetails { female?: boolean, variant?: Variant } + export class PokedexMonContainer extends Phaser.GameObjects.Container { public species: PokemonSpecies; public icon: Phaser.GameObjects.Sprite; diff --git a/src/ui/pokedex-page-ui-handler.ts b/src/ui/pokedex-page-ui-handler.ts index 2ba2d760518..b31724533b5 100644 --- a/src/ui/pokedex-page-ui-handler.ts +++ b/src/ui/pokedex-page-ui-handler.ts @@ -126,7 +126,7 @@ interface SpeciesDetails { shiny?: boolean, formIndex?: number female?: boolean, - variant?: number + variant?: number, } enum MenuOptions { @@ -2040,7 +2040,7 @@ export default class PokedexPageUiHandler extends MessageUiHandler { shiny: props.shiny, formIndex: props.formIndex, female: props.female, - variant: props.variant + variant: props.variant, }); this.pokemonSprite.setTint(0x808080); } diff --git a/src/ui/pokedex-ui-handler.ts b/src/ui/pokedex-ui-handler.ts index 16f92d9b299..c1ed99066a0 100644 --- a/src/ui/pokedex-ui-handler.ts +++ b/src/ui/pokedex-ui-handler.ts @@ -136,7 +136,7 @@ interface SpeciesDetails { female?: boolean, variant?: Variant, abilityIndex?: number, - natureIndex?: number + natureIndex?: number, } export default class PokedexUiHandler extends MessageUiHandler { @@ -215,7 +215,6 @@ export default class PokedexUiHandler extends MessageUiHandler { private showFormTrayLabel: Phaser.GameObjects.Text; private canShowFormTray: boolean; - constructor() { super(Mode.POKEDEX); } @@ -1740,7 +1739,7 @@ export default class PokedexUiHandler extends MessageUiHandler { return false; } - cursor = Math.max(Math.min(this.trayContainers.length - 1, cursor), 0); + cursor = Phaser.Math.Clamp(this.trayContainers.length - 1, cursor, 0); const changed = this.trayCursor !== cursor; if (changed) { this.trayCursor = cursor;