[GitHub] Make tests skip if no filters are matched (#5744)

* Make tests skip if filters are matched

* Tweak filter path

* Make thing checkout thing

* Change where workflow is skipped

* Change where workflow is skipped

* Update github test filters

* Update test-filters.yml

---------

Co-authored-by: Wlowscha <54003515+Wlowscha@users.noreply.github.com>

.github/test-filters.yml

@@ -0,0 +1,19 @@
+all:
+  - "src/**"
+  - "test/**"
+  - "public/**"
+  # Workflows that can impact tests
+  - ".github/workflows/test*.yml"
+  - ".github/test-filters.yml"
+  # top-level files
+  - "package*.json"
+  - ".nvrmc" # Updates to node version can break tests
+  - "vite*" # vite.config.ts, vite.vitest.config.ts, vitest.workspace.ts
+  - "tsconfig*.json" # tsconfig.json tweaking can impact compilation
+  - "global.d.ts"
+  - ".env*"
+  # Blanket negations for files that cannot impact tests
+  - "!**/*.py" # No .py files
+  - "!**/*.sh" # No .sh files
+  - "!**/*.md" # No .md files
+  - "!**/.git*" # .gitkeep and family

.github/workflows/test-shard-template.yml

@@ -12,11 +12,16 @@ on:
       totalShards:
         required: true
         type: number
+      skip:
+        required: true
+        type: boolean
+        default: false
 
 jobs:
   test:
     name: Shard ${{ inputs.shard }} of ${{ inputs.totalShards }}
     runs-on: ubuntu-latest
+    if: ${{ !inputs.skip }}
     steps:
       - name: Check out Git repository
         uses: actions/checkout@v4.2.2

.github/workflows/tests.yml

@@ -7,58 +7,30 @@ on:
     branches:
       - main # Trigger on push events to the main branch
       - beta # Trigger on push events to the beta branch
-      - release # Trigger on push events to the release branch
-    # go upvote https://github.com/actions/runner/issues/1182 and yell at microsoft until they fix this or ditch yml for workflows
-    paths:
-      # src and test files
-      - "src/**"
-      - "test/**"
-      - "public/**"
-      # Workflows that can impact tests
-      - ".github/workflows/test*.yml"
-      # top-level files
-      - "package*.json"
-      - ".nvrmc" # Updates to node version can break tests
-      - "vite.*.ts" # vite.config.ts, vite.vitest.config.ts, vitest.workspace.ts
-      - "tsconfig*.json" # tsconfig.json tweaking can impact compilation
-      - "global.d.ts"
-      - ".env.*"
-      # Blanket negations for files that cannot impact tests
-      - "!**/*.py" # No .py files
-      - "!**/*.sh" # No .sh files
-      - "!**/*.md" # No .md files
-      - "!**/.git*" # .gitkeep and family
-
   pull_request:
     branches:
       - main # Trigger on pull request events targeting the main branch
       - beta # Trigger on pull request events targeting the beta branch
-      - release # Trigger on pull request events targeting the release branch
-    paths: # go upvote https://github.com/actions/runner/issues/1182 and yell at microsoft because until then we have to duplicate this
-      # src and test files
-      - "src/**"
-      - "test/**"
-      - "public/**"
-      # Workflows that can impact tests
-      - ".github/workflows/test*.yml"
-      # top-level files
-      - "package*.json"
-      - ".nvrmc" # Updates to node version can break tests
-      - "vite*" # vite.config.ts, vite.vitest.config.ts, vitest.workspace.ts
-      - "tsconfig*.json" # tsconfig.json tweaking can impact compilation
-      - "global.d.ts"
-      - ".env.*"
-      # Blanket negations for files that cannot impact tests
-      - "!**/*.py" # No .py files
-      - "!**/*.sh" # No .sh files
-      - "!**/*.md" # No .md files
-      - "!**/.git*" # .gitkeep and family
   merge_group:
     types: [checks_requested]
 
 jobs:
+  check-path-change-filter:
+    runs-on: ubuntu-latest
+    permissions:
+      pull-requests: read
+    outputs:
+      all: ${{ steps.filter.outputs.all }}
+    steps:
+      - name: checkout
+        uses: actions/checkout@v4
+      - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36
+        with:
+          filters: .github/test-filters.yml
+
   run-tests:
     name: Run Tests
+    needs: check-path-change-filter
     strategy:
       matrix:
         shard: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
@@ -67,3 +39,4 @@ jobs:
       project: main
       shard: ${{ matrix.shard }}
       totalShards: 10
+      skip: ${{ needs.check-path-change-filter.outputs.all == 'false'}}