mika/pokerogue
1
0
Fork 0
mirror of https://github.com/pagefaultgames/pokerogue.git synced 2025-07-20 07:12:32 +02:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
This commit is contained in:
Wlowscha 2025-03-12 08:33:53 +01:00 committed by GitHub
parent 145adaf6d8
commit 8faf163333
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/data/challenge.ts
View File

@ -1256,11 +1256,11 @@ export function initChallenges() {
/**
* Apply all challenges to the given starter (and form) to check its validity.
* Differs from {@link checkSpeciesValidForChallenge} which only checks form changes.
* @param species {@link PokemonSpecies} The species to check the validity of.
* @param dexAttr {@link DexAttrProps} The dex attributes of the species, including its form index.
* @param soft {@link boolean} If true, allow it if it could become valid through evolution or form change.
* @returns True if the species is considered valid.
* Differs from {@linkcode checkSpeciesValidForChallenge} which only checks form changes.
* @param species - The {@linkcode PokemonSpecies} to check the validity of.
* @param dexAttr - The {@linkcode DexAttrProps | dex attributes} of the species, including its form index.
* @param soft - If `true`, allow it if it could become valid through evolution or form change.
* @returns `true` if the species is considered valid.
*/
export function checkStarterValidForChallenge(species: PokemonSpecies, props: DexAttrProps, soft: boolean) {
if (!soft) {
@ -1291,11 +1291,11 @@ export function checkStarterValidForChallenge(species: PokemonSpecies, props: De
/**
* Apply all challenges to the given species (and form) to check its validity.
* Differs from {@link checkStarterValidForChallenge} which also checks evolutions.
* @param species {@link PokemonSpecies} The species to check the validity of.
* @param dexAttr {@link DexAttrProps} The dex attributes of the species, including its form index.
* @param soft {@link boolean} If true, allow it if it could become valid through a form change.
* @returns True if the species is considered valid.
* Differs from {@linkcode checkStarterValidForChallenge} which also checks evolutions.
* @param species - The {@linkcode PokemonSpecies} to check the validity of.
* @param dexAttr - The {@linkcode DexAttrProps | dex attributes} of the species, including its form index.
* @param soft - If `true`, allow it if it could become valid through a form change.
* @returns `true` if the species is considered valid.
*/
function checkSpeciesValidForChallenge(species: PokemonSpecies, props: DexAttrProps, soft: boolean) {
if (!soft || !pokemonFormChanges.hasOwnProperty(species.speciesId) || props.formIndex === 0) {