From 80a9d31ddb1b0693785ed2c61fc4de5f4d8e7489 Mon Sep 17 00:00:00 2001 From: Wlowscha <54003515+Wlowscha@users.noreply.github.com> Date: Sun, 23 Feb 2025 14:36:41 +0100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com> --- src/ui/pokedex-ui-handler.ts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/ui/pokedex-ui-handler.ts b/src/ui/pokedex-ui-handler.ts index 409fcf5c14a..dc1abacbffc 100644 --- a/src/ui/pokedex-ui-handler.ts +++ b/src/ui/pokedex-ui-handler.ts @@ -1246,7 +1246,6 @@ export default class PokedexUiHandler extends MessageUiHandler { this.filterBar.updateFilterLabels(); this.filterText.updateFilterLabels(); - // filter this.filteredPokemonData = []; this.allSpecies.forEach(species => { @@ -1348,10 +1347,10 @@ export default class PokedexUiHandler extends MessageUiHandler { } // Gen filter - const fitsGen = this.filterBar.getVals(DropDownColumn.GEN).includes(species.generation); + const fitsGen = this.filterBar.getVals(DropDownColumn.GEN).includes(species.generation); // Type filter - const fitsType = this.filterBar.getVals(DropDownColumn.TYPES).some(type => species.isOfType((type as number) - 1)); + const fitsType = this.filterBar.getVals(DropDownColumn.TYPES).some(type => species.isOfType((type as number) - 1)); // Biome filter const indexToBiome = new Map(