mika/pokerogue
1
0
Fork 0
mirror of https://github.com/pagefaultgames/pokerogue.git synced 2025-07-17 13:52:18 +02:00
Code Issues Packages Projects Releases Wiki Activity

additional comments for multi-hit problem

Browse Source
This commit is contained in:
DustinLin 2024-05-20 20:29:07 -04:00
parent 0fa4ae607b
commit 55ad9c4428
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/field/pokemon.ts
View File

@ -1709,13 +1709,18 @@ export default abstract class Pokemon extends Phaser.GameObjects.Container {
this.scene.applyModifiers(DamageMoneyRewardModifier, true, source, damage) this.scene.applyModifiers(DamageMoneyRewardModifier, true, source, damage)
// don't want to add another fainted phase, perhaps calculate for multi hit moves if someone fainted /**
// problem is applyAbAttrsInternal() in ability.ts is resetting the phaseQueueSpliceIndex before the moveaffectphase * don't want to add another fainted phase
// end() to add the message, don't want to remove it since I have no idea what it's doing * option could be calculate for multi hit moves if fainted
if (this.isFainted()) { * problem with hit move message display is applyAbAttrsInternal() in ability.ts is
* resetting the phaseQueueSpliceIndex before the moveaffectphase
* end() to add the message
*
if (this.isFainted()) { }
// option 1: try to add multi move message here, and add a conidtion in end() to not add it a second time // option 1: try to add multi move message here, and add a conidtion in end() to not add it a second time
// option 2: figure out what applyAbAttrsInternal() is doing and if there is a way to still add the message from end() properly // option 2: figure out what applyAbAttrsInternal() is doing and if there is a way to still add the message from end() properly
} */
/** /**
* since damage is an object, I don't see how this would ever by false? * since damage is an object, I don't see how this would ever by false?