From 44a6899424a2d9ada56f2f4e4e573f9b0bfb8288 Mon Sep 17 00:00:00 2001 From: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com> Date: Tue, 12 Aug 2025 16:56:23 -0500 Subject: [PATCH] Apply Kev's suggestions from code review Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com> --- src/constants.ts | 2 +- src/system/ribbons/ribbon-data.ts | 1 + src/system/ribbons/ribbon-methods.ts | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/constants.ts b/src/constants.ts index b5837c7dd7f..17cf08aa7e2 100644 --- a/src/constants.ts +++ b/src/constants.ts @@ -103,7 +103,7 @@ export const ANTI_VARIANCE_WEIGHT_MODIFIER = 15; export const FAKE_TITLE_LOGO_CHANCE = 10000; /** - * The ceiling on friendshp amount that can be reached through the use of rare candies. + * The ceiling on friendship amount that can be reached through the use of rare candies. * Using rare candies will never increase friendship beyond this value. */ export const RARE_CANDY_FRIENDSHIP_CAP = 200; diff --git a/src/system/ribbons/ribbon-data.ts b/src/system/ribbons/ribbon-data.ts index 080b118e7f5..42c523afc0e 100644 --- a/src/system/ribbons/ribbon-data.ts +++ b/src/system/ribbons/ribbon-data.ts @@ -1,4 +1,5 @@ import type { Brander } from "#types/type-helpers"; + export type RibbonFlag = (number & Brander<"RibbonFlag">) | 0; /** diff --git a/src/system/ribbons/ribbon-methods.ts b/src/system/ribbons/ribbon-methods.ts index aa88f8e6c62..a465357ab8c 100644 --- a/src/system/ribbons/ribbon-methods.ts +++ b/src/system/ribbons/ribbon-methods.ts @@ -8,7 +8,7 @@ import { isNullOrUndefined } from "#utils/common"; * Award one or more ribbons to a species and its pre-evolutions * * @param id - The ID of the species to award ribbons to - * @param ribbons The ribbon(s) to award (use bitwise OR to combine multiple) + * @param ribbons - The ribbon(s) to award (use bitwise OR to combine multiple) */ export function awardRibbonsToSpeciesLine(id: SpeciesId, ribbons: RibbonFlag): void { const dexData = globalScene.gameData.dexData;