From 41f6d0ce88c709f14931b55c7bd26b3cebcfea8c Mon Sep 17 00:00:00 2001
From: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
Date: Sat, 8 Mar 2025 07:52:23 -0600
Subject: [PATCH] revert overrides and add it to biome's ignored files

---
 biome.jsonc      |  3 +++
 src/overrides.ts | 37 ++++++++++++++-----------------------
 2 files changed, 17 insertions(+), 23 deletions(-)

diff --git a/biome.jsonc b/biome.jsonc
index b6a4dffe21c..3ec4552d359 100644
--- a/biome.jsonc
+++ b/biome.jsonc
@@ -15,6 +15,8 @@
   },
   "files": {
     "ignoreUnknown": true,
+    // Adding folders to the ignore list is GREAT for performance because it prevents biome from descending into them
+    // and having to verify whether each individual file is ignored
     "ignore": [
       "**/*.d.ts",
       "dist/*",
@@ -26,6 +28,7 @@
       ".vscode/*",
       "*.css", // TODO?
       "*.html", // TODO?
+      "src/overrides.ts",
       // TODO: these files are too big and complex, ignore them until their respective refactors
       "src/data/moves/move.ts",
       "src/data/ability.ts",
diff --git a/src/overrides.ts b/src/overrides.ts
index 9e91ef9784a..d15370259fc 100644
--- a/src/overrides.ts
+++ b/src/overrides.ts
@@ -1,31 +1,22 @@
-import type { PokeballCounts } from "#app/battle-scene";
-import { EvolutionItem } from "#app/data/balance/pokemon-evolutions";
-import type { Gender } from "#app/data/gender";
-import { FormChangeItem } from "#app/data/pokemon-forms";
-import type { Variant } from "#app/data/variant";
-import type { ModifierOverride } from "#app/modifier/modifier-type";
-import type { Unlockables } from "#app/system/unlockables";
+/* eslint-disable @typescript-eslint/consistent-type-imports */
+import { type PokeballCounts } from "#app/battle-scene";
+import { Gender } from "#app/data/gender";
+import { Variant } from "#app/data/variant";
+import { type ModifierOverride } from "#app/modifier/modifier-type";
+import { Unlockables } from "#app/system/unlockables";
 import { Abilities } from "#enums/abilities";
-import { BerryType } from "#enums/berry-type";
 import { Biome } from "#enums/biome";
-import type { EggTier } from "#enums/egg-type";
-import type { Moves } from "#enums/moves";
-import type { MysteryEncounterTier } from "#enums/mystery-encounter-tier";
-import type { MysteryEncounterType } from "#enums/mystery-encounter-type";
+import { EggTier } from "#enums/egg-type";
+import { Moves } from "#enums/moves";
+import { MysteryEncounterTier } from "#enums/mystery-encounter-tier";
+import { MysteryEncounterType } from "#enums/mystery-encounter-type";
 import { PokeballType } from "#enums/pokeball";
-import { PokemonType } from "#enums/pokemon-type";
-import type { Species } from "#enums/species";
-import { Stat } from "#enums/stat";
+import { Species } from "#enums/species";
 import { StatusEffect } from "#enums/status-effect";
-import type { TimeOfDay } from "#enums/time-of-day";
-import type { VariantTier } from "#enums/variant-tier";
+import { TimeOfDay } from "#enums/time-of-day";
+import { VariantTier } from "#enums/variant-tier";
 import { WeatherType } from "#enums/weather-type";
 
-/**
- * This comment block exists to prevent IDEs from automatically removing unused imports
- * {@linkcode BerryType}, {@linkcode EvolutionItem}, {@linkcode FormChangeItem}
- * {@linkcode Stat}, {@linkcode PokemonType}
- */
 /**
  * Overrides that are using when testing different in game situations
  *
@@ -260,7 +251,7 @@ export const defaultOverrides = new DefaultOverrides();
 
 export default {
   ...defaultOverrides,
-  ...overrides,
+  ...overrides
 } satisfies InstanceType<typeof DefaultOverrides>;
 
 export type BattleStyle = "double" | "single" | "even-doubles" | "odd-doubles";