[Dev] Move jsconfig.json to repository root (#6861)

* [Dev] Move `jsconfig.json` to repository root

* Renamed command to say "typecheck js" instead of just scripts

* exclude everything in assets

* Update jsconfig.json

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* Update jsconfig.json

Co-authored-by: Fabi <192151969+fabske0@users.noreply.github.com>

* Update jsconfig.json

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: Fabi <192151969+fabske0@users.noreply.github.com>

.github/workflows/linting.yml

@@ -43,16 +43,16 @@ jobs:
         if: ${{ !cancelled() }}
 
       # Validate types with tsc - https://www.typescriptlang.org/docs/handbook/compiler-options.html#using-the-cli
-      - name: Run Typecheck
+      - name: Run Typecheck (TS files)
         run: pnpm typecheck
         id: typecheck
         if: ${{ !cancelled() }}
 
-      # Run tsc again on the scripts folder.
-      # Required in order to use separate rules for script js files and regular ts files
-      - name: Run Typecheck (scripts)
-        run: pnpm typecheck:scripts
-        id: typecheck-scripts
+      # Run tsc again on all JS files.
+      # Required in order to use separate rules for different types of files
+      - name: Run Typecheck (JS files)
+        run: pnpm typecheck:js
+        id: typecheck-js
         if: ${{ !cancelled() }}
 
       - name: Check for REUSE compliance

jsconfig.json

@@ -6,13 +6,14 @@
  */
 {
   "include": ["**/*.js"],
+  "exclude": ["assets", "dist", "node_modules", "typedoc"],
   "compilerOptions": {
-    "allowJs": true,
-    "checkJs": true,
-    "rootDir": ".",
     "target": "esnext",
     "module": "nodenext",
     "moduleResolution": "nodenext",
+    "allowJs": true,
+    "checkJs": true,
+    "rootDir": ".",
     "erasableSyntaxOnly": true,
     "strict": true,
     "noEmit": true,

package.json

@@ -22,7 +22,7 @@
     "eggMoves:parse": "node scripts/parse-egg-moves/main.js",
     "scrape-trainers": "node scripts/scrape-trainer-names/main.js",
     "typecheck": "tsc --noEmit",
-    "typecheck:scripts": "tsc -p scripts/jsconfig.json",
+    "typecheck:js": "tsc -p jsconfig.json",
     "biome": "biome check --write --changed --no-errors-on-unmatched --diagnostic-level=error",
     "biome:staged": "biome check --write --staged --no-errors-on-unmatched --diagnostic-level=error",
     "biome:all": "biome check --write --no-errors-on-unmatched --diagnostic-level=error",

typedoc-plugins/typedoc-plugin-rename-svg.js

@@ -4,16 +4,15 @@
  *
  * SPDX-License-Identifier: AGPL-3.0-only
  */
-// @ts-check
-
-import { PageKind, Renderer } from "typedoc";
 
 /**
- * @module
  * Typedoc plugin to run post-processing on the `index.html` file and replace the coverage SVG
  * for Beta with the newly generated file for the current branch.
+ * @module
  */
 
+import { PageKind, Renderer } from "typedoc";
+
 /**
  * @param {import('typedoc').Application} app
  */