mika/pokerogue
1
0
Fork 0
mirror of https://github.com/pagefaultgames/pokerogue.git synced 2025-07-08 01:12:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

No reload is if unnecesary, settings

Browse Source
This commit is contained in:
Adrian 2024-08-17 08:19:42 -04:00
parent ae2ab120dc
commit 3d8a51e7e4
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/ui/settings/abstract-settings-ui-handler.ts
View File

@ -32,7 +32,7 @@ export default class AbstractSettingsUiHandler extends UiHandler {
private cursorObj: Phaser.GameObjects.NineSlice | null; private cursorObj: Phaser.GameObjects.NineSlice | null;
private reloadSettings: Array<Setting>; private reloadSettings: Array<integer | null>;
private reloadRequired: boolean; private reloadRequired: boolean;
protected rowsToDisplay: number; protected rowsToDisplay: number;
@ -91,7 +91,6 @@ export default class AbstractSettingsUiHandler extends UiHandler {
this.settingLabels = []; this.settingLabels = [];
this.optionValueLabels = []; this.optionValueLabels = [];
this.reloadSettings = this.settings.filter(s => s?.requireReload);
this.settings this.settings
.forEach((setting, s) => { .forEach((setting, s) => {
@ -183,6 +182,12 @@ export default class AbstractSettingsUiHandler extends UiHandler {
const settings: object = localStorage.hasOwnProperty(this.localStorageKey) ? JSON.parse(localStorage.getItem(this.localStorageKey)!) : {}; // TODO: is this bang correct? const settings: object = localStorage.hasOwnProperty(this.localStorageKey) ? JSON.parse(localStorage.getItem(this.localStorageKey)!) : {}; // TODO: is this bang correct?
this.settings.forEach((setting, s) => this.setOptionCursor(s, settings.hasOwnProperty(setting.key) ? settings[setting.key] : this.settings[s].default)); this.settings.forEach((setting, s) => this.setOptionCursor(s, settings.hasOwnProperty(setting.key) ? settings[setting.key] : this.settings[s].default));
this.reloadSettings = this.settings.map((setting, s) => {
if (setting.requireReload) {
return settings.hasOwnProperty(setting.key) ? settings[setting.key] : this.settings[s].default;
}
return null;
});
this.settingsContainer.setVisible(true); this.settingsContainer.setVisible(true);
this.setCursor(0); this.setCursor(0);
@ -345,9 +350,10 @@ export default class AbstractSettingsUiHandler extends UiHandler {
if (save) { if (save) {
this.scene.gameData.saveSetting(setting.key, cursor); this.scene.gameData.saveSetting(setting.key, cursor);
if (this.reloadSettings.includes(setting)) {
this.reloadRequired = true; this.reloadRequired = this.reloadSettings.some((s,i)=>
} s !== null && s !== this.optionCursors[i]
);
} }
return true; return true;