mika/pokerogue
1
0
Fork 0
mirror of https://github.com/pagefaultgames/pokerogue.git synced 2025-07-21 07:42:25 +02:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
This commit is contained in:
Wlowscha 2025-02-24 22:20:04 +01:00 committed by GitHub
parent 41c75bf4a5
commit 2b0f9357a4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/ui/filter-bar.ts
View File

@ -91,7 +91,7 @@ export class FilterBar extends Phaser.GameObjects.Container {
* @param index the index of the column to retrieve * @param index the index of the column to retrieve
* @returns the associated DropDownColumn if it exists, undefined otherwise * @returns the associated DropDownColumn if it exists, undefined otherwise
*/ */
getColumn(index: number) : DropDownColumn { public getColumn(index: number): DropDownColumn {
return this.columns[index]; return this.columns[index];
} }
@ -194,7 +194,7 @@ export class FilterBar extends Phaser.GameObjects.Container {
return this.getFilter(col).getVals(); return this.getFilter(col).getVals();
} }
resetSelection(col: DropDownColumn): void { public resetSelection(col: DropDownColumn): void {
this.dropDowns[col].resetToDefault(); this.dropDowns[col].resetToDefault();
this.updateFilterLabels(); this.updateFilterLabels();
} }

2
src/ui/pokedex-ui-handler.ts
View File

@ -892,7 +892,7 @@ export default class PokedexUiHandler extends MessageUiHandler {
success = true; success = true;
} else if (this.filterMode && !this.filterBar.getFilter(this.filterBarCursor).hasDefaultValues()) { } else if (this.filterMode && !this.filterBar.getFilter(this.filterBarCursor).hasDefaultValues()) {
this.filterBar.resetSelection(this.filterBarCursor); this.filterBar.resetSelection(this.filterBarCursor);
this.updateStarters; this.updateStarters();
success = true; success = true;
} else if (this.filterTextMode && !(this.filterText.getValue(this.filterTextCursor) === this.filterText.defaultText)) { } else if (this.filterTextMode && !(this.filterText.getValue(this.filterTextCursor) === this.filterText.defaultText)) {
this.filterText.resetSelection(this.filterTextCursor); this.filterText.resetSelection(this.filterTextCursor);

4
src/ui/starter-select-ui-handler.ts
View File

@ -1088,7 +1088,7 @@ export default class StarterSelectUiHandler extends MessageUiHandler {
/** /**
* Set default value for the caught dropdown, which only shows caught mons * Set default value for the caught dropdown, which only shows caught mons
*/ */
resetCaughtDropdown(): void { public resetCaughtDropdown(): void {
const caughtDropDown: DropDown = this.filterBar.getFilter(DropDownColumn.CAUGHT); const caughtDropDown: DropDown = this.filterBar.getFilter(DropDownColumn.CAUGHT);
caughtDropDown.resetToDefault(); caughtDropDown.resetToDefault();
@ -1338,7 +1338,7 @@ export default class StarterSelectUiHandler extends MessageUiHandler {
} else { } else {
this.filterBar.resetSelection(this.filterBarCursor); this.filterBar.resetSelection(this.filterBarCursor);
} }
this.updateStarters; this.updateStarters();
success = true; success = true;
} else if (this.statsMode) { } else if (this.statsMode) {
this.toggleStatsMode(false); this.toggleStatsMode(false);