Added many tests

test/moves/baneful_bunker.test.ts

@@ -1,5 +1,5 @@
 import Phaser from "phaser";
-import { afterEach, beforeAll, beforeEach, describe, expect, test } from "vitest";
+import { afterEach, beforeAll, beforeEach, describe, expect, it } from "vitest";
 import GameManager from "#test/testUtils/gameManager";
 import { Species } from "#enums/species";
 import { Abilities } from "#enums/abilities";
@@ -24,59 +24,53 @@ describe("Moves - Baneful Bunker", () => {
   beforeEach(() => {
     game = new GameManager(phaserGame);
 
-    game.override.battleStyle("single");
+    game.override
-
+      .battleStyle("single")
-    game.override.moveset(Moves.SLASH);
+      .moveset([Moves.SLASH, Moves.FLASH_CANNON])
-
+      .enemySpecies(Species.TOXAPEX)
-    game.override.enemySpecies(Species.SNORLAX);
+      .enemyAbility(Abilities.INSOMNIA)
-    game.override.enemyAbility(Abilities.INSOMNIA);
+      .enemyMoveset(Moves.BANEFUL_BUNKER)
-    game.override.enemyMoveset(Moves.BANEFUL_BUNKER);
+      .startingLevel(100)
-
+      .enemyLevel(100);
-    game.override.startingLevel(100);
-    game.override.enemyLevel(100);
   });
-  test("should protect the user and poison attackers that make contact", async () => {
-    await game.classicMode.startBattle([Species.CHARIZARD]);
 
-    const leadPokemon = game.scene.getPlayerPokemon()!;
+  function expectProtected() {
-    const enemyPokemon = game.scene.getEnemyPokemon()!;
+    expect(game.scene.getEnemyPokemon()?.hp).toBe(game.scene.getEnemyPokemon()?.getMaxHp());
+    expect(game.scene.getPlayerPokemon()?.status?.effect).toBe(StatusEffect.POISON);
+  }
+
+  it("should protect the user and poison attackers that make contact", async () => {
+    await game.classicMode.startBattle([Species.CHARIZARD]);
 
     game.move.select(Moves.SLASH);
     await game.setTurnOrder([BattlerIndex.ENEMY, BattlerIndex.PLAYER]);
     await game.phaseInterceptor.to("BerryPhase", false);
-    expect(enemyPokemon.hp).toBe(enemyPokemon.getMaxHp());
+
-    expect(leadPokemon.status?.effect === StatusEffect.POISON).toBeTruthy();
+    expectProtected();
   });
-  test("should protect the user and poison attackers that make contact, regardless of accuracy checks", async () => {
+
+  it("should ignore accuracy checks", async () => {
     await game.classicMode.startBattle([Species.CHARIZARD]);
 
-    const leadPokemon = game.scene.getPlayerPokemon()!;
-    const enemyPokemon = game.scene.getEnemyPokemon()!;
-
     game.move.select(Moves.SLASH);
-    await game.setTurnOrder([BattlerIndex.ENEMY, BattlerIndex.PLAYER]);
+    await game.phaseInterceptor.to("MoveEndPhase"); // baneful bunker
-    await game.phaseInterceptor.to("MoveEffectPhase");
-
     await game.move.forceMiss();
+
     await game.phaseInterceptor.to("BerryPhase", false);
-    expect(enemyPokemon.hp).toBe(enemyPokemon.getMaxHp());
+
-    expect(leadPokemon.status?.effect === StatusEffect.POISON).toBeTruthy();
+    expectProtected();
   });
 
-  test("should not poison attackers that don't make contact", async () => {
+  it("should block non-contact moves without poisoning attackers", async () => {
-    game.override.moveset(Moves.FLASH_CANNON);
     await game.classicMode.startBattle([Species.CHARIZARD]);
 
-    const leadPokemon = game.scene.getPlayerPokemon()!;
+    const charizard = game.scene.getPlayerPokemon()!;
-    const enemyPokemon = game.scene.getEnemyPokemon()!;
+    const toxapex = game.scene.getEnemyPokemon()!;
 
     game.move.select(Moves.FLASH_CANNON);
-    await game.setTurnOrder([BattlerIndex.ENEMY, BattlerIndex.PLAYER]);
-    await game.phaseInterceptor.to("MoveEffectPhase");
-
-    await game.move.forceMiss();
     await game.phaseInterceptor.to("BerryPhase", false);
-    expect(enemyPokemon.hp).toBe(enemyPokemon.getMaxHp());
+
-    expect(leadPokemon.status?.effect === StatusEffect.POISON).toBeFalsy();
+    expect(toxapex.hp).toBe(toxapex.getMaxHp());
+    expect(charizard.status?.effect).toBeUndefined();
   });
 });

test/moves/crafty_shield.test.ts

@@ -1,13 +1,14 @@
 import Phaser from "phaser";
-import { afterEach, beforeAll, beforeEach, describe, expect, test } from "vitest";
+import { afterEach, beforeAll, beforeEach, describe, expect, it } from "vitest";
 import GameManager from "#test/testUtils/gameManager";
 import { Species } from "#enums/species";
 import { Abilities } from "#enums/abilities";
 import { Moves } from "#enums/moves";
 import { Stat } from "#enums/stat";
 import { BattlerTagType } from "#app/enums/battler-tag-type";
-import { BerryPhase } from "#app/phases/berry-phase";
+import { BattlerIndex } from "#app/battle";
-import { CommandPhase } from "#app/phases/command-phase";
+import { ArenaTagType } from "#enums/arena-tag-type";
+import { ArenaTagSide } from "#app/data/arena-tag";
 
 describe("Moves - Crafty Shield", () => {
   let phaserGame: Phaser.Game;
@@ -26,85 +27,102 @@ describe("Moves - Crafty Shield", () => {
   beforeEach(() => {
     game = new GameManager(phaserGame);
 
-    game.override.battleStyle("double");
+    game.override
-
+      .battleStyle("double")
-    game.override.moveset([Moves.CRAFTY_SHIELD, Moves.SPLASH, Moves.SWORDS_DANCE]);
+      .moveset([Moves.CRAFTY_SHIELD, Moves.SPLASH, Moves.SWORDS_DANCE, Moves.HOWL])
-
+      .enemySpecies(Species.DUSKNOIR)
-    game.override.enemySpecies(Species.SNORLAX);
+      .enemyMoveset(Moves.GROWL)
-    game.override.enemyMoveset([Moves.GROWL]);
+      .enemyAbility(Abilities.INSOMNIA)
-    game.override.enemyAbility(Abilities.INSOMNIA);
+      .startingLevel(100)
-
+      .enemyLevel(100);
-    game.override.startingLevel(100);
-    game.override.enemyLevel(100);
   });
 
-  test("should protect the user and allies from status moves", async () => {
+  it("should protect the user and allies from status moves", async () => {
-    await game.startBattle([Species.CHARIZARD, Species.BLASTOISE]);
+    await game.classicMode.startBattle([Species.CHARIZARD, Species.BLASTOISE]);
 
-    const leadPokemon = game.scene.getPlayerField();
+    const [charizard, blastoise] = game.scene.getPlayerField();
+    game.move.select(Moves.CRAFTY_SHIELD, BattlerIndex.PLAYER);
+    game.move.select(Moves.SPLASH, BattlerIndex.PLAYER_2);
+    await game.forceEnemyMove(Moves.GROWL);
+    await game.forceEnemyMove(Moves.GROWL);
 
-    game.move.select(Moves.CRAFTY_SHIELD);
+    await game.phaseInterceptor.to("TurnEndPhase");
 
-    await game.phaseInterceptor.to(CommandPhase);
+    expect(charizard.getStatStage(Stat.ATK)).toBe(0);
-
+    expect(blastoise.getStatStage(Stat.ATK)).toBe(0);
-    game.move.select(Moves.SPLASH, 1);
-
-    await game.phaseInterceptor.to(BerryPhase, false);
-
-    leadPokemon.forEach(p => expect(p.getStatStage(Stat.ATK)).toBe(0));
   });
 
-  test("should not protect the user and allies from attack moves", async () => {
+  it("should not protect the user and allies from attack moves", async () => {
-    game.override.enemyMoveset([Moves.TACKLE]);
+    game.override.enemyMoveset(Moves.TACKLE);
+    await game.classicMode.startBattle([Species.CHARIZARD, Species.BLASTOISE]);
 
-    await game.startBattle([Species.CHARIZARD, Species.BLASTOISE]);
+    const [charizard, blastoise] = game.scene.getPlayerField();
 
-    const leadPokemon = game.scene.getPlayerField();
+    game.move.select(Moves.CRAFTY_SHIELD, BattlerIndex.PLAYER);
+    game.move.select(Moves.SPLASH, BattlerIndex.PLAYER_2);
+    await game.forceEnemyMove(Moves.TACKLE, BattlerIndex.PLAYER);
+    await game.forceEnemyMove(Moves.TACKLE, BattlerIndex.PLAYER_2);
+    await game.phaseInterceptor.to("TurnEndPhase");
 
-    game.move.select(Moves.CRAFTY_SHIELD);
+    expect(charizard.isFullHp()).toBe(false);
-
+    expect(blastoise.isFullHp()).toBe(false);
-    await game.phaseInterceptor.to(CommandPhase);
-
-    game.move.select(Moves.SPLASH, 1);
-
-    await game.phaseInterceptor.to(BerryPhase, false);
-
-    expect(leadPokemon.some(p => p.hp < p.getMaxHp())).toBeTruthy();
   });
 
-  test("should protect the user and allies from moves that ignore other protection", async () => {
+  it("should not block entry hazards and field-targeted moves", async () => {
-    game.override.enemySpecies(Species.DUSCLOPS);
+    game.override.enemyMoveset([Moves.PERISH_SONG, Moves.TOXIC_SPIKES]);
-    game.override.enemyMoveset([Moves.CURSE]);
+    await game.classicMode.startBattle([Species.CHARIZARD, Species.BLASTOISE]);
 
-    await game.startBattle([Species.CHARIZARD, Species.BLASTOISE]);
+    const [charizard, blastoise] = game.scene.getPlayerField();
 
-    const leadPokemon = game.scene.getPlayerField();
+    game.move.select(Moves.CRAFTY_SHIELD, BattlerIndex.PLAYER);
+    game.move.select(Moves.SPLASH, BattlerIndex.PLAYER_2);
+    await game.forceEnemyMove(Moves.PERISH_SONG);
+    await game.forceEnemyMove(Moves.TOXIC_SPIKES);
+    await game.phaseInterceptor.to("TurnEndPhase");
 
-    game.move.select(Moves.CRAFTY_SHIELD);
+    expect(game.scene.arena.getTagOnSide(ArenaTagType.TOXIC_SPIKES, ArenaTagSide.PLAYER)).toBeDefined();
-
+    expect(charizard.getTag(BattlerTagType.PERISH_SONG)).toBeDefined();
-    await game.phaseInterceptor.to(CommandPhase);
+    expect(blastoise.getTag(BattlerTagType.PERISH_SONG)).toBeDefined();
-
-    game.move.select(Moves.SPLASH, 1);
-
-    await game.phaseInterceptor.to(BerryPhase, false);
-
-    leadPokemon.forEach(p => expect(p.getTag(BattlerTagType.CURSED)).toBeUndefined());
   });
 
-  test("should not block allies' self-targeted moves", async () => {
+  it("should protect the user and allies from moves that ignore other protection", async () => {
-    await game.startBattle([Species.CHARIZARD, Species.BLASTOISE]);
+    game.override.moveset(Moves.CURSE);
+    await game.classicMode.startBattle([Species.CHARIZARD, Species.BLASTOISE]);
 
-    const leadPokemon = game.scene.getPlayerField();
+    const [charizard, blastoise] = game.scene.getPlayerField();
 
-    game.move.select(Moves.CRAFTY_SHIELD);
+    game.move.select(Moves.CRAFTY_SHIELD, BattlerIndex.PLAYER);
+    game.move.select(Moves.SPLASH, BattlerIndex.PLAYER_2);
+    await game.forceEnemyMove(Moves.CURSE, BattlerIndex.PLAYER);
+    await game.forceEnemyMove(Moves.CURSE, BattlerIndex.PLAYER_2);
 
-    await game.phaseInterceptor.to(CommandPhase);
+    await game.phaseInterceptor.to("TurnEndPhase");
 
-    game.move.select(Moves.SWORDS_DANCE, 1);
+    expect(charizard.getTag(BattlerTagType.CURSED)).toBeDefined();
+    expect(blastoise.getTag(BattlerTagType.CURSED)).toBeDefined();
 
-    await game.phaseInterceptor.to(BerryPhase, false);
+    const [dusknoir1, dusknoir2] = game.scene.getEnemyField();
+    expect(dusknoir1.isFullHp()).toBe(false);
+    expect(dusknoir2.isFullHp()).toBe(false);
+  });
 
-    expect(leadPokemon[0].getStatStage(Stat.ATK)).toBe(0);
+  it("should not block allies' self or ally-targeted moves", async () => {
-    expect(leadPokemon[1].getStatStage(Stat.ATK)).toBe(2);
+    await game.classicMode.startBattle([Species.CHARIZARD, Species.BLASTOISE]);
+
+    const [charizard, blastoise] = game.scene.getPlayerField();
+
+    game.move.select(Moves.CRAFTY_SHIELD, BattlerIndex.PLAYER);
+    game.move.select(Moves.SWORDS_DANCE, BattlerIndex.PLAYER_2);
+    await game.phaseInterceptor.to("TurnEndPhase");
+
+    expect(charizard.getStatStage(Stat.ATK)).toBe(0);
+    expect(blastoise.getStatStage(Stat.ATK)).toBe(2);
+
+    game.move.select(Moves.HOWL, BattlerIndex.PLAYER);
+    game.move.select(Moves.CRAFTY_SHIELD, BattlerIndex.PLAYER_2);
+    await game.phaseInterceptor.to("TurnEndPhase");
+
+    expect(charizard.getStatStage(Stat.ATK)).toBe(1);
+    expect(blastoise.getStatStage(Stat.ATK)).toBe(3);
   });
 });

test/moves/endure.test.ts

@@ -1,9 +1,10 @@
+import { HitResult } from "#app/field/pokemon";
 import { Abilities } from "#enums/abilities";
 import { Moves } from "#enums/moves";
 import { Species } from "#enums/species";
 import GameManager from "#test/testUtils/gameManager";
 import Phaser from "phaser";
-import { afterEach, beforeAll, beforeEach, describe, expect, it } from "vitest";
+import { afterEach, beforeAll, beforeEach, describe, expect, it, vi } from "vitest";
 
 describe("Moves - Endure", () => {
   let phaserGame: Phaser.Game;
@@ -22,7 +23,7 @@ describe("Moves - Endure", () => {
   beforeEach(() => {
     game = new GameManager(phaserGame);
     game.override
-      .moveset([Moves.THUNDER, Moves.BULLET_SEED, Moves.TOXIC, Moves.SHEER_COLD])
+      .moveset([Moves.THUNDER, Moves.BULLET_SEED, Moves.SHEER_COLD])
       .ability(Abilities.SKILL_LINK)
       .startingLevel(100)
       .battleStyle("single")
@@ -32,55 +33,55 @@ describe("Moves - Endure", () => {
       .enemyMoveset(Moves.ENDURE);
   });
 
-  it("should let the pokemon survive with 1 HP", async () => {
+  it("should let the pokemon survive with 1 HP from attacks", async () => {
     await game.classicMode.startBattle([Species.ARCEUS]);
 
     game.move.select(Moves.THUNDER);
     await game.phaseInterceptor.to("BerryPhase");
 
-    expect(game.scene.getEnemyPokemon()!.hp).toBe(1);
+    const enemy = game.scene.getEnemyPokemon()!;
+    expect(enemy.hp).toBe(1);
   });
 
-  it("should let the pokemon survive with 1 HP when hit with a multihit move", async () => {
+  it("should let the pokemon survive with 1 HP from multi-strike moves", async () => {
     await game.classicMode.startBattle([Species.ARCEUS]);
 
     game.move.select(Moves.BULLET_SEED);
     await game.phaseInterceptor.to("BerryPhase");
 
-    expect(game.scene.getEnemyPokemon()!.hp).toBe(1);
+    const enemy = game.scene.getEnemyPokemon()!;
+    expect(enemy.hp).toBe(1);
   });
 
   it("should let the pokemon survive against OHKO moves", async () => {
     await game.classicMode.startBattle([Species.MAGIKARP]);
-    const enemy = game.scene.getEnemyPokemon()!;
 
     game.move.select(Moves.SHEER_COLD);
     await game.phaseInterceptor.to("TurnEndPhase");
 
-    expect(enemy.isFainted()).toBeFalsy();
+    const enemy = game.scene.getEnemyPokemon()!;
+    expect(enemy.hp).toBe(1);
   });
 
   // comprehensive indirect damage test copied from Reviver Seed test
   it.each([
-    { moveType: "Damaging Move Chip Damage", move: Moves.SALT_CURE },
+    { moveType: "Damaging Move Chip", move: Moves.SALT_CURE },
-    { moveType: "Chip Damage", move: Moves.LEECH_SEED },
+    { moveType: "Status Move Chip", move: Moves.LEECH_SEED },
-    { moveType: "Trapping Chip Damage", move: Moves.WHIRLPOOL },
+    { moveType: "Partial Trapping move", move: Moves.WHIRLPOOL },
-    { moveType: "Status Effect Damage", move: Moves.TOXIC },
+    { moveType: "Status Effect", move: Moves.TOXIC },
     { moveType: "Weather", move: Moves.SANDSTORM },
-  ])("should not prevent fainting from $moveType", async ({ move }) => {
+  ])("should not prevent fainting from $moveType Damage", async ({ move }) => {
-    game.override
+    game.override.moveset(move).enemyLevel(100);
-      .enemyLevel(1)
-      .startingLevel(100)
-      .enemySpecies(Species.MAGIKARP)
-      .moveset(move)
-      .enemyMoveset(Moves.ENDURE);
     await game.classicMode.startBattle([Species.MAGIKARP, Species.FEEBAS]);
+
     const enemy = game.scene.getEnemyPokemon()!;
-    enemy.damageAndUpdate(enemy.hp - 1);
+    enemy.hp = 2;
+    // force attack to do 1 dmg (for salt cure)
+    vi.spyOn(enemy, "getAttackDamage").mockReturnValue({ cancelled: false, result: HitResult.EFFECTIVE, damage: 1 });
 
     game.move.select(move);
     await game.phaseInterceptor.to("TurnEndPhase");
 
-    expect(enemy.isFainted()).toBeTruthy();
+    expect(enemy.isFainted()).toBe(true);
   });
 });

test/moves/protect.test.ts

@@ -1,14 +1,13 @@
 import Phaser from "phaser";
-import { afterEach, beforeAll, beforeEach, describe, expect, test, vi } from "vitest";
+import { afterEach, beforeAll, beforeEach, describe, expect, it, vi } from "vitest";
 import GameManager from "#test/testUtils/gameManager";
 import { Species } from "#enums/species";
 import { Abilities } from "#enums/abilities";
 import { Moves } from "#enums/moves";
 import { Stat } from "#enums/stat";
-import { allMoves } from "#app/data/data-lists";
-import { ArenaTagSide, ArenaTrapTag } from "#app/data/arena-tag";
-import { BattlerIndex } from "#app/battle";
 import { MoveResult } from "#app/field/pokemon";
+import { BattlerIndex } from "#app/battle";
+import { allMoves } from "#app/data/data-lists";
 
 describe("Moves - Protect", () => {
   let phaserGame: Phaser.Game;
@@ -26,92 +25,205 @@ describe("Moves - Protect", () => {
 
   beforeEach(() => {
     game = new GameManager(phaserGame);
-
+    game.override
-    game.override.battleStyle("single");
+      .battleStyle("single")
-
+      .moveset([Moves.PROTECT, Moves.SPIKY_SHIELD, Moves.ENDURE, Moves.SPLASH])
-    game.override.moveset([Moves.PROTECT]);
+      .enemySpecies(Species.SNORLAX)
-    game.override.enemySpecies(Species.SNORLAX);
+      .enemyAbility(Abilities.INSOMNIA)
-
+      .enemyMoveset(Moves.LUMINA_CRASH)
-    game.override.enemyAbility(Abilities.INSOMNIA);
+      .startingLevel(100)
-    game.override.enemyMoveset([Moves.TACKLE]);
+      .enemyLevel(100);
-
-    game.override.startingLevel(100);
-    game.override.enemyLevel(100);
   });
 
-  test("should protect the user from attacks", async () => {
+  it("should protect the user from attacks and their secondary effects", async () => {
     await game.classicMode.startBattle([Species.CHARIZARD]);
 
-    const leadPokemon = game.scene.getPlayerPokemon()!;
+    const charizard = game.scene.getPlayerPokemon()!;
 
     game.move.select(Moves.PROTECT);
-
     await game.phaseInterceptor.to("BerryPhase", false);
 
-    expect(leadPokemon.hp).toBe(leadPokemon.getMaxHp());
+    expect(charizard.hp).toBe(charizard.getMaxHp());
+    expect(charizard.getStatStage(Stat.SPDEF)).toBe(0);
+    expect(charizard);
   });
 
-  test("should prevent secondary effects from the opponent's attack", async () => {
+  it.each<{ numTurns: number; chance: number }>([
-    game.override.enemyMoveset([Moves.CEASELESS_EDGE]);
+    { numTurns: 1, chance: 3 },
-    vi.spyOn(allMoves[Moves.CEASELESS_EDGE], "accuracy", "get").mockReturnValue(100);
+    { numTurns: 2, chance: 9 },
-
+    { numTurns: 3, chance: 27 },
+    { numTurns: 4, chance: 81 },
+  ])("should have a 1/$chance success rate after $times successful uses", async ({ numTurns, chance }) => {
     await game.classicMode.startBattle([Species.CHARIZARD]);
 
-    const leadPokemon = game.scene.getPlayerPokemon()!;
+    const charizard = game.scene.getPlayerPokemon()!;
+
+    // mock RNG roll to suceed unless exactly the desired chance is hit
+    vi.spyOn(charizard, "randBattleSeedInt").mockImplementation(range => (range !== chance ? 0 : 1));
+    const conditionSpy = vi.spyOn(allMoves[Moves.PROTECT]["conditions"][0], "apply");
+
+    // click protect many times
+    for (let x = 0; x < numTurns; x++) {
+      game.move.select(Moves.PROTECT);
+      await game.toNextTurn();
+
+      expect(charizard.hp).toBe(charizard.getMaxHp());
+      expect(charizard.getLastXMoves()[0].result).toBe(MoveResult.SUCCESS);
+      expect(conditionSpy).toHaveLastReturnedWith(true);
+    }
 
     game.move.select(Moves.PROTECT);
+    await game.toNextTurn();
 
-    await game.phaseInterceptor.to("BerryPhase", false);
+    expect(charizard.hp).toBeLessThan(charizard.getMaxHp());
-
+    expect(charizard.getLastXMoves()[0].result).toBe(MoveResult.FAIL);
-    expect(leadPokemon.hp).toBe(leadPokemon.getMaxHp());
+    expect(conditionSpy).toHaveLastReturnedWith(false);
-    expect(game.scene.arena.getTagOnSide(ArenaTrapTag, ArenaTagSide.ENEMY)).toBeUndefined();
   });
 
-  test("should protect the user from status moves", async () => {
+  it("should share fail chance with all move variants", async () => {
-    game.override.enemyMoveset([Moves.CHARM]);
-
     await game.classicMode.startBattle([Species.CHARIZARD]);
 
-    const leadPokemon = game.scene.getPlayerPokemon()!;
+    const charizard = game.scene.getPlayerPokemon()!;
+    charizard.tempSummonData.waveMoveHistory = [
+      { move: Moves.ENDURE, result: MoveResult.SUCCESS, targets: [BattlerIndex.PLAYER] },
+      { move: Moves.SPIKY_SHIELD, result: MoveResult.SUCCESS, targets: [BattlerIndex.PLAYER] },
+    ];
+    // force protect to fail on anything >=2 uses (1/9 chance)
+    vi.spyOn(charizard, "randBattleSeedInt").mockImplementation(range => (range >= 9 ? 1 : 0));
 
     game.move.select(Moves.PROTECT);
+    await game.toNextTurn();
 
-    await game.phaseInterceptor.to("BerryPhase", false);
+    expect(charizard.getLastXMoves()[0].result).toBe(MoveResult.FAIL);
-
-    expect(leadPokemon.getStatStage(Stat.ATK)).toBe(0);
   });
 
-  test("should stop subsequent hits of a multi-hit move", async () => {
+  it("should reset fail chance on move failure", async () => {
+    await game.classicMode.startBattle([Species.CHARIZARD]);
+
+    const charizard = game.scene.getPlayerPokemon()!;
+    // force protect to always fail if RNG roll attempt is made
+    vi.spyOn(charizard, "randBattleSeedInt").mockReturnValue(1);
+
+    game.move.select(Moves.PROTECT);
+    await game.toNextTurn();
+    expect(charizard.getLastXMoves()[0].result).toBe(MoveResult.SUCCESS);
+
+    game.move.select(Moves.SPIKY_SHIELD);
+    await game.toNextTurn();
+    expect(charizard.getLastXMoves()[0].result).toBe(MoveResult.FAIL);
+
+    game.move.select(Moves.SPIKY_SHIELD);
+    await game.toNextTurn();
+    expect(charizard.getLastXMoves()[0].result).toBe(MoveResult.SUCCESS);
+  });
+
+  it("should reset fail chance on using another move", async () => {
+    await game.classicMode.startBattle([Species.CHARIZARD]);
+
+    const charizard = game.scene.getPlayerPokemon()!;
+    // force protect to always fail if RNG roll attempt is made
+    vi.spyOn(charizard, "randBattleSeedInt").mockReturnValue(1);
+
+    game.move.select(Moves.PROTECT);
+    await game.toNextTurn();
+    expect(charizard.getLastXMoves()[0].result).toBe(MoveResult.SUCCESS);
+
+    game.move.select(Moves.SPLASH);
+    await game.toNextTurn();
+
+    game.move.select(Moves.PROTECT);
+    await game.toNextTurn();
+    expect(charizard.getLastXMoves()[0].result).toBe(MoveResult.SUCCESS);
+  });
+
+  it("should reset fail chance on starting a new wave", async () => {
+    await game.classicMode.startBattle([Species.CHARIZARD]);
+
+    const charizard = game.scene.getPlayerPokemon()!;
+    // force protect to always fail if RNG roll attempt is made
+    vi.spyOn(charizard, "randBattleSeedInt").mockReturnValue(1);
+
+    game.move.select(Moves.PROTECT);
+    // Wait until move end phase to kill opponent to ensure protect doesn't fail due to going last
+    await game.phaseInterceptor.to("MoveEndPhase");
+    await game.doKillOpponents();
+    await game.toNextWave();
+    expect(charizard.getLastXMoves()[0].result).toBe(MoveResult.SUCCESS);
+
+    game.move.select(Moves.SPIKY_SHIELD);
+    expect(charizard.getLastXMoves()[0].result).toBe(MoveResult.SUCCESS);
+  });
+
+  it("should not be blocked by Psychic Terrain", async () => {
+    game.override.ability(Abilities.PSYCHIC_SURGE);
+    await game.classicMode.startBattle([Species.CHARIZARD]);
+
+    const charizard = game.scene.getPlayerPokemon()!;
+    game.move.select(Moves.PROTECT);
+    await game.toNextTurn();
+
+    expect(charizard.getLastXMoves()[0].result).toBe(MoveResult.SUCCESS);
+  });
+
+  it("should stop subsequent hits of multi-hit moves", async () => {
     game.override.enemyMoveset([Moves.TACHYON_CUTTER]);
-
     await game.classicMode.startBattle([Species.CHARIZARD]);
 
-    const leadPokemon = game.scene.getPlayerPokemon()!;
+    const charizard = game.scene.getPlayerPokemon()!;
     const enemyPokemon = game.scene.getEnemyPokemon()!;
 
     game.move.select(Moves.PROTECT);
-
     await game.phaseInterceptor.to("BerryPhase", false);
 
-    expect(leadPokemon.hp).toBe(leadPokemon.getMaxHp());
+    expect(charizard.hp).toBe(charizard.getMaxHp());
     expect(enemyPokemon.turnData.hitCount).toBe(1);
   });
 
-  test("should fail if the user is the last to move in the turn", async () => {
+  it("should fail if the user moves last in the turn", async () => {
-    game.override.enemyMoveset([Moves.PROTECT]);
+    game.override.enemyMoveset(Moves.PROTECT);
-
     await game.classicMode.startBattle([Species.CHARIZARD]);
 
-    const leadPokemon = game.scene.getPlayerPokemon()!;
+    const charizard = game.scene.getPlayerPokemon()!;
     const enemyPokemon = game.scene.getEnemyPokemon()!;
 
     game.move.select(Moves.PROTECT);
-
     await game.setTurnOrder([BattlerIndex.ENEMY, BattlerIndex.PLAYER]);
-
     await game.phaseInterceptor.to("BerryPhase", false);
 
     expect(enemyPokemon.getLastXMoves()[0].result).toBe(MoveResult.SUCCESS);
-    expect(leadPokemon.getLastXMoves()[0].result).toBe(MoveResult.FAIL);
+    expect(charizard.getLastXMoves()[0].result).toBe(MoveResult.FAIL);
   });
+
+  it("should not block Protection-bypassing moves or Future Sight", async () => {
+    game.override.enemyMoveset([Moves.FUTURE_SIGHT, Moves.MIGHTY_CLEAVE, Moves.SPORE]);
+    await game.classicMode.startBattle([Species.AGGRON]);
+
+    const aggron = game.scene.getPlayerPokemon()!;
+    vi.spyOn(aggron, "randBattleSeedInt").mockReturnValue(0);
+
+    // Turn 1: setup future sight
+    game.move.select(Moves.PROTECT);
+    await game.forceEnemyMove(Moves.FUTURE_SIGHT);
+    await game.toNextTurn();
+
+    // Turn 2: mighty cleave
+    game.move.select(Moves.PROTECT);
+    await game.forceEnemyMove(Moves.MIGHTY_CLEAVE);
+    await game.toNextTurn();
+
+    expect(aggron.hp).toBeLessThan(aggron.getMaxHp());
+
+    aggron.hp = aggron.getMaxHp();
+
+    // turn 3: Future Sight hits
+    game.move.select(Moves.PROTECT);
+    await game.forceEnemyMove(Moves.SPORE);
+    await game.toNextTurn();
+
+    expect(aggron.hp).toBeLessThan(aggron.getMaxHp());
+    expect(aggron.status?.effect).toBeUndefined(); // check that protect actually worked
+  });
+
+  // TODO: Add test
+  it.todo("should not reset counter when throwing balls");
 });

test/moves/quick_guard.test.ts

@@ -1,10 +1,9 @@
 import Phaser from "phaser";
-import { afterEach, beforeAll, beforeEach, describe, expect, test } from "vitest";
+import { afterEach, beforeAll, beforeEach, describe, expect, it, vi } from "vitest";
 import GameManager from "#test/testUtils/gameManager";
 import { Species } from "#enums/species";
 import { Abilities } from "#enums/abilities";
 import { Moves } from "#enums/moves";
-import { Stat } from "#enums/stat";
 import { BattlerIndex } from "#app/battle";
 import { MoveResult } from "#app/field/pokemon";
 
@@ -25,80 +24,74 @@ describe("Moves - Quick Guard", () => {
   beforeEach(() => {
     game = new GameManager(phaserGame);
 
-    game.override.battleStyle("double");
+    game.override
-
+      .battleStyle("double")
-    game.override.moveset([Moves.QUICK_GUARD, Moves.SPLASH, Moves.FOLLOW_ME]);
+      .moveset([Moves.QUICK_GUARD, Moves.SPLASH, Moves.SPIKY_SHIELD])
-
+      .enemySpecies(Species.SNORLAX)
-    game.override.enemySpecies(Species.SNORLAX);
+      .enemyMoveset(Moves.QUICK_ATTACK)
-    game.override.enemyMoveset([Moves.QUICK_ATTACK]);
+      .enemyAbility(Abilities.BALL_FETCH)
-    game.override.enemyAbility(Abilities.INSOMNIA);
+      .startingLevel(100)
-
+      .enemyLevel(100);
-    game.override.startingLevel(100);
-    game.override.enemyLevel(100);
   });
 
-  test("should protect the user and allies from priority moves", async () => {
+  it("should protect the user and allies from priority moves", async () => {
     await game.classicMode.startBattle([Species.CHARIZARD, Species.BLASTOISE]);
 
-    const playerPokemon = game.scene.getPlayerField();
+    const [charizard, blastoise] = game.scene.getPlayerField();
-
-    game.move.select(Moves.QUICK_GUARD);
-    game.move.select(Moves.SPLASH, 1);
 
+    game.move.select(Moves.QUICK_GUARD, BattlerIndex.PLAYER);
+    game.move.select(Moves.SPLASH, BattlerIndex.PLAYER_2);
+    await game.forceEnemyMove(Moves.QUICK_ATTACK, BattlerIndex.PLAYER);
+    await game.forceEnemyMove(Moves.QUICK_ATTACK, BattlerIndex.PLAYER_2);
     await game.phaseInterceptor.to("BerryPhase", false);
 
-    playerPokemon.forEach(p => expect(p.hp).toBe(p.getMaxHp()));
+    expect(charizard.hp).toBe(charizard.getMaxHp());
+    expect(blastoise.hp).toBe(blastoise.getMaxHp());
   });
 
-  test("should protect the user and allies from Prankster-boosted moves", async () => {
+  it.each<{ name: string; move: Moves; ability: Abilities }>([
-    game.override.enemyAbility(Abilities.PRANKSTER);
+    { name: "Prankster", move: Moves.SPORE, ability: Abilities.PRANKSTER },
-    game.override.enemyMoveset([Moves.GROWL]);
+    { name: "Gale Wings", move: Moves.BRAVE_BIRD, ability: Abilities.GALE_WINGS },
-
+  ])("should protect the user and allies from $name-boosted moves", async ({ move, ability }) => {
+    game.override.enemyMoveset(move).enemyAbility(ability);
     await game.classicMode.startBattle([Species.CHARIZARD, Species.BLASTOISE]);
 
-    const playerPokemon = game.scene.getPlayerField();
+    const [charizard, blastoise] = game.scene.getPlayerField();
-
-    game.move.select(Moves.QUICK_GUARD);
-    game.move.select(Moves.SPLASH, 1);
 
+    game.move.select(Moves.QUICK_GUARD, BattlerIndex.PLAYER);
+    game.move.select(Moves.SPLASH, BattlerIndex.PLAYER_2);
+    await game.forceEnemyMove(move, BattlerIndex.PLAYER);
+    await game.forceEnemyMove(move, BattlerIndex.PLAYER_2);
     await game.phaseInterceptor.to("BerryPhase", false);
 
-    playerPokemon.forEach(p => expect(p.getStatStage(Stat.ATK)).toBe(0));
+    expect(charizard.hp).toBe(charizard.getMaxHp());
+    expect(blastoise.hp).toBe(blastoise.getMaxHp());
+    expect(charizard.status?.effect).toBeUndefined();
+    expect(blastoise.status?.effect).toBeUndefined();
   });
 
-  test("should stop subsequent hits of a multi-hit priority move", async () => {
+  it("should increment (but not respect) other protection moves' fail counters", async () => {
-    game.override.enemyMoveset([Moves.WATER_SHURIKEN]);
-
-    await game.classicMode.startBattle([Species.CHARIZARD, Species.BLASTOISE]);
-
-    const playerPokemon = game.scene.getPlayerField();
-    const enemyPokemon = game.scene.getEnemyField();
-
-    game.move.select(Moves.QUICK_GUARD);
-    game.move.select(Moves.FOLLOW_ME, 1);
-
-    await game.phaseInterceptor.to("BerryPhase", false);
-
-    playerPokemon.forEach(p => expect(p.hp).toBe(p.getMaxHp()));
-    enemyPokemon.forEach(p => expect(p.turnData.hitCount).toBe(1));
-  });
-
-  test("should fail if the user is the last to move in the turn", async () => {
     game.override.battleStyle("single");
-    game.override.enemyMoveset([Moves.QUICK_GUARD]);
-
     await game.classicMode.startBattle([Species.CHARIZARD]);
 
-    const playerPokemon = game.scene.getPlayerPokemon()!;
+    const charizard = game.scene.getPlayerPokemon()!;
-    const enemyPokemon = game.scene.getEnemyPokemon()!;
+    // force protect to fail on anything >0 uses
+    vi.spyOn(charizard, "randBattleSeedInt").mockReturnValue(1);
 
     game.move.select(Moves.QUICK_GUARD);
+    await game.toNextTurn();
 
-    await game.setTurnOrder([BattlerIndex.ENEMY, BattlerIndex.PLAYER]);
+    expect(charizard.getLastXMoves()[0].result).toBe(MoveResult.SUCCESS);
 
-    await game.phaseInterceptor.to("BerryPhase", false);
+    game.move.select(Moves.QUICK_GUARD);
+    await game.toNextTurn();
 
-    expect(enemyPokemon.getLastXMoves()[0].result).toBe(MoveResult.SUCCESS);
+    // ignored fail chance
-    expect(playerPokemon.getLastXMoves()[0].result).toBe(MoveResult.FAIL);
+    expect(charizard.getLastXMoves()[0].result).toBe(MoveResult.SUCCESS);
+
+    game.move.select(Moves.SPIKY_SHIELD);
+    await game.toNextTurn();
+
+    expect(charizard.getLastXMoves()[0].result).toBe(MoveResult.FAIL);
   });
 });

test/moves/wide_guard.test.ts

@@ -1,12 +1,12 @@
 import Phaser from "phaser";
-import { afterEach, beforeAll, beforeEach, describe, expect, test } from "vitest";
+import { afterEach, beforeAll, beforeEach, describe, expect, it, vi } from "vitest";
 import GameManager from "#test/testUtils/gameManager";
 import { Species } from "#enums/species";
 import { Abilities } from "#enums/abilities";
 import { Moves } from "#enums/moves";
 import { Stat } from "#enums/stat";
-import { BerryPhase } from "#app/phases/berry-phase";
+import { BattlerIndex } from "#app/battle";
-import { CommandPhase } from "#app/phases/command-phase";
+import { MoveResult } from "#app/field/pokemon";
 
 describe("Moves - Wide Guard", () => {
   let phaserGame: Phaser.Game;
@@ -25,87 +25,86 @@ describe("Moves - Wide Guard", () => {
   beforeEach(() => {
     game = new GameManager(phaserGame);
 
-    game.override.battleStyle("double");
+    game.override
-
+      .battleStyle("double")
-    game.override.moveset([Moves.WIDE_GUARD, Moves.SPLASH, Moves.SURF]);
+      .moveset([Moves.WIDE_GUARD, Moves.SPLASH, Moves.SURF, Moves.SPIKY_SHIELD])
-
+      .enemySpecies(Species.SNORLAX)
-    game.override.enemySpecies(Species.SNORLAX);
+      .enemyMoveset([Moves.SWIFT, Moves.GROWL, Moves.TACKLE])
-    game.override.enemyMoveset([Moves.SWIFT]);
+      .enemyAbility(Abilities.INSOMNIA)
-    game.override.enemyAbility(Abilities.INSOMNIA);
+      .startingLevel(100)
-
+      .enemyLevel(100);
-    game.override.startingLevel(100);
-    game.override.enemyLevel(100);
   });
 
-  test("should protect the user and allies from multi-target attack moves", async () => {
+  it("should protect the user and allies from multi-target attack and status moves", async () => {
-    await game.startBattle([Species.CHARIZARD, Species.BLASTOISE]);
+    await game.classicMode.startBattle([Species.CHARIZARD, Species.BLASTOISE]);
+    const [charizard, blastoise] = game.scene.getPlayerField();
 
-    const leadPokemon = game.scene.getPlayerField();
+    game.move.select(Moves.WIDE_GUARD, BattlerIndex.PLAYER);
+    game.move.select(Moves.SPLASH, BattlerIndex.PLAYER_2);
+    await game.forceEnemyMove(Moves.SWIFT);
+    await game.forceEnemyMove(Moves.GROWL);
+    await game.phaseInterceptor.to("TurnEndPhase");
 
-    game.move.select(Moves.WIDE_GUARD);
+    expect(charizard.hp).toBe(charizard.getMaxHp());
-
+    expect(blastoise.hp).toBe(blastoise.getMaxHp());
-    await game.phaseInterceptor.to(CommandPhase);
+    expect(charizard.getStatStage(Stat.ATK)).toBe(0);
-
+    expect(blastoise.getStatStage(Stat.ATK)).toBe(0);
-    game.move.select(Moves.SPLASH, 1);
-
-    await game.phaseInterceptor.to(BerryPhase, false);
-
-    leadPokemon.forEach(p => expect(p.hp).toBe(p.getMaxHp()));
   });
 
-  test("should protect the user and allies from multi-target status moves", async () => {
+  it("should not protect the user and allies from single-target moves", async () => {
-    game.override.enemyMoveset([Moves.GROWL]);
+    await game.classicMode.startBattle([Species.CHARIZARD, Species.BLASTOISE]);
 
-    await game.startBattle([Species.CHARIZARD, Species.BLASTOISE]);
+    const [charizard, blastoise] = game.scene.getPlayerField();
+    game.move.select(Moves.WIDE_GUARD, BattlerIndex.PLAYER);
+    game.move.select(Moves.SPLASH, BattlerIndex.PLAYER_2);
+    await game.forceEnemyMove(Moves.TACKLE, BattlerIndex.PLAYER);
+    await game.forceEnemyMove(Moves.TACKLE, BattlerIndex.PLAYER_2);
+    await game.phaseInterceptor.to("TurnEndPhase");
 
-    const leadPokemon = game.scene.getPlayerField();
+    expect(charizard.hp).toBeLessThan(charizard.getMaxHp());
-
+    expect(blastoise.hp).toBeLessThan(blastoise.getMaxHp());
-    game.move.select(Moves.WIDE_GUARD);
-
-    await game.phaseInterceptor.to(CommandPhase);
-
-    game.move.select(Moves.SPLASH, 1);
-
-    await game.phaseInterceptor.to(BerryPhase, false);
-
-    leadPokemon.forEach(p => expect(p.getStatStage(Stat.ATK)).toBe(0));
   });
 
-  test("should not protect the user and allies from single-target moves", async () => {
+  it("should protect the user from its ally's multi-target move", async () => {
-    game.override.enemyMoveset([Moves.TACKLE]);
+    game.override.enemyMoveset(Moves.SPLASH);
 
-    await game.startBattle([Species.CHARIZARD, Species.BLASTOISE]);
+    await game.classicMode.startBattle([Species.CHARIZARD, Species.BLASTOISE]);
 
-    const leadPokemon = game.scene.getPlayerField();
+    const charizard = game.scene.getPlayerPokemon()!;
+    const [snorlax1, snorlax2] = game.scene.getEnemyField();
 
-    game.move.select(Moves.WIDE_GUARD);
+    game.move.select(Moves.WIDE_GUARD, BattlerIndex.PLAYER);
+    game.move.select(Moves.SURF, BattlerIndex.PLAYER_2);
+    await game.phaseInterceptor.to("TurnEndPhase");
 
-    await game.phaseInterceptor.to(CommandPhase);
+    expect(charizard.hp).toBe(charizard.getMaxHp());
-
+    expect(snorlax1.hp).toBeLessThan(snorlax1.getMaxHp());
-    game.move.select(Moves.SPLASH, 1);
+    expect(snorlax2.hp).toBeLessThan(snorlax2.getMaxHp());
-
-    await game.phaseInterceptor.to(BerryPhase, false);
-
-    expect(leadPokemon.some(p => p.hp < p.getMaxHp())).toBeTruthy();
   });
 
-  test("should protect the user from its ally's multi-target move", async () => {
+  it("should increment (but not respect) other protection moves' fail counters", async () => {
-    game.override.enemyMoveset([Moves.SPLASH]);
+    game.override.battleStyle("single");
+    await game.classicMode.startBattle([Species.CHARIZARD]);
 
-    await game.startBattle([Species.CHARIZARD, Species.BLASTOISE]);
+    const charizard = game.scene.getPlayerPokemon()!;
-
+    // force protect to fail on anything other than a guaranteed success
-    const leadPokemon = game.scene.getPlayerField();
+    vi.spyOn(charizard, "randBattleSeedInt").mockReturnValue(1);
-    const enemyPokemon = game.scene.getEnemyField();
 
     game.move.select(Moves.WIDE_GUARD);
+    await game.toNextTurn();
 
-    await game.phaseInterceptor.to(CommandPhase);
+    expect(charizard.getLastXMoves()[0].result).toBe(MoveResult.SUCCESS);
 
-    game.move.select(Moves.SURF, 1);
+    // ignored fail chance
+    game.move.select(Moves.WIDE_GUARD);
+    await game.toNextTurn();
 
-    await game.phaseInterceptor.to(BerryPhase, false);
+    expect(charizard.getLastXMoves()[0].result).toBe(MoveResult.SUCCESS);
 
-    expect(leadPokemon[0].hp).toBe(leadPokemon[0].getMaxHp());
+    game.move.select(Moves.SPIKY_SHIELD);
-    enemyPokemon.forEach(p => expect(p.hp).toBeLessThan(p.getMaxHp()));
+    await game.toNextTurn();
+
+    // ignored fail chance
+    expect(charizard.getLastXMoves()[0].result).toBe(MoveResult.FAIL);
   });
 });