From 2409a2547d1fd382ddbb348a6b1ed352db724441 Mon Sep 17 00:00:00 2001 From: Mumble <171087428+frutescens@users.noreply.github.com> Date: Thu, 24 Oct 2024 18:41:41 -0700 Subject: [PATCH] Apply suggestions from code review Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com> --- src/data/ability.ts | 1 + src/test/moves/forests_curse.test.ts | 2 +- src/test/moves/reflect_type.test.ts | 2 +- src/test/moves/trick_or_treat.test.ts | 2 +- 4 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/data/ability.ts b/src/data/ability.ts index dfeb8b8d6b3..c32003b679c 100644 --- a/src/data/ability.ts +++ b/src/data/ability.ts @@ -4681,6 +4681,7 @@ export class PreventBypassSpeedChanceAbAttr extends AbAttr { /** * This applies a terrain-based type change to the Pokemon. + * Used by Mimicry. */ export class TerrainEventTypeChangeAbAttr extends PostSummonAbAttr { constructor() { diff --git a/src/test/moves/forests_curse.test.ts b/src/test/moves/forests_curse.test.ts index dca2c98732f..c49bdab5255 100644 --- a/src/test/moves/forests_curse.test.ts +++ b/src/test/moves/forests_curse.test.ts @@ -32,7 +32,7 @@ describe("Moves - Forest's Curse", () => { .enemyMoveset(Moves.SPLASH); }); - it("Using Forest's Curse on a Pokemon affected by Trick Or Treat will replace the Ghost-type with Grass", async () => { + it("will replace the added type from Trick Or Treat", async () => { await game.classicMode.startBattle([ Species.FEEBAS ]); const enemyPokemon = game.scene.getEnemyPokemon(); diff --git a/src/test/moves/reflect_type.test.ts b/src/test/moves/reflect_type.test.ts index 17f1eb112b7..0e47d4b00fc 100644 --- a/src/test/moves/reflect_type.test.ts +++ b/src/test/moves/reflect_type.test.ts @@ -29,7 +29,7 @@ describe("Moves - Reflect Type", () => { .enemyAbility(Abilities.BALL_FETCH); }); - it("If a typeless Pokemon has additionally been affected by Forest's Curse or Trick-or-Treat, however, Reflect Type will cause the user to become a Normal type with an added Grass or Ghost type respectively", async () => { + it("will make the user Normal/Grass if targetting a typeless Pokemon affected by Forest's Curse", async () => { game.override .moveset([ Moves.FORESTS_CURSE, Moves.REFLECT_TYPE ]) .startingLevel(60) diff --git a/src/test/moves/trick_or_treat.test.ts b/src/test/moves/trick_or_treat.test.ts index 309ab69375c..7ecd00ed076 100644 --- a/src/test/moves/trick_or_treat.test.ts +++ b/src/test/moves/trick_or_treat.test.ts @@ -32,7 +32,7 @@ describe("Moves - Trick Or Treat", () => { .enemyMoveset(Moves.SPLASH); }); - it("Using Trick Or Treat on a Pokemon affected by Forest's Curse will replace the Grass-type with Ghost", async () => { + it("will replace added type from Forest's Curse", async () => { await game.classicMode.startBattle([ Species.FEEBAS ]); const enemyPokemon = game.scene.getEnemyPokemon();