mika/pokerogue
1
0
Fork 0
mirror of https://github.com/pagefaultgames/pokerogue.git synced 2025-08-17 12:59:25 +02:00
Code Issues Packages Projects Releases Wiki Activity

Apply Kev's suggestions from code review

Browse Source 
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
This commit is contained in:
Sirz Benjie 2025-08-12 16:56:23 -05:00 committed by GitHub
parent 870fafa0bc
commit 1373e07fcc
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/constants.ts
View File

@ -103,7 +103,7 @@ export const ANTI_VARIANCE_WEIGHT_MODIFIER = 15;
export const FAKE_TITLE_LOGO_CHANCE = 10000; export const FAKE_TITLE_LOGO_CHANCE = 10000;
/** /**
* The ceiling on friendshp amount that can be reached through the use of rare candies. * The ceiling on friendship amount that can be reached through the use of rare candies.
* Using rare candies will never increase friendship beyond this value. * Using rare candies will never increase friendship beyond this value.
*/ */
export const RARE_CANDY_FRIENDSHIP_CAP = 200; export const RARE_CANDY_FRIENDSHIP_CAP = 200;

1
src/system/ribbons/ribbon-data.ts
View File

@ -1,4 +1,5 @@
import type { Brander } from "#types/type-helpers"; import type { Brander } from "#types/type-helpers";
export type RibbonFlag = (number & Brander<"RibbonFlag">) | 0; export type RibbonFlag = (number & Brander<"RibbonFlag">) | 0;
/** /**

2
src/system/ribbons/ribbon-methods.ts
View File

@ -8,7 +8,7 @@ import { isNullOrUndefined } from "#utils/common";
* Award one or more ribbons to a species and its pre-evolutions * Award one or more ribbons to a species and its pre-evolutions
* *
* @param id - The ID of the species to award ribbons to * @param id - The ID of the species to award ribbons to
* @param ribbons The ribbon(s) to award (use bitwise OR to combine multiple) * @param ribbons - The ribbon(s) to award (use bitwise OR to combine multiple)
*/ */
export function awardRibbonsToSpeciesLine(id: SpeciesId, ribbons: RibbonFlag): void { export function awardRibbonsToSpeciesLine(id: SpeciesId, ribbons: RibbonFlag): void {
const dexData = globalScene.gameData.dexData; const dexData = globalScene.gameData.dexData;