From 12e3def562f2cae70f74965e05e1d1772edb50cf Mon Sep 17 00:00:00 2001 From: Bertie690 Date: Thu, 24 Apr 2025 21:14:07 -0400 Subject: [PATCH] Moved vule to biom --- biome.jsonc | 2 +- eslint.config.js | 3 --- src/ui-inputs.ts | 2 +- 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/biome.jsonc b/biome.jsonc index caed6720d2f..2e4b1e77f14 100644 --- a/biome.jsonc +++ b/biome.jsonc @@ -76,7 +76,7 @@ "noExplicitAny": "off", // TODO: Refactor and make this an error after save data refactored "noAssignInExpressions": "off", "noPrototypeBuiltins": "off", - "noFallthroughSwitchClause": "off", // Handled by ESLint due to not supporting simple "falls through" commenst + "noFallthroughSwitchClause": "error", // Prevent accidental automatic fallthroughs in switch cases (use disable comment if needed) "noImplicitAnyLet": "info", // TODO: Refactor and make this an error "noRedeclare": "off", // TODO: Refactor and make this an error "noGlobalIsNan": "off", diff --git a/eslint.config.js b/eslint.config.js index 61a96031fed..aebcab7feae 100644 --- a/eslint.config.js +++ b/eslint.config.js @@ -18,9 +18,6 @@ export default tseslint.config( "@typescript-eslint": tseslint.plugin, }, rules: { - // Prevent fallthrough on switch without an explicit "falls through" comment with explanatino. - // Note: Move to biome if/when they add "falls through" comments - "no-fallthrough": ["error", { commentPattern: "^ falls through" }], "no-undef": "off", // Disables the rule that disallows the use of undeclared variables (TypeScript handles this) "no-extra-semi": "error", // Disallows unnecessary semicolons for TypeScript-specific syntax "import-x/extensions": ["error", "never", { json: "always" }], // Enforces no extension for imports unless json diff --git a/src/ui-inputs.ts b/src/ui-inputs.ts index 5a3871cd1f0..0c13cdb9512 100644 --- a/src/ui-inputs.ts +++ b/src/ui-inputs.ts @@ -181,7 +181,7 @@ export class UiInputs { if (!messageHandler.pendingPrompt || messageHandler.isTextAnimationInProgress()) { return; } - // falls through + // biome-ignore lint/suspicious/noFallthroughSwitchClause: falls through to show menu overlay } case UiMode.TITLE: case UiMode.COMMAND: