mika/pokerogue
1
0
Fork 0
mirror of https://github.com/pagefaultgames/pokerogue.git synced 2025-07-06 16:32:16 +02:00
Code Issues Packages Projects Releases Wiki Activity

Comments so developer doesn't get bugged about garbage collecton

Browse Source
This commit is contained in:
frutescens 2024-09-01 17:19:26 -07:00
parent 290f3dd8f3
commit 0c122af8fa
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/battle-scene.ts
View File

@ -2735,6 +2735,7 @@ export default class BattleScene extends SceneBase {
/** /**
* This function retrieves the sprite and audio keys for active Pokemon. * This function retrieves the sprite and audio keys for active Pokemon.
* Active Pokemon include both enemy and player Pokemon of the current wave. * Active Pokemon include both enemy and player Pokemon of the current wave.
* Note: Questions on garbage collection go to @frutescens
* @returns a string array of active sprite and audio keys that should not be deleted * @returns a string array of active sprite and audio keys that should not be deleted
*/ */
getActiveKeys(): string[] { getActiveKeys(): string[] {

3
src/ui/egg-summary-ui-handler.ts
View File

@ -89,8 +89,7 @@ export default class EggSummaryUiHandler extends MessageUiHandler {
this.pokemonIconsContainer.removeAll(true); this.pokemonIconsContainer.removeAll(true);
this.eggHatchBg.setVisible(false); this.eggHatchBg.setVisible(false);
this.getUi().hideTooltip(); this.getUi().hideTooltip();
// Note: Questions on garbage collection go to @frutescens
const activeKeys = this.scene.getActiveKeys(); const activeKeys = this.scene.getActiveKeys();
// Removing unnecessary sprites from animation manager // Removing unnecessary sprites from animation manager
const animKeys = Object.keys(this.scene.anims["anims"]["entries"]); const animKeys = Object.keys(this.scene.anims["anims"]["entries"]);