From 2ee8c440dacf96a6f1de385955ac09b31772c8e0 Mon Sep 17 00:00:00 2001 From: Dave Murphy Date: Mon, 19 Mar 2018 13:51:04 +0000 Subject: [PATCH] make sure path doesn't overflow --- common/netloader.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/common/netloader.c b/common/netloader.c index 3e8e2e6..8e2fd08 100644 --- a/common/netloader.c +++ b/common/netloader.c @@ -331,7 +331,9 @@ int loadnro(menuEntry_s *me, int sock, struct in_addr remote) { sanitisePath(filename); - sprintf(me->path, "%s%s%s", menuGetRootPath(), DIRECTORY_SEPARATOR, filename); + snprintf(me->path, PATH_MAX, "%s%s%s", menuGetRootPath(), DIRECTORY_SEPARATOR, filename); + // make sure it's terminated + me->path[PATH_MAX] = 0; argData_s* ad = &me->args; ad->dst = (char*)&ad->buf[1];